Skip to content

HBASE-24066 Let HBase master UI act as a maven repo - #1365

Closed
joshelser wants to merge 3 commits into
apache:branch-2.2from
joshelser:24066-webui-maven-repo
Closed

HBASE-24066 Let HBase master UI act as a maven repo#1365
joshelser wants to merge 3 commits into
apache:branch-2.2from
joshelser:24066-webui-maven-repo

Conversation

@joshelser

@joshelserjoshelser commented Mar 26, 2020

Copy link
Copy Markdown
Member

Advertise the version of HBase over the web UI and have a well-known
location from which users can pull shaded client jars from.

Rooted against branch-2.2, but that's just what I was working against when hacking this together. Intention would be for master, and any 2.x branches which want it.

@joshelser
HBASE-24066 Let HBase Master UI act as maven repository
947065c
Advertise the version of HBase over the web UI and have a well-known
location from which users can pull shaded client jars from.
@joshelser

joshelser commented Mar 26, 2020

Copy link
Copy Markdown
MemberAuthor

https://github.com/joshelser/HBASE-24066-webui-maven-repo-exemplar is the example of how a user might use this feature.

@Apache-HBase

Apache-HBase commented Mar 26, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall8m 6sbranch-2.2 passed
+1 💚compile1m 22sbranch-2.2 passed
+1 💚checkstyle0m 45sbranch-2.2 passed
+1 💚shadedjars6m 25sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51sbranch-2.2 passed
+0 🆗spotbugs0m 53sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 49sbranch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall7m 30sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚checkstyle0m 41sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 4sThe patch has no ill-formed XML file.
+1 💚shadedjars6m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck28m 28sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚javadoc0m 30sthe patch passed
+0 🆗findbugs0m 27shbase-assembly has no data from findbugs
_ Other Tests _
+1 💚unit1m 1shbase-http in the patch passed.
+1 💚unit0m 27shbase-assembly in the patch passed.
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
77m 50s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile
GITHUB PR#1365
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
unameLinux 153a3de1b2da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 1777513
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/
Max. process+thread count261 (vs. ulimit of 10000)
modulesC: hbase-http hbase-assembly U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 26, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 10sbranch-2.2 passed
+1 💚compile0m 48sbranch-2.2 passed
+1 💚checkstyle0m 26sbranch-2.2 passed
+1 💚shadedjars4m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sbranch-2.2 passed
+0 🆗spotbugs0m 34sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 29sbranch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 46sthe patch passed
+1 💚compile0m 48sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚checkstyle0m 25sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚shadedjars4m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck22m 24sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚javadoc0m 32sthe patch passed
+0 🆗findbugs0m 28shbase-assembly has no data from findbugs
_ Other Tests _
+1 💚unit1m 3shbase-http in the patch passed.
+1 💚unit0m 27shbase-assembly in the patch passed.
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
55m 54s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/artifact/out/Dockerfile
GITHUB PR#1365
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
unameLinux eeddef3b1488 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 1777513
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/testReport/
Max. process+thread count283 (vs. ulimit of 10000)
modulesC: hbase-http hbase-assembly U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 5, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 52sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall5m 33sbranch-2.2 passed
+1 💚compile0m 46sbranch-2.2 passed
+1 💚checkstyle0m 24sbranch-2.2 passed
+1 💚shadedjars4m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29sbranch-2.2 passed
+0 🆗spotbugs0m 35sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 30sbranch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 12sthe patch passed
+1 💚compile0m 46sthe patch passed
+1 💚javac0m 46sthe patch passed
+1 💚checkstyle0m 23sthe patch passed
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚shadedjars4m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck22m 4sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚javadoc0m 27sthe patch passed
+0 🆗findbugs0m 29shbase-assembly has no data from findbugs
_ Other Tests _
+1 💚unit1m 0shbase-http in the patch passed.
+1 💚unit0m 27shbase-assembly in the patch passed.
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
59m 46s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile
GITHUB PR#1365
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
unameLinux c936eccfd310 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 88c0883
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/
Max. process+thread count253 (vs. ulimit of 10000)
modulesC: hbase-http hbase-assembly U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed May 5, 2020
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea looks great. Just a small nit on the maven-repo directory path definitions in the assembly components.xml, as the current value gives a broken link.

Comment threadhbase-assembly/src/main/assembly/components.xml
</fileSet>
<fileSet>
<directory>${project.build.directory}/maven-repo</directory>
<outputDirectory>hbase-webapps/maven-repo</outputDirectory>

@wchevreuilwchevreuilMay 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be <outputDirectory>hbase-webapps/static/maven-repo</outputDirectory> instead.

@Apache-HBase

Apache-HBase commented May 23, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 11sbranch-2.2 passed
+1 💚compile0m 47sbranch-2.2 passed
+1 💚checkstyle0m 26sbranch-2.2 passed
+1 💚shadedjars4m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sbranch-2.2 passed
+0 🆗spotbugs0m 37sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 31sbranch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 58sthe patch passed
+1 💚compile0m 46sthe patch passed
+1 💚javac0m 46sthe patch passed
+1 💚checkstyle0m 26sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚shadedjars4m 4spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck29m 14sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚javadoc0m 33sthe patch passed
+0 🆗findbugs0m 35shbase-assembly has no data from findbugs
_ Other Tests _
+1 💚unit1m 19shbase-http in the patch passed.
+1 💚unit0m 35shbase-assembly in the patch passed.
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
64m 39s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile
GITHUB PR#1365
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
unameLinux a990d95a0991 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 9ee786e
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/
Max. process+thread count295 (vs. ulimit of 10000)
modulesC: hbase-http hbase-assembly U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@joshelser

joshelser commented May 28, 2020

Copy link
Copy Markdown
MemberAuthor

Not seeing a path forward. Closing until we think this is worth doing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshelser@Apache-HBase@wchevreuil