Uh oh!
There was an error while loading. Please reload this page.
HBASE-23584 : Descrease rpc getFileStatus count when open a storefile - #1380
HBASE-23584 : Descrease rpc getFileStatus count when open a storefile#1380HuiHang-Yu wants to merge 1 commit into
Conversation
Apache-HBase
commented
Mar 30, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 30, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 30, 2020
💔 -1 overall
This message was automatically generated. |
saintstack
left a comment
There was a problem hiding this comment.
Patch is looking good. Some nits in below.
| this.createdTimestamp = fStatus.getModificationTime(); | ||
| this.size = fStatus.getLen(); | ||
| this.localStatus = fileStatus; | ||
| }else{ |
There was a problem hiding this comment.
Please keep the style of the surrounding file; i.e. space between '}' and 'else' and after.
| } else { | ||
| throw new IOException("path=" + p + " doesn't look like a valid StoreFile"); | ||
| } | ||
| if(this.localStatus == null ){ |
There was a problem hiding this comment.
See how spacing is done in rest of the file.
| } | ||
| status = fs.getFileStatus(initialPath); | ||
| } | ||
| if(null == this.localStatus){ | ||
| throw new IOException("localStatus is not initialize on construct"); |
There was a problem hiding this comment.
Do you want to add name of file to this message if available?
Spacing.
Apache-HBase
commented
Apr 1, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 1, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 1, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 1, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 1, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 1, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 2, 2020
🎊 +1 overall
This message was automatically generated. |
HuiHang-Yu
commented
Apr 2, 2020
TestStoreFileInfo class throw FileNotFoundException is right ? I see comment like this "Test file link exception" there . |
Apache-HBase
commented
Apr 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Apr 13, 2020
I think this is an useful improvement. Seems the UT failures are related? Any progress here? Thanks. |
@Apache9 TestStoreFileInfo.java need to change a little after i put localstatus to construct . I will modify TestStoreFileInfo soon . |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 29, 2020
🎊 +1 overall
This message was automatically generated. |
| status = link.getFileStatus(fs); | ||
| } catch (FileNotFoundException ex) { | ||
| // try the other location | ||
| throw ex; |
There was a problem hiding this comment.
just throw ex it will have no chance to try the other location, see the old code, it should keep the behave with old code.
| } else { | ||
| throw new IOException("path=" + p + " doesn't look like a valid StoreFile"); | ||
| } | ||
| if(this.localStatus == null){ |
Apache-HBase
commented
Apr 29, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 29, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 6, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 6, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 6, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 8, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 8, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 8, 2020
💔 -1 overall
This message was automatically generated. |
HuiHang-Yu
commented
May 8, 2020
How can i reslove the UT failure "Failed to read test report file ..." ? |
saintstack
commented
Oct 6, 2020
@HuiHang-Yu Those kind of failures are often the test crashing out not writing the xml report properly... Its a while since this PR ran. Try a new push to trip the UTs again? |
saintstack
commented
Aug 18, 2021
Closing. Replacing w/ refresh #3596 |
Apache-HBase
commented
Aug 18, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 18, 2021
💔 -1 overall
This message was automatically generated. |
saintstack
commented
Aug 20, 2021
Actually close |
I close the PR #958 for mistaking push too many commits after correcting my code serveral times .