Skip to content

HBASE-24051 Allows indirect inheritance to CanUnbuffer - #1415

Closed
shenshengli wants to merge 6 commits into
apache:masterfrom
shenshengli:shenshengli-HBASE-24051
Closed

HBASE-24051 Allows indirect inheritance to CanUnbuffer#1415
shenshengli wants to merge 6 commits into
apache:masterfrom
shenshengli:shenshengli-HBASE-24051

Conversation

@shenshengli

@shenshenglishenshengli commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer. Modify unit tests.

@Apache-HBase

Apache-HBase commented Apr 2, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 30smaster passed
+1 💚checkstyle1m 7smaster passed
+1 💚spotbugs2m 1smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 4sthe patch passed
-0 ⚠️checkstyle1m 7shbase-server: The patch generated 25 new + 7 unchanged - 0 fixed = 32 total (was 7)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 23sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 9sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
34m 56s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1415
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 53a3196cf08b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ea819b
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 2, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 51sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 11smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 47sthe patch passed
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
+1 💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40sthe patch passed
_ Other Tests _
-1 ❌unit6m 19shbase-server in the patch failed.
35m 28s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1415
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b088c95a691c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ea819b
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/testReport/
Max. process+thread count684 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 2, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 52sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall7m 23smaster passed
+1 💚compile1m 19smaster passed
+1 💚shadedjars6m 25sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 44shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall6m 57sthe patch passed
+1 💚compile1m 17sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚shadedjars8m 3spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 47shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit6m 51shbase-server in the patch failed.
42m 55s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1415
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 47fbf2147aba 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ea819b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/testReport/
Max. process+thread count653 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@shenshenglishenshengli reopened this Apr 2, 2020
@shenshenglishenshengli reopened this Apr 2, 2020
@Apache-HBase

Apache-HBase commented Apr 2, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall6m 7smaster passed
+1 💚checkstyle1m 16smaster passed
+1 💚spotbugs2m 14smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 33sthe patch passed
-0 ⚠️checkstyle1m 14shbase-server: The patch generated 42 new + 7 unchanged - 0 fixed = 49 total (was 7)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 31sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 23sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
39m 1s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1415
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux a9b1159fb329 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ea819b
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count83 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 2, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall10m 11smaster passed
+1 💚compile1m 45smaster passed
+1 💚shadedjars9m 3sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc1m 7shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall9m 30sthe patch passed
+1 💚compile1m 40sthe patch passed
+1 💚javac1m 40sthe patch passed
+1 💚shadedjars5m 48spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit68m 25shbase-server in the patch passed.
112m 21s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1415
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bfffcc15fcc9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ea819b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/testReport/
Max. process+thread count6300 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 2, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall8m 3smaster passed
+1 💚compile1m 22smaster passed
+1 💚shadedjars5m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 46smaster passed
_ Patch Compile Tests _
+1 💚mvninstall7m 7sthe patch passed
+1 💚compile1m 22sthe patch passed
+1 💚javac1m 22sthe patch passed
+1 💚shadedjars6m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 46sthe patch passed
_ Other Tests _
+1 💚unit116m 2shbase-server in the patch passed.
152m 4s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1415
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1a7d4db41201 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ea819b
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/testReport/
Max. process+thread count4141 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk reviewed Apr 9, 2020
View reviewed changes

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why this class uses reflection to access CanUnbuffer. That class has been in Hadoop at least since 2.8, and continues to be available on trunk. However, it's marked as Public/Evolving. Since it's a public class, I think it's fine to import the class directly instead of locating it via reflection.

I have the same question about looking for the presence of the method unbuffer, unless we're protecting against the method disappearing in a future release.

I don't think any of the above is the case; I think this is an artifact of hadoop1 compat. So basically, I think you can get rid of all this reflection and replace all this with something like

importorg.apache.hadoop.fs.CanUnbuffer;
...
this.instanceOfCanUnbuffer = wrappedStreaminstancedCanUnbuffer;

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
+ "left open in CLOSE_WAIT state.", e);
}
return;
if(wrappedStream instanceof CanUnbuffer){

@ndimidukndimidukApr 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace.

if (...) {

@Apache-HBase

Apache-HBase commented Apr 12, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 38smaster passed
+1 💚checkstyle1m 8smaster passed
+1 💚spotbugs2m 3smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 58sthe patch passed
-0 ⚠️checkstyle1m 7shbase-server: The patch generated 42 new + 7 unchanged - 0 fixed = 49 total (was 7)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 23sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 12sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
35m 4s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1415
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux fbf98605ca49 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b6b8c69
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count93 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 13, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 36smaster passed
+1 💚compile0m 55smaster passed
+1 💚shadedjars4m 31sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 15sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚shadedjars4m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit134m 50shbase-server in the patch passed.
160m 28s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1415
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a4e6c0d2437a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b6b8c69
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/testReport/
Max. process+thread count3438 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 13, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 22smaster passed
+1 💚compile1m 9smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall6m 7sthe patch passed
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚shadedjars6m 18spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 53shbase-server in the patch failed.
_ Other Tests _
+1 💚unit136m 23shbase-server in the patch passed.
166m 56s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1415
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7e82543071ec 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b6b8c69
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/testReport/
Max. process+thread count4001 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1415/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack

saintstack commented May 6, 2020

Copy link
Copy Markdown
Contributor

@shenshengli have you seen the @ndimiduk comment above? Any response? Thank you.

@saintstack

saintstack commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

I closed this issue that has gone 28 days w/o response. Please open new PR to make progress again.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukndimiduk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shenshengli@Apache-HBase@saintstack@ndimiduk