Skip to content

HBASE-7003 Moved backup examples into hbase-examples - #145

Closed
HorizonNet wants to merge 1 commit into
apache:masterfrom
ultratendency:HBASE-7003
Closed

HBASE-7003 Moved backup examples into hbase-examples#145
HorizonNet wants to merge 1 commit into
apache:masterfrom
ultratendency:HBASE-7003

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec19Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 25 new or modified test files.
_ master Compile Tests _
0mvndep27Maven dependency ordering for branch
+1mvninstall264master passed
+1compile88master passed
+1checkstyle144master passed
+1shadedjars277branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-checkstyle
+1findbugs225master passed
+1javadoc60master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall252the patch passed
+1compile86the patch passed
+1cc86the patch passed
+1javac86the patch passed
+1checkstyle142root: The patch generated 0 new + 0 unchanged - 68 fixed = 0 total (was 68)
+1whitespace1The patch has no whitespace issues.
+1xml1The patch has no ill-formed XML file.
+1shadedjars275patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck520Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1hbaseprotoc72the patch passed
0findbugs0Skipped patched modules with no Java source: hbase-checkstyle
+1findbugs276the patch passed
+1javadoc61the patch passed
_ Other Tests _
+1unit11hbase-checkstyle in the patch passed.
+1unit7533hbase-server in the patch passed.
+1unit107hbase-examples in the patch passed.
+1asflicense68The patch does not generate ASF License warnings.
10618
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/1/artifact/out/Dockerfile
GITHUB PR#145
Optional Testsdupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile cc hbaseprotoc
unameLinux 8c422b1ce546 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / f30d6c9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/1/testReport/
Max. process+thread count4627 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-server hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey

Copy link
Copy Markdown
Contributor

I thought one of the consensus points for getting the backup/restore stuff into master was that it would be isolated in the one module. Maybe I'm misremembering though?

@HorizonNet

Copy link
Copy Markdown
ContributorAuthor

Wasn't aware of it. Should I remove the changes to the backup/restore stuff from this patch?

@saintstack

Copy link
Copy Markdown
Contributor

Yes, it was important that the backup be totally contained in a module. In fact, now we have alternatives, backup should be moved out of core to something like hbase-operator-tools. Can bring it up on dev lists.

That said, your patch here looks like good cleanup @HorizonNet . You are fixing formatting, line lengths, over-imports. Is that the nature of this patch no? If so, lets get it in.

@HorizonNet

Copy link
Copy Markdown
ContributorAuthor

Core of the patch is to move everything into hbase-examples, but I tried to ensure that we don't get any Checkstyle issues during the move.

@saintstack

Copy link
Copy Markdown
Contributor

Could we have a patch that has your cleanup only? i.e. no move to hbase-examples? There is good stuff in here. Would be shame to throw away? Maybe a new issue? Kill this one?

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec26Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 24 new or modified test files.
_ master Compile Tests _
0mvndep25Maven dependency ordering for branch
+1mvninstall269master passed
+1compile95master passed
+1checkstyle136master passed
+1shadedjars275branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-checkstyle
+1findbugs247master passed
+1javadoc60master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall252the patch passed
+1compile94the patch passed
+1cc94the patch passed
+1javac94the patch passed
+1checkstyle139root: The patch generated 0 new + 0 unchanged - 27 fixed = 0 total (was 27)
+1whitespace0The patch has no whitespace issues.
+1xml2The patch has no ill-formed XML file.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck787Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc73the patch passed
0findbugs0Skipped patched modules with no Java source: hbase-checkstyle
+1findbugs275the patch passed
+1javadoc63the patch passed
_ Other Tests _
+1unit10hbase-checkstyle in the patch passed.
-1unit8511hbase-server in the patch failed.
+1unit107hbase-examples in the patch passed.
+1asflicense88The patch does not generate ASF License warnings.
12164
ReasonTests
Failed junit testshadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/3/artifact/out/Dockerfile
GITHUB PR#145
Optional Testsdupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile cc hbaseprotoc
unameLinux b4d19cb94b77 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / ada772a
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/3/testReport/
Max. process+thread count4717 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-server hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-145/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet

Copy link
Copy Markdown
ContributorAuthor

Closing this one and will open a new ticket. @saintstack Should I also close the corresponding ticket?

@HorizonNet
HorizonNet deleted the HBASE-7003 branch June 16, 2019 20:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@HorizonNet@Apache-HBase@busbey@saintstack