Skip to content

HBASE-22270. master's jmx.clusterRequests could be negative in branch-1 - #164

Merged
apurtell merged 1 commit into
apache:branch-1from
puleya77:branch-1
Apr 24, 2019
Merged

HBASE-22270. master's jmx.clusterRequests could be negative in branch-1#164
apurtell merged 1 commit into
apache:branch-1from
puleya77:branch-1

Conversation

@puleya77

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec47Docker mode activated.
_ Prechecks _
0findbugs0Findbugs executables are not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1mvninstall115branch-1 passed
+1compile40branch-1 passed with JDK v1.8.0_202
+1compile41branch-1 passed with JDK v1.7.0_211
+1checkstyle83branch-1 passed
+1shadedjars170branch has no errors when building our shaded downstream artifacts.
+1javadoc30branch-1 passed with JDK v1.8.0_202
+1javadoc39branch-1 passed with JDK v1.7.0_211
_ Patch Compile Tests _
+1mvninstall105the patch passed
+1compile39the patch passed with JDK v1.8.0_202
+1javac39the patch passed
+1compile42the patch passed with JDK v1.7.0_211
+1javac42the patch passed
+1checkstyle82the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars167patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck100Patch does not cause any errors with Hadoop 2.7.4.
+1javadoc29the patch passed with JDK v1.8.0_202
+1javadoc39the patch passed with JDK v1.7.0_211
_ Other Tests _
-1unit7910hbase-server in the patch failed.
+1asflicense27The patch does not generate ASF License warnings.
9189
ReasonTests
Failed junit testshadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
hadoop.hbase.client.TestAdmin2
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-164/1/artifact/out/Dockerfile
GITHUB PR#164
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 8480882a4179 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-1 / 539de1c
mavenversion: Apache Maven 3.0.5
Default Java1.7.0_211
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_202 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_211
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-164/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-164/1/testReport/
Max. process+thread count3595 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-164/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apurtell
apurtell self-requested a review April 24, 2019 21:17
@apurtell

Copy link
Copy Markdown
Contributor

The test failures are unrelated. Merging.
Thanks for the contribution @puleya77

@apurtell
apurtell merged commit edc30fc into apache:branch-1Apr 24, 2019
asfgit pushed a commit that referenced this pull request Apr 24, 2019
…-1 (#164)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Apr 24, 2019
…-1 (#164)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
This was referenced Aug 15, 2019
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Jun 2, 2025
…ll pointer (apache#6796) (will be in 2.7) (apache#164)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: Ray Mattingly <rmattingly@hubspot.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@puleya77@Apache-HBase@apurtell