Skip to content

HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer… - #1468

Merged
saintstack merged 1 commit into
apache:masterfrom
leosunli:HBASE-24153
Apr 10, 2020
Merged

HBASE-24153. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer…#1468
saintstack merged 1 commit into
apache:masterfrom
leosunli:HBASE-24153

Conversation

@leosunli

@leosunlileosunli commented Apr 9, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

…sionConcurrencyControl()

Signed-off-by: sunlisheng lisheng.sun08@gmail.com

@leosunli
Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer…
7c287aa
…sionConcurrencyControl()
Signed-off-by: sunlisheng <lisheng.sun08@gmail.com>
@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall7m 25smaster passed
+1 💚checkstyle1m 24smaster passed
+1 💚spotbugs2m 33smaster passed
_ Patch Compile Tests _
+1 💚mvninstall6m 16sthe patch passed
+1 💚checkstyle1m 26sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 6sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 36sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
41m 33s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1468
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux d3b0d7b4dee7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1fb693b
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 59smaster passed
+1 💚compile0m 57smaster passed
+1 💚shadedjars4m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 12sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars4m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit117m 15shbase-server in the patch passed.
143m 59s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1468
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4e620cf056fc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1fb693b
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/testReport/
Max. process+thread count4514 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall7m 4smaster passed
+1 💚compile1m 8smaster passed
+1 💚shadedjars5m 43sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 41shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall6m 37sthe patch passed
+1 💚compile1m 8sthe patch passed
+1 💚javac1m 8sthe patch passed
+1 💚shadedjars5m 42spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit173m 0shbase-server in the patch passed.
204m 43s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1468
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 52fd740bff7d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1fb693b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/testReport/
Max. process+thread count3224 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 37smaster passed
+1 💚checkstyle1m 8smaster passed
+1 💚spotbugs2m 0smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 56sthe patch passed
+1 💚checkstyle1m 5sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 21sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 8sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
34m 39s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1468
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux c9911bd76155 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1fb693b
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Apr 9, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall8m 55smaster passed
+1 💚compile1m 23smaster passed
+1 💚shadedjars7m 3sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 53shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall8m 5sthe patch passed
+1 💚compile1m 23sthe patch passed
+1 💚javac1m 23sthe patch passed
+1 💚shadedjars6m 28spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 47shbase-server in the patch failed.
_ Other Tests _
+1 💚unit132m 47shbase-server in the patch passed.
170m 19s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1468
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 398e0425fb15 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1fb693b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/testReport/
Max. process+thread count3964 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 24sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 0smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars4m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 29sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars4m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit174m 23shbase-server in the patch passed.
202m 15s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1468
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 49222b73a694 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1fb693b
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/testReport/
Max. process+thread count2962 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1468/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack

saintstack commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

Do you have a justification for changing this? It is just being explicit about the super call. Is it bad? Thanks.

@leosunli

leosunli commented Apr 10, 2020

Copy link
Copy Markdown
ContributorAuthor

@saintstack
current code is no problem. But
this way of writing seem not to conform to the habit of java code.
Subclass constructor calls the default constructor of the parent class are implicit calls.
Thank you.

@liuml07

liuml07 commented Apr 10, 2020

Copy link
Copy Markdown
Member

@saintstack Yes I agree with @leosunlisuper() will be implicitly added if not any super is called, I think it makes sense just to remove it here.

The parametrized constructor

public MultiVersionConcurrencyControl(long startPoint)

does not have super() and we know it's fine. Adding super() one place but not the other seems a bit inconsistent.

@saintstack
saintstack merged commit 12a0c1d into apache:masterApr 10, 2020
asfgit pushed a commit that referenced this pull request Apr 13, 2020
@saintstack
Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…
c4026d1
…MultiVersionConcurrencyControl() (#1468)"
Forgot to add JIRA number. Reverting to add.
This reverts commit 12a0c1d.
asfgit pushed a commit that referenced this pull request Apr 13, 2020
@saintstack
HBASE-24153Revert "Revert "Remove unnecessary super() in MultiVersio…
72764cf
…nConcurrencyControl#MultiVersionConcurrencyControl() (#1468)""
A revert of a revert; i.e. a reapplication to add missing JIRA number
This reverts commit c4026d1.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstacktangtianhang
Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…
ca5939c
…MultiVersionConcurrencyControl() (apache#1468)"
Forgot to add JIRA number. Reverting to add.
This reverts commit 12a0c1d.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstacktangtianhang
HBASE-24153 Revert "Revert "Remove unnecessary super() in MultiVersio…
ae9be5c
…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)""
A revert of a revert; i.e. a reapplication to add missing JIRA number
This reverts commit c4026d1.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstacktangtianhang
Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…
b8d0800
…MultiVersionConcurrencyControl() (apache#1468)"
Forgot to add JIRA number. Reverting to add.
This reverts commit 12a0c1d.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstacktangtianhang
HBASE-24153 Revert "Revert "Remove unnecessary super() in MultiVersio…
39a1048
…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)""
A revert of a revert; i.e. a reapplication to add missing JIRA number
This reverts commit c4026d1.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@leosunli@thangTang
Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer…
af2a51e
…sionConcurrencyControl() (apache#1468)
Signed-off-by: sunlisheng <lisheng.sun08@gmail.com>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…
4953e1b
…MultiVersionConcurrencyControl() (apache#1468)"
Forgot to add JIRA number. Reverting to add.
This reverts commit 12a0c1d.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
HBASE-24153 Revert "Revert "Remove unnecessary super() in MultiVersio…
e468e7b
…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)""
A revert of a revert; i.e. a reapplication to add missing JIRA number
This reverts commit c4026d1.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@leosunli@thangTang
Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer…
10643d9
…sionConcurrencyControl() (apache#1468)
Signed-off-by: sunlisheng <lisheng.sun08@gmail.com>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…
fd05259
…MultiVersionConcurrencyControl() (apache#1468)"
Forgot to add JIRA number. Reverting to add.
This reverts commit 12a0c1d.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
HBASE-24153 Revert "Revert "Remove unnecessary super() in MultiVersio…
00b8037
…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)""
A revert of a revert; i.e. a reapplication to add missing JIRA number
This reverts commit c4026d1.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@leosunli@thangTang
Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVer…
4a52090
…sionConcurrencyControl() (apache#1468)
Signed-off-by: sunlisheng <lisheng.sun08@gmail.com>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
Revert "Remove unnecessary super() in MultiVersionConcurrencyControl#…
3428b19
…MultiVersionConcurrencyControl() (apache#1468)"
Forgot to add JIRA number. Reverting to add.
This reverts commit 12a0c1d.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
HBASE-24153 Revert "Revert "Remove unnecessary super() in MultiVersio…
dae56da
…nConcurrencyControl#MultiVersionConcurrencyControl() (apache#1468)""
A revert of a revert; i.e. a reapplication to add missing JIRA number
This reverts commit c4026d1.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leosunli@Apache-HBase@saintstack@liuml07@virajjasani