Skip to content

HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml - #1478

Merged
saintstack merged 6 commits into
apache:masterfrom
gentlewangyu:hbase-24137
May 5, 2020
Merged

HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml#1478
saintstack merged 6 commits into
apache:masterfrom
gentlewangyu:hbase-24137

Conversation

@gentlewangyu

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 38sMaven dependency ordering for branch
+1 💚mvninstall7m 0smaster passed
+1 💚checkstyle2m 5smaster passed
+0 🆗refguide7m 19sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall7m 4sthe patch passed
+1 💚checkstyle2m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide7m 2spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck14m 8sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs4m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
67m 12s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 43cff1b5e4ff 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c92dd28
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count83 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

this.masterServices = masterServices;
this.maxMergeCount = this.masterServices.getConfiguration().
getInt(MAX_MERGE_COUNT_KEY, MAX_MERGE_COUNT_DEFAULT);
getInt("hbase.master.metafixer.max.merge.count", 10);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was configurable before this change? You could add

hbase.master.metafixer.max.merge.count 11 configure the max merge count

...
to your hbase-site.xml and away you go?

But maybe you think it deserves mention in the hbase-default.xml so operators can find it easier? If so, I'd suggest a fuller description.

Thanks.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be add hbase.master.metafixer.max.merge.count in hbase-default.xml that so operators can change it easier. I have added fuller description in hbase-default.xml.

Thanks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if the purpose is to mention this config in hbase-default.xml, good to also document it in hbase-default.adoc with detailed description.
However, in that case, title of PR doesn't match. As @saintstack said, this is already configurable.

Thanks.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 35sMaven dependency ordering for branch
+1 💚mvninstall6m 13smaster passed
+1 💚compile1m 27smaster passed
+1 💚shadedjars5m 14sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 20shbase-common in master failed.
-0 ⚠️javadoc0m 38shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 55sthe patch passed
+1 💚compile1m 28sthe patch passed
+1 💚javac1m 28sthe patch passed
+1 💚shadedjars5m 14spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in the patch failed.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 30shbase-common in the patch passed.
+1 💚unit117m 39shbase-server in the patch passed.
150m 22s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2d429a96cf7b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c92dd28
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/testReport/
Max. process+thread count4064 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall5m 23smaster passed
+1 💚compile1m 18smaster passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 2sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚shadedjars4m 30spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55sthe patch passed
_ Other Tests _
+1 💚unit1m 19shbase-common in the patch passed.
+1 💚unit125m 25shbase-server in the patch passed.
154m 37s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 965717f9f20f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c92dd28
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/testReport/
Max. process+thread count3817 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 35sMaven dependency ordering for branch
+1 💚mvninstall6m 39smaster passed
+1 💚checkstyle1m 49smaster passed
+0 🆗refguide6m 55sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 51sthe patch passed
+1 💚checkstyle1m 28sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide4m 44spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck10m 19sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 58sthe patch passed
_ Other Tests _
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
52m 51s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 997b89b29279 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ac4e94e
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall8m 17smaster passed
+1 💚compile1m 47smaster passed
+1 💚shadedjars6m 46sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in master failed.
-0 ⚠️javadoc0m 51shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall8m 21sthe patch passed
+1 💚compile1m 55sthe patch passed
+1 💚javac1m 55sthe patch passed
+1 💚shadedjars7m 11spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in the patch failed.
-0 ⚠️javadoc0m 49shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 43shbase-common in the patch passed.
+1 💚unit125m 4shbase-server in the patch passed.
166m 59s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4cab8b4d17fc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ac4e94e
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/testReport/
Max. process+thread count3603 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall5m 37smaster passed
+1 💚compile1m 16smaster passed
+1 💚shadedjars4m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 27sthe patch passed
+1 💚compile1m 16sthe patch passed
+1 💚javac1m 16sthe patch passed
+1 💚shadedjars4m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 53sthe patch passed
_ Other Tests _
+1 💚unit1m 23shbase-common in the patch passed.
+1 💚unit168m 29shbase-server in the patch passed.
197m 55s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5197f650d5e8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ac4e94e
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/testReport/
Max. process+thread count3287 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

Copy link
Copy Markdown
Member

Thank @gentlewangyu for opening the PR, it makes reviews much easier than the attached patch.

As for the effects of this change, I've left similar comments over on the Jira.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall5m 35smaster passed
+1 💚checkstyle1m 38smaster passed
+0 🆗refguide5m 33sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs2m 49smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall5m 28sthe patch passed
+1 💚checkstyle1m 35sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide5m 26spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 0sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs3m 6sthe patch passed
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
51m 25s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 881f573e0065 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b6b8c69
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count83 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall6m 6smaster passed
+1 💚compile1m 27smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-common in master failed.
-0 ⚠️javadoc0m 40shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 56sthe patch passed
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
+1 💚shadedjars5m 9spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-common in the patch failed.
-0 ⚠️javadoc0m 38shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 27shbase-common in the patch passed.
+1 💚unit120m 25shbase-server in the patch passed.
152m 20s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5324aec8f9fe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b6b8c69
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/testReport/
Max. process+thread count4024 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall5m 52smaster passed
+1 💚compile1m 16smaster passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall5m 30sthe patch passed
+1 💚compile1m 17sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚shadedjars4m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sthe patch passed
_ Other Tests _
+1 💚unit1m 22shbase-common in the patch passed.
+1 💚unit174m 18shbase-server in the patch passed.
204m 52s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux dd9e079b68af 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b6b8c69
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/testReport/
Max. process+thread count3616 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@gentlewangyugentlewangyu changed the title HBASE-24137:The max merge count of metafixer should be configurable in MetaFixerHBASE-24137:The max merge count of metafixer may be remind in hbase-site.xmlApr 15, 2020
@gentlewangyu

Copy link
Copy Markdown
ContributorAuthor

@ndimiduk@saintstack@virajjasani thanks for your suggestion, I see .
I just add the description of hbase.master.metafixer.max.merge.count in hbase-site.xml

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall3m 22smaster passed
+1 💚checkstyle1m 29smaster passed
+0 🆗refguide4m 40sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs2m 50smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 14sthe patch passed
+1 💚checkstyle1m 25sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide4m 56spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck14m 6sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs3m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
50m 15s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 8e801181b1ca 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 38954ed
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 35sMaven dependency ordering for branch
+1 💚mvninstall3m 29smaster passed
+1 💚compile1m 17smaster passed
+1 💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile1m 18sthe patch passed
+1 💚javac1m 18sthe patch passed
+1 💚shadedjars4m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55sthe patch passed
_ Other Tests _
+1 💚unit1m 16shbase-common in the patch passed.
+1 💚unit119m 21shbase-server in the patch passed.
145m 5s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b78ce50ebd5c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 38954ed
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/testReport/
Max. process+thread count4452 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall4m 35smaster passed
+1 💚compile1m 32smaster passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-common in master failed.
-0 ⚠️javadoc0m 42shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 22sthe patch passed
+1 💚compile1m 34sthe patch passed
+1 💚javac1m 34sthe patch passed
+1 💚shadedjars5m 59spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-common in the patch failed.
-0 ⚠️javadoc0m 41shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 39shbase-common in the patch passed.
+1 💚unit197m 10shbase-server in the patch passed.
228m 48s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 84010a40e8f7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 38954ed
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/testReport/
Max. process+thread count2946 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
Contributor

Thanks @gentlewangyu , this looks good. Can you also add this to hbase-default.adoc if not available already?

Comment threadhbase-common/src/main/resources/hbase-default.xml Outdated

@gentlewangyugentlewangyu left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gentlewangyu , this looks good. Can you also add this to hbase-default.adoc if not available already?

I have added this to hbase-default.adoc .

Thanks

this.masterServices = masterServices;
this.maxMergeCount = this.masterServices.getConfiguration().
getInt(MAX_MERGE_COUNT_KEY, MAX_MERGE_COUNT_DEFAULT);
getInt("hbase.master.metafixer.max.merge.count", 10);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be add hbase.master.metafixer.max.merge.count in hbase-default.xml that so operators can change it easier. I have added fuller description in hbase-default.xml.

Thanks

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall3m 43smaster passed
+1 💚checkstyle2m 15smaster passed
+0 🆗refguide5m 22sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs12m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 29sthe patch passed
+1 💚checkstyle2m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide5m 23spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 32sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs12m 41sthe patch passed
_ Other Tests _
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
68m 12s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux bd2684f4d0c5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 853a72b
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count122 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 48smaster passed
+1 💚compile2m 39smaster passed
+1 💚shadedjars5m 25sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-common in master failed.
-0 ⚠️javadoc0m 38shbase-server in master failed.
-0 ⚠️javadoc0m 16sroot in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile2m 38sthe patch passed
+1 💚javac2m 38sthe patch passed
+1 💚shadedjars5m 21spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-common in the patch failed.
-0 ⚠️javadoc0m 38shbase-server in the patch failed.
-0 ⚠️javadoc0m 17sroot in the patch failed.
_ Other Tests _
-1 ❌unit138m 58sroot in the patch failed.
168m 50s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6ab874007c97 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 853a72b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/testReport/
Max. process+thread count6086 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall3m 42smaster passed
+1 💚compile2m 21smaster passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
+1 💚shadedjars5m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 58sthe patch passed
_ Other Tests _
-1 ❌unit203m 49sroot in the patch failed.
236m 9s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b6a628a2b3e9 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 853a72b
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/testReport/
Max. process+thread count5018 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@gentlewangyu

Copy link
Copy Markdown
ContributorAuthor

@ndimiduk
image

this description that I reference the calculateMerges method of MetaFixer

Thanks

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec11m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall3m 53smaster passed
+1 💚checkstyle2m 25smaster passed
+0 🆗refguide5m 27sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs12m 8smaster passed
-0 ⚠️patch2m 28sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 38sthe patch passed
+1 💚checkstyle2m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide5m 28spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck12m 12sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs12m 36sthe patch passed
_ Other Tests _
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
81m 13s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 720fc5d052be 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7e9bd36
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count122 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 12smaster passed
+1 💚compile2m 47smaster passed
+1 💚shadedjars5m 30sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 20shbase-common in master failed.
-0 ⚠️javadoc0m 18sroot in master failed.
-0 ⚠️javadoc0m 42shbase-server in master failed.
-0 ⚠️patch7m 20sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile2m 47sthe patch passed
+1 💚javac2m 47sthe patch passed
+1 💚shadedjars5m 26spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in the patch failed.
-0 ⚠️javadoc0m 45shbase-server in the patch failed.
-0 ⚠️javadoc0m 18sroot in the patch failed.
_ Other Tests _
+1 💚unit170m 17sroot in the patch passed.
201m 50s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9b212810e093 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7e9bd36
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/testReport/
Max. process+thread count7101 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack

Copy link
Copy Markdown
Contributor

Be aware that HBASE-24246 changes the default value from 10.....

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 35sMaven dependency ordering for branch
+1 💚mvninstall3m 36smaster passed
+1 💚compile2m 19smaster passed
+1 💚shadedjars5m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 1smaster passed
-0 ⚠️patch8m 32sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 21sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚shadedjars4m 58spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 2sthe patch passed
_ Other Tests _
-1 ❌unit303m 24sroot in the patch failed.
335m 9s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 138e65cff98d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7e9bd36
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/testReport/
Max. process+thread count5508 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except has wrong default. Thanks.

</property>
<property>
<name>hbase.master.metafixer.max.merge.count</name>
<value>10</value>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default changed.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saintstack I have changed the default value

Thanks

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall3m 35smaster passed
+1 💚checkstyle1m 58smaster passed
+0 🆗refguide4m 41sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs12m 9smaster passed
-0 ⚠️patch2m 24sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
+1 💚checkstyle2m 21sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide5m 53spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck13m 2sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs13m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
71m 48s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsdupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 0264ae9f69fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3340c00
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count137 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile2m 49smaster passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in master failed.
-0 ⚠️javadoc0m 17sroot in master failed.
-0 ⚠️javadoc0m 39shbase-server in master failed.
-0 ⚠️patch6m 53sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 57sthe patch passed
+1 💚compile2m 42sthe patch passed
+1 💚javac2m 42sthe patch passed
+1 💚shadedjars5m 7spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-common in the patch failed.
-0 ⚠️javadoc0m 38shbase-server in the patch failed.
-0 ⚠️javadoc0m 17sroot in the patch failed.
_ Other Tests _
+1 💚unit161m 47sroot in the patch passed.
193m 5s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 68e20cac1036 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3340c00
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/testReport/
Max. process+thread count6959 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall3m 39smaster passed
+1 💚compile2m 17smaster passed
+1 💚shadedjars4m 57sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 11smaster passed
-0 ⚠️patch8m 34sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 30sthe patch passed
+1 💚compile2m 25sthe patch passed
+1 💚javac2m 25sthe patch passed
+1 💚shadedjars4m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 53sthe patch passed
_ Other Tests _
+1 💚unit279m 20sroot in the patch passed.
311m 13s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#1478
JIRA IssueHBASE-24137
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3601b21539c9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3340c00
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/testReport/
Max. process+thread count5897 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 3d96007 into apache:masterMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gentlewangyu@Apache-HBase@ndimiduk@virajjasani@saintstack