Skip to content

HBASE-24168 Align the internal.protobuf.version in hbase-protocol-sha… - #1489

Merged
Apache9 merged 1 commit into
apache:branch-2from
ArthurSXL8:HBASE-24168-branch-2
Apr 13, 2020
Merged

HBASE-24168 Align the internal.protobuf.version in hbase-protocol-sha…#1489
Apache9 merged 1 commit into
apache:branch-2from
ArthurSXL8:HBASE-24168-branch-2

Conversation

@ArthurSXL8

@ArthurSXL8ArthurSXL8 commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

…ded with hbase-thirdparty

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
-1 ❌hadoopcheck3m 10sThe patch causes 41 errors with Hadoop v2.10.0.
-1 ❌hadoopcheck6m 3sThe patch causes 41 errors with Hadoop v3.1.2.
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
8m 57s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1489
Optional Testsdupname asflicense hadoopcheck xml
unameLinux abf0cc269191 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cc4aaef
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-general-check/output/patch-javac-2.10.0.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
Max. process+thread count76 (vs. ulimit of 12500)
modulesC: hbase-examples hbase-protocol-shaded U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 1sbranch-2 passed
+1 💚compile1m 8sbranch-2 passed
+1 💚shadedjars4m 48sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
-1 ❌mvninstall3m 31sroot in the patch failed.
-1 ❌compile0m 22shbase-examples in the patch failed.
-0 ⚠️javac0m 22shbase-examples in the patch failed.
+1 💚shadedjars4m 40spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-examples generated 40 new + 0 unchanged - 0 fixed = 40 total (was 0)
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
-1 ❌unit0m 22shbase-examples in the patch failed.
24m 44s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1489
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a573197ee2e7 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cc4aaef
Default Java1.8.0_232
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-examples.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-examples.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-examples.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-examples.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/testReport/
Max. process+thread count81 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 38sbranch-2 passed
+1 💚compile1m 25sbranch-2 passed
+1 💚shadedjars5m 42sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 24shbase-examples in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
-1 ❌mvninstall4m 13sroot in the patch failed.
-1 ❌compile0m 25shbase-examples in the patch failed.
-0 ⚠️javac0m 25shbase-examples in the patch failed.
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-examples in the patch failed.
_ Other Tests _
+1 💚unit0m 54shbase-protocol-shaded in the patch passed.
-1 ❌unit0m 24shbase-examples in the patch failed.
28m 53s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1489
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ebedaa022ca0 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cc4aaef
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-examples.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-examples.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-examples.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/testReport/
Max. process+thread count81 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ArthurSXL8
ArthurSXL8force-pushed the HBASE-24168-branch-2 branch from 36be9fd to 2eb9f45CompareApril 11, 2020 09:23
@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck10m 53sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
18m 17s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1489
Optional Testsdupname asflicense hadoopcheck xml
unameLinux 6d742266f4f0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cc4aaef
Max. process+thread count76 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded U: hbase-protocol-shaded
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 1sbranch-2 passed
+1 💚compile0m 41sbranch-2 passed
+1 💚shadedjars4m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 13sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 35sthe patch passed
+1 💚compile0m 43sthe patch passed
+1 💚javac0m 43sthe patch passed
+1 💚shadedjars4m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 11sthe patch passed
_ Other Tests _
+1 💚unit0m 43shbase-protocol-shaded in the patch passed.
22m 36s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1489
Optional Testsjavac javadoc unit shadedjars compile
unameLinux caf667c00185 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cc4aaef
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/testReport/
Max. process+thread count65 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded U: hbase-protocol-shaded
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 43sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 41sbranch-2 passed
+1 💚compile0m 57sbranch-2 passed
+1 💚shadedjars5m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 14sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 24sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 54shbase-protocol-shaded in the patch passed.
26m 26s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1489
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7a517bc121c2 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cc4aaef
Default Java2020-01-14
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/testReport/
Max. process+thread count78 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded U: hbase-protocol-shaded
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1489/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 approved these changes Apr 13, 2020
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9
Apache9 merged commit 91361ca into apache:branch-2Apr 13, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArthurSXL8@Apache-HBase@Apache9