Uh oh!
There was an error while loading. Please reload this page.
HBASE-24170 Remove hadoop-2.0 profile - #1495
Merged
Merged
Conversation
Apache-HBase
commented
Apr 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 11, 2020
busbey
commented
Apr 11, 2020
Contributor
Needs the changes to nightly to remove tests on Hadoop 2. Is there another PR already? |
Apache-HBase
commented
Apr 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Apr 12, 2020
ContributorAuthor
Nope. I think at least we need to include the Pre-Commit change in this PR, maybe there are just using the same personality script. Let me take a look. |
Apache-HBase
commented
Apr 12, 2020
(!) A patch to the testing environment has been detected. |
2 similar comments
Apache-HBase
commented
Apr 12, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 12, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 12, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2020
(!) A patch to the testing environment has been detected. |
2 similar comments
Apache-HBase
commented
Apr 12, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 12, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 12, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 13, 2020
(!) A patch to the testing environment has been detected. |
2 similar comments
Apache-HBase
commented
Apr 13, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 13, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 13, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 13, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 13, 2020
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Apr 13, 2020
ContributorAuthor
The pre commit is good now. The failure of the original master branch is expected, as we changed the personality and pre commit job to make the patched version pass, which will break the original master. And for nightly, plan to do it in another issue and we need to create a new branch to test it. Thanks. |
busbey
reviewed
Apr 14, 2020
busbey
left a comment
Contributor
There was a problem hiding this comment.
two nits, could go either way on them.
I'd like to see the changes to nightly land prior to this change getting merged in. Other than that I'm +1.
| fi | ||
| else | ||
| yetus_info "Setting Hadoop 2 versions to test based on master/feature branch rules." | ||
| # we do not support hadoop 2 for hbase 3.x any more |
Contributor
There was a problem hiding this comment.
put this in the info message to make clear we're skipping Hadoop 2 because hbase 3+ won't use it.
| </build> | ||
| </profile> | ||
| <!-- Dependency management profiles for submodules when building against specific hadoop branches.--> | ||
| <!-- Submodules that need hadoop dependencies should declare |
Contributor
There was a problem hiding this comment.
we should keep this guideline for the hadoop-3.0 profile.
saintstack
approved these changes
Apr 14, 2020
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Skimmed. LGTM. Looking forward to master branch nightly doing less work.
Apache-HBase
commented
Apr 15, 2020
(!) A patch to the testing environment has been detected. |
2 similar comments
Apache-HBase
commented
Apr 15, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 15, 2020
(!) A patch to the testing environment has been detected. |
Apache-HBase
commented
Apr 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 15, 2020
🎊 +1 overall
This message was automatically generated. |
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.