Skip to content

HBASE-24148: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. - #1519

Merged
saintstack merged 1 commit into
apache:branch-2from
saintstack:HBASE-24148
Apr 17, 2020
Merged

HBASE-24148: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.#1519
saintstack merged 1 commit into
apache:branch-2from
saintstack:HBASE-24148

Conversation

@saintstack

@saintstacksaintstack commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@saintstacksaintstack mentioned this pull request Apr 15, 2020
Closed
@Apache-HBase

Apache-HBase commented Apr 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 50sbranch-2 passed
+1 💚checkstyle2m 44sbranch-2 passed
+1 💚spotbugs13m 14sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚checkstyle2m 56sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚hadoopcheck14m 1sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs13m 48sthe patch passed
_ Other Tests _
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
68m 51s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1519
JIRA IssueHBASE-24148
Optional Testsdupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle
unameLinux 68bf76375f27 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 62a488b
Max. process+thread count122 (vs. ulimit of 12500)
modulesC: hbase-thrift . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 10sbranch-2 passed
+1 💚compile2m 42sbranch-2 passed
+1 💚shadedjars5m 17sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18sroot in branch-2 failed.
-0 ⚠️javadoc0m 47shbase-thrift in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for patch
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile2m 38sthe patch passed
+1 💚javac2m 38sthe patch passed
+1 💚shadedjars5m 18spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 50shbase-thrift in the patch failed.
-0 ⚠️javadoc0m 18sroot in the patch failed.
_ Other Tests _
+1 💚unit164m 57sroot in the patch passed.
195m 30s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1519
JIRA IssueHBASE-24148
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6dfb0da0b8fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 62a488b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/testReport/
Max. process+thread count5686 (vs. ulimit of 12500)
modulesC: hbase-thrift . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 17sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 4sbranch-2 passed
+1 💚compile2m 30sbranch-2 passed
+1 💚shadedjars5m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 10sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 10sthe patch passed
_ Other Tests _
+1 💚unit234m 24sroot in the patch passed.
268m 13s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1519
JIRA IssueHBASE-24148
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 37650f3fac1e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 62a488b
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/testReport/
Max. process+thread count5174 (vs. ulimit of 12500)
modulesC: hbase-thrift . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk approved these changes Apr 15, 2020
View reviewed changes

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my comment on Jira -- I think patching the known vulnerability is more important than a backward-incompatible break that occurs from this upgrade.

HorizonNet
HorizonNet approved these changes Apr 16, 2020
View reviewed changes

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this one only go into branch-2? Asking because the linked PR was targeted at master.

virajjasani
virajjasani approved these changes Apr 16, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@saintstack
saintstack merged commit 34961d4 into apache:branch-2Apr 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukndimiduk approved these changes
@HorizonNetHorizonNetHorizonNet approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saintstack@Apache-HBase@ndimiduk@HorizonNet@virajjasani@tamaashu