Uh oh!
There was an error while loading. Please reload this page.
HBASE-24148: Upgrade Thrift to 0.13.0 - #1462
Closed
tamaashu wants to merge 1 commit into
Closed
Conversation
Upgrade thrift, adopt Java code where needed. Change-Id: I8d78f6bd04ed3c7787b8f9beaf370dfdac9574cb
Apache-HBase
commented
Apr 8, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 9, 2020
💔 -1 overall
This message was automatically generated. |
| conf.setInt("mapreduce.map.maxattempts", 3); | ||
| TestExportSnapshot.testExportFileSystemState(conf, tableName, | ||
| Bytes.toBytes(snapshotName), Bytes.toBytes(snapshotName), | ||
| TestExportSnapshot.testExportFileSystemState(conf, tableName, snapshotName, snapshotName, |
Contributor
There was a problem hiding this comment.
Please resolve conflicts, this one is taken care of.
Thanks
| <protobuf.plugin.version>0.6.1</protobuf.plugin.version> | ||
| <thrift.path>thrift</thrift.path> | ||
| <thrift.version>0.12.0</thrift.version> | ||
| <thrift.version>0.13.0</thrift.version> |
Contributor
There was a problem hiding this comment.
What are the guarantees regards thrift 0.13 talking to a 0.12 server and vice-versa? Needs callout in the release notes on this JIRA at least.
Otherwise patch is good.
Contributor
There was a problem hiding this comment.
Oh, do you have to regenerate the thrift files with this update? Will that happen as part of the build? (I forgot how this works)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade thrift, adopt Java code where needed.
Change-Id: I8d78f6bd04ed3c7787b8f9beaf370dfdac9574cb