Skip to content

[HBASE-24177] MetricsTable#updateFlushTime is wrong - #1539

Merged
ramkrish86 merged 1 commit into
apache:masterfrom
gkanade:hbase-24177
Apr 17, 2020
Merged

[HBASE-24177] MetricsTable#updateFlushTime is wrong#1539
ramkrish86 merged 1 commit into
apache:masterfrom
gkanade:hbase-24177

Conversation

@gkanade

@gkanadegkanade commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Corrected this

binlijin
binlijin approved these changes Apr 17, 2020
View reviewed changes

@binlijinbinlijin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ramkrish86
ramkrish86 merged commit 12aad76 into apache:masterApr 17, 2020
@ramkrish86

ramkrish86 commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Thanks for the patch @gkanade and thanks for the review @binlijin .

@Apache-HBase

Apache-HBase commented Apr 17, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 12smaster passed
+1 💚checkstyle1m 16smaster passed
+1 💚spotbugs2m 20smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 46sthe patch passed
+1 💚checkstyle1m 14sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 4sPatch does not cause any errors with Hadoop 3.1.2.
+1 💚spotbugs2m 53sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
31m 14s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1539
JIRA IssueHBASE-24177
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux b4f383cefafe 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b7a6d36
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 17, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 17smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars5m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
-1 ❌unit8m 25shbase-server in the patch failed.
33m 16s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#1539
JIRA IssueHBASE-24177
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c89e511dc777 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b7a6d36
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/testReport/
Max. process+thread count753 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ramkrish86

ramkrish86 commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Seems like some QA bot issue.

@Apache-HBase

Apache-HBase commented Apr 17, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 22smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 6sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit119m 21shbase-server in the patch passed.
143m 41s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1539
JIRA IssueHBASE-24177
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d19b25919893 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b7a6d36
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/testReport/
Max. process+thread count4580 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ramkrish86

ramkrish86 commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Javadoc failure is not related to this patch.

ramkrish86 pushed a commit that referenced this pull request Apr 17, 2020
@gkanadeRamkrishna Vasudevan
MetricsTable#updateFlushTime is wrong (#1539)
aa5b28a
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
ramkrish86 pushed a commit that referenced this pull request Apr 17, 2020
@gkanadeRamkrishna Vasudevan
MetricsTable#updateFlushTime is wrong (#1539)
e67d751
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
ramkrish86 pushed a commit that referenced this pull request Apr 17, 2020
@gkanadeRamkrishna Vasudevan
MetricsTable#updateFlushTime is wrong (#1539)
361e81e
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@gkanade@ddupg
MetricsTable#updateFlushTime is wrong (apache#1539)
70835d0
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@gkanademeiyi
MetricsTable#updateFlushTime is wrong (apache#1539)
d6079d3
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@gkanade@tamaashu
MetricsTable#updateFlushTime is wrong (apache#1539)
cc497c5
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
(cherry picked from commit e67d751)
Change-Id: Ia7c08610442e98d6efb6c7aefcfbf1eaf4691f4f
Apache9 added a commit that referenced this pull request Sep 30, 2024
@Apache9
Revert "MetricsTable#updateFlushTime is wrong (#1539)"
e5e4b5c
Missed jira id
This reverts commit 12aad76.
Apache9 pushed a commit that referenced this pull request Sep 30, 2024
@gkanade@Apache9
HBASE-24177MetricsTable#updateFlushTime is wrong (#1539)
74b032a
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
Apache9 added a commit that referenced this pull request Sep 30, 2024
@Apache9
Revert "MetricsTable#updateFlushTime is wrong (#1539)"
bf5d1cc
Missed jira id
This reverts commit 12aad76.
Apache9 pushed a commit that referenced this pull request Sep 30, 2024
@gkanade@Apache9
HBASE-24177MetricsTable#updateFlushTime is wrong (#1539)
8efd67b
Authored-by: Gaurav Kanade <gkanade@microsoft.com>
Signed-off-by: Ramkrishna <ramkrishna@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binlijinbinlijinbinlijin approved these changes
@ramkrish86ramkrish86ramkrish86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gkanade@ramkrish86@Apache-HBase@binlijin