Skip to content

HBASE-22258 Removed deprecated methods in VisibilityClient - #159

Merged
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22258
Apr 23, 2019
Merged

HBASE-22258 Removed deprecated methods in VisibilityClient#159
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22258

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec25Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall255master passed
+1compile27master passed
+1checkstyle34master passed
+1shadedjars262branch has no errors when building our shaded downstream artifacts.
+1findbugs60master passed
+1javadoc20master passed
_ Patch Compile Tests _
+1mvninstall242the patch passed
+1compile25the patch passed
+1javac25the patch passed
+1checkstyle30hbase-client: The patch generated 0 new + 19 unchanged - 19 fixed = 19 total (was 38)
+1whitespace0The patch has no whitespace issues.
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck505Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs67the patch passed
+1javadoc21the patch passed
_ Other Tests _
+1unit201hbase-client in the patch passed.
+1asflicense14The patch does not generate ASF License warnings.
2127
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/1/artifact/out/Dockerfile
GITHUB PR#159
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d85b45af76e0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 12bcb87
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/1/testReport/
Max. process+thread count289 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec28Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall255master passed
+1compile29master passed
+1checkstyle32master passed
+1shadedjars276branch has no errors when building our shaded downstream artifacts.
+1findbugs62master passed
+1javadoc21master passed
_ Patch Compile Tests _
+1mvninstall249the patch passed
+1compile25the patch passed
+1javac25the patch passed
+1checkstyle31hbase-client: The patch generated 0 new + 19 unchanged - 19 fixed = 19 total (was 38)
+1whitespace0The patch has no whitespace issues.
+1shadedjars263patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck518Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs75the patch passed
+1javadoc20the patch passed
_ Other Tests _
+1unit205hbase-client in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
2166
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/2/artifact/out/Dockerfile
GITHUB PR#159
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a22287dd0ab5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / f30d6c9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/2/testReport/
Max. process+thread count294 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending confirm that these methods have been deprecated since 2.0.0. Thanks.

@HorizonNet

Copy link
Copy Markdown
ContributorAuthor

@saintstack Re-checked it again. The methods were deprecated in HBASE-13620, which has 2.0.0 set as the fix version.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. Perhaps note in RN the issue that deprecated them.

@HorizonNet
HorizonNet merged commit 3dfa98f into apache:masterApr 23, 2019
@HorizonNet
HorizonNet deleted the HBASE-22258 branch April 23, 2019 14:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet@Apache-HBase@saintstack