Uh oh!
There was an error while loading. Please reload this page.
HBASE-22322 Use special pause for CallQueueTooBigException - #195
Merged
Conversation
Apache-HBase
commented
Apr 28, 2019
🎊 +1 overall
This message was automatically generated. |
carp84
commented
Apr 29, 2019
Member
Agreed. Actually the original config name proposed in HBASE-17114 is Will be back and review the PR soon. |
carp84
reviewed
Apr 29, 2019
| * times) are both limitations for retrying, we will stop retrying when we reach any of the | ||
| * limitations. | ||
| * @param timeout | ||
| * @param unit |
Member
There was a problem hiding this comment.
Maybe better to add some javadoc to parameters here instead of removing? I mean after all we are changing this part, let's improve it.
ContributorAuthor
There was a problem hiding this comment.
We do not have javadoc for these parameters in both AsyncTableBuilder and TableBuilder, and I think the parameter name is good enough to tell users the meaning?
Member
There was a problem hiding this comment.
It will generate checkstyle error by default although not a big deal.
carp84
reviewed
Apr 29, 2019
| /** | ||
| * Set timeout for each rpc request. | ||
| * @param timeout | ||
| * @param unit |
carp84
reviewed
Apr 29, 2019
| * Set the base pause time for retrying. We use an exponential policy to generate sleep time when | ||
| * retrying. | ||
| * @param timeout | ||
| * @param unit |
carp84
reviewed
Apr 29, 2019
| * Set the max retry times for an admin operation. Usually it is the max attempt times minus 1. | ||
| * Operation timeout and max attempt times(or max retry times) are both limitations for retrying, | ||
| * we will stop retrying when we reach any of the limitations. | ||
| * @param maxRetries |
carp84
reviewed
Apr 29, 2019
| * Set the max attempt times for an admin operation. Usually it is the max retry times plus 1. | ||
| * Operation timeout and max attempt times(or max retry times) are both limitations for retrying, | ||
| * we will stop retrying when we reach any of the limitations. | ||
| * @param maxAttempts |
carp84
reviewed
Apr 29, 2019
| /** | ||
| * Set the number of retries that are allowed before we start to log. | ||
| * @param startLogErrorsCnt |
carp84
approved these changes
Apr 29, 2019
carp84
left a comment
Member
There was a problem hiding this comment.
Overall LGTM, just some minor comments that don't block the commit. And please make it compatible for old configuration if plan to change the config name.
Apache-HBase
commented
Apr 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Apr 29, 2019
ContributorAuthor
OK, can do this in another issue... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still have some problems on implementing UTs, will update the patch soon. And maybe we could change the config name? I think a more general reason to use a larger pause is that the region server is overloaded, CallQueueTooBigException is only one possible result of a overloaded region server. So maybe we could change the config and also the new methods in TableBuilder and AdminBuilder to something like pauseWhenOverloaded? What do you think @carp84 . Thanks.