Skip to content

Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2 - #2034

Merged
Apache9 merged 4 commits into
apache:branch-2from
comnetwork:branch-2
Jul 11, 2020
Merged

Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2#2034
Apache9 merged 4 commits into
apache:branch-2from
comnetwork:branch-2

Conversation

@comnetwork

@comnetworkcomnetwork commented Jul 7, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is different from #1970 as follows, which makes the AsyncFSWAL.doShutdown consistent with the master:

  1. In AsyncFSWAL.doShutdown method, after we invoke closeWriter(), we set the writer to null
  2. At the end of TestWALEntryStream.testReplicationSourceWALReaderRecovered :
    - // Actually this should be true but we haven't handled this yet since for a normal queue the
    - // last one is always open... Not a big deal for now.
    - assertFalse(batch.isEndOfFile());
    + assertTrue(batch.isEndOfFile());

@comnetworkcomnetwork changed the title HBASE-24625Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2Jul 7, 2020
@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 11sbranch-2 passed
+1 💚checkstyle1m 33sbranch-2 passed
+1 💚spotbugs2m 51sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 43sthe patch passed
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-asyncfs
+1 💚checkstyle1m 17shbase-server: The patch generated 0 new + 46 unchanged - 3 fixed = 46 total (was 49)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 16sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 36sthe patch passed
_ Other Tests _
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
42m 25s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2034
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 04425fa0101c 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28602d6
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimidukndimiduk mentioned this pull request Jul 7, 2020
Closed
@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 57sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 38sbranch-2 passed
+1 💚compile1m 31sbranch-2 passed
+1 💚shadedjars6m 28sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-asyncfs in branch-2 failed.
-0 ⚠️javadoc0m 40shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚compile1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚shadedjars6m 21spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 15shbase-asyncfs in the patch failed.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 35shbase-asyncfs in the patch passed.
+1 💚unit199m 25shbase-server in the patch passed.
237m 36s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2e5887aeab55 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28602d6
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/testReport/
Max. process+thread count2556 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 32sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 11sbranch-2 passed
+1 💚compile1m 23sbranch-2 passed
+1 💚shadedjars5m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 53sthe patch passed
_ Other Tests _
+1 💚unit2m 30shbase-asyncfs in the patch passed.
+1 💚unit207m 14shbase-server in the patch passed.
237m 35s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5e3721addd3b 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28602d6
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/testReport/
Max. process+thread count2595 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 56sbranch-2 passed
+1 💚checkstyle1m 29sbranch-2 passed
+1 💚spotbugs2m 45sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 47sthe patch passed
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-asyncfs
+1 💚checkstyle1m 17shbase-server: The patch generated 0 new + 46 unchanged - 3 fixed = 46 total (was 49)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 9sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
41m 53s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2034
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux d8f57672c778 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28602d6
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 51sbranch-2 passed
+1 💚compile1m 23sbranch-2 passed
+1 💚shadedjars5m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 47sthe patch passed
+1 💚compile1m 18sthe patch passed
+1 💚javac1m 18sthe patch passed
+1 💚shadedjars5m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51sthe patch passed
_ Other Tests _
+1 💚unit2m 11shbase-asyncfs in the patch passed.
+1 💚unit198m 54shbase-server in the patch passed.
228m 30s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7aed00308e0b 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28602d6
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/testReport/
Max. process+thread count2517 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 1sbranch-2 passed
+1 💚compile1m 46sbranch-2 passed
+1 💚shadedjars6m 49sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-asyncfs in branch-2 failed.
-0 ⚠️javadoc0m 43shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 9sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars6m 53spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-asyncfs in the patch failed.
-0 ⚠️javadoc0m 43shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 50shbase-asyncfs in the patch passed.
-1 ❌unit212m 9shbase-server in the patch failed.
247m 43s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 27b7f069139e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28602d6
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/testReport/
Max. process+thread count2476 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall5m 0sbranch-2 passed
+1 💚checkstyle1m 49sbranch-2 passed
+1 💚spotbugs3m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚checkstyle0m 12sThe patch passed checkstyle in hbase-asyncfs
+1 💚checkstyle1m 28shbase-server: The patch generated 0 new + 46 unchanged - 3 fixed = 46 total (was 49)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 32sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 35sthe patch passed
_ Other Tests _
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
46m 27s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2034
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux cf849b18f96e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f771fd2
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 28sbranch-2 passed
+1 💚compile1m 30sbranch-2 passed
+1 💚shadedjars6m 4sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-asyncfs in branch-2 failed.
-0 ⚠️javadoc0m 39shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
+1 💚shadedjars6m 26spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 20shbase-asyncfs in the patch failed.
-0 ⚠️javadoc0m 52shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 38shbase-asyncfs in the patch passed.
+1 💚unit138m 16shbase-server in the patch passed.
169m 41s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7f6881eca6bd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / f771fd2
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/testReport/
Max. process+thread count3701 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 50sbranch-2 passed
+1 💚checkstyle1m 27sbranch-2 passed
+1 💚spotbugs2m 36sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 29sthe patch passed
+1 💚checkstyle0m 11sThe patch passed checkstyle in hbase-asyncfs
+1 💚checkstyle1m 13shbase-server: The patch generated 0 new + 46 unchanged - 3 fixed = 46 total (was 49)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 23sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 55sthe patch passed
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
37m 18s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2034
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 7c9485586489 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5fcffae
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 9, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 21sbranch-2 passed
+1 💚compile1m 30sbranch-2 passed
+1 💚shadedjars6m 21sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-asyncfs in branch-2 failed.
-0 ⚠️javadoc0m 40shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 21sthe patch passed
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
+1 💚shadedjars6m 23spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-asyncfs in the patch failed.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 36shbase-asyncfs in the patch passed.
-1 ❌unit203m 34shbase-server in the patch failed.
235m 36s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1e9bf38fc014 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5fcffae
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/testReport/
Max. process+thread count2568 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk requested changes Jul 9, 2020
View reviewed changes

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes requested.

I've also kicked the precommit job to run this patch again.

Comment threadhbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
@Apache-HBase

Apache-HBase commented Jul 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 3sbranch-2 passed
+1 💚checkstyle1m 31sbranch-2 passed
+1 💚spotbugs2m 48sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 39sthe patch passed
+1 💚checkstyle0m 11sThe patch passed checkstyle in hbase-asyncfs
+1 💚checkstyle1m 19shbase-server: The patch generated 0 new + 46 unchanged - 3 fixed = 46 total (was 49)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 34sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
40m 3s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2034
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux e94dfaee54a8 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5fcffae
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 54sbranch-2 passed
+1 💚compile1m 25sbranch-2 passed
+1 💚shadedjars5m 53sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-asyncfs in branch-2 failed.
-0 ⚠️javadoc0m 39shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 57sthe patch passed
+1 💚compile1m 24sthe patch passed
+1 💚javac1m 24sthe patch passed
+1 💚shadedjars5m 43spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-asyncfs in the patch failed.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 25shbase-asyncfs in the patch passed.
+1 💚unit125m 4shbase-server in the patch passed.
154m 12s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 041afd63837a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5fcffae
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/testReport/
Max. process+thread count4180 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 1sbranch-2 passed
+1 💚compile1m 23sbranch-2 passed
+1 💚shadedjars5m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 49sthe patch passed
_ Other Tests _
+1 💚unit1m 47shbase-asyncfs in the patch passed.
+1 💚unit190m 23shbase-server in the patch passed.
218m 20s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2034
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d3f9cbd59254 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5fcffae
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/testReport/
Max. process+thread count3186 (vs. ulimit of 12500)
modulesC: hbase-asyncfs hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@comnetwork
comnetwork requested a review from ndimidukJuly 10, 2020 04:53
@Apache9
Apache9 merged commit deff4c8 into apache:branch-2Jul 11, 2020
asfgit pushed a commit that referenced this pull request Jul 11, 2020
@comnetwork@Apache9
HBASE-24625AsyncFSWAL.getLogFileSizeIfBeingWritten does not return t…
4b11ad4
…he expected synced file length.(#2034)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
asfgit pushed a commit that referenced this pull request Jul 11, 2020
@comnetwork@Apache9
HBASE-24625AsyncFSWAL.getLogFileSizeIfBeingWritten does not return t…
c6a6112
…he expected synced file length.(#2034)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@comnetworkcomnetwork mentioned this pull request Jul 13, 2020
Merged
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@comnetwork@clarax
HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return t…
bbb9752
…he expected synced file length.(apache#2034)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@comnetwork@busbey
HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return t…
43576f4
…he expected synced file length.(apache#2034)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 4b11ad4)
Change-Id: Ia4dcb81db9202e06d0869b6189879b392beab530
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukndimiduk approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@comnetwork@Apache-HBase@ndimiduk@Apache9