Uh oh!
There was an error while loading. Please reload this page.
HBASE-24704 Make the Table Schema easier to view even there are multi… - #2042
HBASE-24704 Make the Table Schema easier to view even there are multi…#2042bsglz wants to merge 1 commit into
Conversation
Apache-HBase
commented
Jul 9, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 9, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 9, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 9, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 9, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 9, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 13, 2020
🎊 +1 overall
This message was automatically generated. |
bsglz
commented
Jul 17, 2020
PTAL. Thanks. @wchevreuil@virajjasani |
bsglz
commented
Jul 20, 2020
@wchevreuil@virajjasani What do you think of this proposal? |
virajjasani
left a comment
There was a problem hiding this comment.
Left a couple of comments. The patch looks good, once you address the comments, you can also raise a PR for branch-2.
| <table class="table table-striped"> | ||
| <% | ||
| Collection<HColumnDescriptor> families = new HTableDescriptor(table.getDescriptor()).getFamilies(); |
There was a problem hiding this comment.
Please use ModifyableTableDescriptor as HTableDescriptor is deprecated.
There was a problem hiding this comment.
Fixed, remove the unnecessary new HTableDescriptor and use ColumnFamilyDescriptor instead of HColumnDescriptor.
Thanks.
| <table class="table table-striped"> | ||
| <% | ||
| Collection<HColumnDescriptor> families = new HTableDescriptor(table.getDescriptor()).getFamilies(); | ||
| Set<Bytes> familyKeySet = new HashSet(); |
bsglz
commented
Aug 1, 2020
rebase |
Apache-HBase
commented
Aug 1, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 1, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 1, 2020
🎊 +1 overall
This message was automatically generated. |
@bsglz with updated usage of ColumnFamilyDescriptors properties, UI might looks slight differently. Can you please upload screenshots with updated PR results of UI on Jira? For both master and branch-2. |
bsglz
commented
Aug 1, 2020
No prob, will update later. |
bsglz
commented
Aug 1, 2020
@virajjasani Updated the screenshots. |
virajjasani
commented
Aug 1, 2020
Thank you @bsglz |
bsglz
commented
Aug 1, 2020
No prob, will do it tomorrow. |
…ple families