Skip to content

HBASE-22340 Corrupt KeyValue is silently ignored - #207

Merged
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-22340
May 2, 2019
Merged

HBASE-22340 Corrupt KeyValue is silently ignored#207
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-22340

Conversation

@petersomogyi

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec21Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep26Maven dependency ordering for branch
+1mvninstall252master passed
+1compile73master passed
+1checkstyle93master passed
+1shadedjars259branch has no errors when building our shaded downstream artifacts.
+1findbugs257master passed
+1javadoc53master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall243the patch passed
+1compile74the patch passed
+1javac74the patch passed
-1checkstyle24hbase-common: The patch generated 2 new + 27 unchanged - 0 fixed = 29 total (was 27)
+1whitespace1The patch has no whitespace issues.
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck494Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs235the patch passed
+1javadoc52the patch passed
_ Other Tests _
+1unit169hbase-common in the patch passed.
+1unit8315hbase-server in the patch passed.
+1asflicense49The patch does not generate ASF License warnings.
11133
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/artifact/out/Dockerfile
GITHUB PR#207
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3d2bb020076a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 3f40df8
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/artifact/out/diff-checkstyle-hbase-common.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/testReport/
Max. process+thread count4531 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec22Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall246master passed
+1compile72master passed
+1checkstyle91master passed
+1shadedjars260branch has no errors when building our shaded downstream artifacts.
+1findbugs251master passed
+1javadoc51master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall232the patch passed
+1compile72the patch passed
+1javac72the patch passed
+1checkstyle92the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck498Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs275the patch passed
+1javadoc53the patch passed
_ Other Tests _
+1unit165hbase-common in the patch passed.
+1unit8163hbase-server in the patch passed.
+1asflicense57The patch does not generate ASF License warnings.
10985
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/2/artifact/out/Dockerfile
GITHUB PR#207
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a662ab787faa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e44fe49
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/2/testReport/
Max. process+thread count5178 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petersomogyi
petersomogyi merged commit 94122f6 into apache:masterMay 2, 2019
@petersomogyi
petersomogyi deleted the HBASE-22340 branch September 23, 2019 07:17
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
(cherry picked from commit f60a64c)
Change-Id: I6b32dc2eb91f4419b40efe79be923c2fa25b88b1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@petersomogyi@Apache-HBase@apurtell