Skip to content

HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er… - #2074

Merged
pankaj72981 merged 1 commit into
apache:branch-2from
arshadmohammad:HBASE-24719-branch-2
Sep 4, 2020
Merged

HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…#2074
pankaj72981 merged 1 commit into
apache:branch-2from
arshadmohammad:HBASE-24719-branch-2

Conversation

@arshadmohammad

@arshadmohammadarshadmohammad commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

…ror message

@Apache-HBase

Apache-HBase commented Jul 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 46sbranch-2 passed
+1 💚compile0m 23sbranch-2 passed
+1 💚shadedjars4m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚shadedjars5m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit3m 7shbase-rsgroup in the patch passed.
23m 49s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d2baaaf50ea8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ad826a4
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count3580 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 34sbranch-2 passed
+1 💚compile0m 29sbranch-2 passed
+1 💚shadedjars6m 5sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 25shbase-rsgroup in branch-2 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile0m 28sthe patch passed
+1 💚javac0m 28sthe patch passed
+1 💚shadedjars6m 39spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 23shbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚unit3m 1shbase-rsgroup in the patch passed.
28m 5s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 341361684e60 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ad826a4
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count3862 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 3sbranch-2 passed
+1 💚checkstyle0m 13sbranch-2 passed
+1 💚spotbugs0m 42sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 35sthe patch passed
+1 💚checkstyle0m 12sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 45sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs0m 50sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
31m 42s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 842528546d1e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ad826a4
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@arshadmohammad

arshadmohammad commented Jul 20, 2020

Copy link
Copy Markdown
ContributorAuthor

@pankaj72981 can you please review it

pankaj72981
pankaj72981 approved these changes Jul 20, 2020
View reviewed changes

@pankaj72981pankaj72981 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@Apache-HBase

Apache-HBase commented Aug 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 58sbranch-2 passed
+1 💚compile0m 23sbranch-2 passed
+1 💚shadedjars5m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚shadedjars5m 27spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 20sthe patch passed
_ Other Tests _
+1 💚unit4m 41shbase-rsgroup in the patch passed.
26m 39s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 058ae7021c8e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cee7431
Default Java1.8.0_232
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/testReport/
Max. process+thread count2443 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall5m 35sbranch-2 passed
+1 💚checkstyle0m 16sbranch-2 passed
+1 💚spotbugs0m 55sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 35sthe patch passed
+1 💚checkstyle0m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 21sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs0m 58sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
40m 48s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 63f59b2b453e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cee7431
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 56sbranch-2 passed
+1 💚compile0m 23sbranch-2 passed
+1 💚shadedjars6m 25sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 34sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚shadedjars6m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 20sthe patch passed
_ Other Tests _
+1 💚unit4m 11shbase-rsgroup in the patch passed.
28m 5s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fc7809abfa39 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ad17705
Default Java1.8.0_232
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count2300 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 59sbranch-2 passed
+1 💚checkstyle0m 13sbranch-2 passed
+1 💚spotbugs0m 43sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 31sthe patch passed
+1 💚checkstyle0m 11sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 26sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs0m 50sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
29m 53s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux ab2bab78e8e9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ad17705
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 57sbranch-2 passed
+1 💚compile0m 31sbranch-2 passed
+1 💚shadedjars7m 24sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 28shbase-rsgroup in branch-2 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 18sthe patch passed
+1 💚compile0m 31sthe patch passed
+1 💚javac0m 31sthe patch passed
+1 💚shadedjars7m 9spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 25shbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚unit3m 11shbase-rsgroup in the patch passed.
30m 36s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2074
JIRA IssueHBASE-24719
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0fd78abfa35f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ad17705
Default Java2020-01-14
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count3167 (vs. ulimit of 12500)
modulesC: hbase-rsgroup U: hbase-rsgroup
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@arshadmohammad

arshadmohammad commented Aug 31, 2020

Copy link
Copy Markdown
ContributorAuthor

This is pending for commit from long time. Can someone please commit it.

@pankaj72981pankaj72981 reopened this Sep 4, 2020
@pankaj72981
pankaj72981 merged commit aac21ae into apache:branch-2Sep 4, 2020
asfgit pushed a commit that referenced this pull request Sep 4, 2020
@arshadmohammad@pankaj72981
HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…
8218087
…ror message (#2074)
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit aac21ae)
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@arshadmohammad@clarax
HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…
2cc9853
…ror message (apache#2074)
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankaj72981pankaj72981pankaj72981 approved these changes
@ReiddddddReiddddddAwaiting requested review from Reidddddd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arshadmohammad@Apache-HBase@pankaj72981