HBASE-22174 Remove error prone from our precommit javac check

[Apache9]

The output of the error prone check is not stable, sometimes we miss several warnings, and sometimes the order of the warnings are changed. Remove it for now. Can add back later after we fix all these problems. Or another solution is to add it back as a separated check in pre commit and add it to the filter list, so it will only generate a -0 instead of -1.

[busbey]

could we make this a CLI flag and turn it on during nightly runs? nightly doesn't do a before/after so the stability shouldn't matter. (it's also already set to be -0 instead of -1)

I just think if the profile doesn't get activated in any of our automatic builds the chances of someone deciding to look at it is basically 0.

[Apache9]

Nightly will also use the hbase-personality script? Do not know that before...

Then the fix will be a bit different. Let me check.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	268	Docker mode activated.
		_ Prechecks _
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	shellcheck	1	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	12	The patch does not generate ASF License warnings.
		339

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-113/1/artifact/out/Dockerfile
GITHUB PR	#113
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux c3ff79a7db0e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / 6abf408
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
shellcheck	v0.4.4
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-113/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[busbey]

yeah, nightly runs up to 3 of 4 potential different yetus invocations and all of them use the personality.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	shellcheck	2	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	15	The patch does not generate ASF License warnings.
		117

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-113/2/artifact/out/Dockerfile
GITHUB PR	#113
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux f5ffb0d62a43 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / 6abf408
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
shellcheck	v0.4.4
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-113/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[Apache9]

Oh a bit strange, the merge operation will generate a merge commit...

[busbey]

There's a different option when accepting a PR that avoids the merge commit. I guess we didn't make it the default for the repo after all?

[busbey]

Looks like we'll need to ask infra to change it; I don't see repo settings.

[Apache9]

Yes, the default action is create a merge commit... I just clicked the button and then clicked confirm merge...

[petersomogyi]

If I remember correctly on hbase-connectors after I submitted a PR with "Squash and merge" the next time that became the default action for me.