Skip to content

HBASE-24743 Reject to add a peer which replicate to itself earlier - #2124

Merged
infraio merged 1 commit into
apache:branch-2from
infraio:HBASE-24743-branch-2
Jul 24, 2020
Merged

HBASE-24743 Reject to add a peer which replicate to itself earlier#2124
infraio merged 1 commit into
apache:branch-2from
infraio:HBASE-24743-branch-2

Conversation

@infraio

@infraioinfraio commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@infraio

infraio commented Jul 23, 2020

Copy link
Copy Markdown
ContributorAuthor

PR for branch-2.

@Apache-HBase

Apache-HBase commented Jul 23, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 50sbranch-2 passed
+1 💚checkstyle1m 27sbranch-2 passed
+1 💚spotbugs2m 8sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 35sthe patch passed
+1 💚checkstyle1m 24sthe patch passed
-0 ⚠️rubocop0m 6sThe patch generated 60 new + 295 unchanged - 16 fixed = 355 total (was 311)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 36sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 14sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
38m 43s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2124
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
unameLinux df794d950834 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ce4e692
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 31sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 40sbranch-2 passed
+1 💚compile1m 35sbranch-2 passed
+1 💚shadedjars6m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 4sthe patch passed
+1 💚compile1m 32sthe patch passed
+1 💚javac1m 32sthe patch passed
+1 💚shadedjars6m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit223m 33shbase-server in the patch passed.
-1 ❌unit7m 8shbase-shell in the patch failed.
261m 21s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2124
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 00d68a21d13d 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ce4e692
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/testReport/
Max. process+thread count2534 (vs. ulimit of 12500)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@infraio
infraioforce-pushed the HBASE-24743-branch-2 branch from 484ad36 to 7165ea7CompareJuly 23, 2020 09:18
@Apache-HBase

Apache-HBase commented Jul 23, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 15sbranch-2 passed
+1 💚checkstyle1m 27sbranch-2 passed
+1 💚spotbugs2m 6sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 32sthe patch passed
+1 💚checkstyle1m 27sthe patch passed
-0 ⚠️rubocop0m 7sThe patch generated 62 new + 294 unchanged - 17 fixed = 356 total (was 311)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 36sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 13sthe patch passed
_ Other Tests _
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
37m 40s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2124
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
unameLinux 3c2c145f9b15 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ce4e692
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 30sbranch-2 passed
+1 💚compile1m 18sbranch-2 passed
+1 💚shadedjars5m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 49sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 20sthe patch passed
+1 💚compile1m 18sthe patch passed
+1 💚javac1m 18sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 47sthe patch passed
_ Other Tests _
+1 💚unit151m 24shbase-server in the patch passed.
+1 💚unit7m 28shbase-shell in the patch passed.
183m 54s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2124
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cf99393fcc77 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ce4e692
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/testReport/
Max. process+thread count3431 (vs. ulimit of 12500)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 18sbranch-2 passed
+1 💚compile1m 32sbranch-2 passed
+1 💚shadedjars5m 54sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall4m 21sthe patch passed
+1 💚compile1m 52sthe patch passed
+1 💚javac1m 52sthe patch passed
+1 💚shadedjars8m 10spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 50shbase-server in the patch failed.
_ Other Tests _
+1 💚unit141m 20shbase-server in the patch passed.
+1 💚unit7m 8shbase-shell in the patch passed.
180m 22s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2124
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 61ffb573f6e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ce4e692
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/testReport/
Max. process+thread count4167 (vs. ulimit of 12500)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@infraio

infraio commented Jul 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Ok. All ut passed.

@infraio
infraio merged commit 70ab0dc into apache:branch-2Jul 24, 2020
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@infraio@clarax
HBASE-24743 Reject to add a peer which replicate to itself earlier (a…
8a04c0e
…pache#2124)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
Wellington Chevreuil@wchevreuil
CDPD-34408 Revert two 2.4 commits that caused regression on the repli…
be1508c
…cation plugin:
1) Revert "HBASE-24743 Reject to add a peer which replicate to itself earlier (apache#2124)"
This reverts commit 70ab0dc.
2)Revert "HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers. (apache#2284)"
This reverts commit 7df1b92.
Change-Id: I8d5e66a9073caf61e744a19425c350c49f4b7072
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
@wchevreuilAmina Dinari
CDPD-71667: Add CDPD-34408 and COD-1499 on top of the feature branch (a…
28e99a3
…pache#209)
* CDPD-71667: Revert "HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers. (apache#2284)"
This reverts commit 7df1b92.
Change-Id: I2b4570a3ab1bca6c573c669a54ef67008438bd95
* CDPD-71667: Revert "HBASE-24743 Reject to add a peer which replicate to itself earlier (apache#2124)"
This reverts commit 70ab0dc.
Change-Id: I6d508ff3aacf2d48e00f903afe7bca21d34f3247
---------
Co-authored-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@wchevreuil