Skip to content

HBASE-21714 Deprecated isTableAvailableWithSplit method in thrift module - #217

Merged
Apache9 merged 1 commit into
apache:masterfrom
nyl3532016:HBASE-21714
May 7, 2019
Merged

HBASE-21714 Deprecated isTableAvailableWithSplit method in thrift module#217
Apache9 merged 1 commit into
apache:masterfrom
nyl3532016:HBASE-21714

Conversation

@nyl3532016

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec300Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall324master passed
+1compile41master passed
+1checkstyle39master passed
+1shadedjars337branch has no errors when building our shaded downstream artifacts.
+1findbugs98master passed
+1javadoc36master passed
_ Patch Compile Tests _
+1mvninstall310the patch passed
+1compile39the patch passed
+1javac39the patch passed
-1checkstyle37hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars344patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck656Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs118the patch passed
+1javadoc37the patch passed
_ Other Tests _
+1unit291hbase-thrift in the patch passed.
+1asflicense13The patch does not generate ASF License warnings.
3101
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 75de4cef6954 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/testReport/
Max. process+thread count1775 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

*
* @return true if table is available, false if not
*
* @deprecated since version 2.1.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2.3.0 or 2.2.0? And please add comment to say when will we remove it, I would like to remove it in 3.0.0, to align with the Table interface. So here we need to tell user that we will remove it in 3.0.0 for aligning with the Table interface, as in general, it should be removed in 4.0.0.

@Apache9

Copy link
Copy Markdown
Contributor

@nyl3532016 You can reuse the old PR actually. not a big problem anyway.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec249Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall267master passed
+1compile34master passed
+1checkstyle30master passed
+1shadedjars249branch has no errors when building our shaded downstream artifacts.
+1findbugs78master passed
+1javadoc28master passed
_ Patch Compile Tests _
+1mvninstall244the patch passed
+1compile33the patch passed
+1javac33the patch passed
-1checkstyle29hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars256patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck463Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs89the patch passed
+1javadoc28the patch passed
_ Other Tests _
+1unit278hbase-thrift in the patch passed.
+1asflicense9The patch does not generate ASF License warnings.
2438
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5973013fe39c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/testReport/
Max. process+thread count1783 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec47Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall237master passed
+1compile29master passed
+1checkstyle28master passed
+1shadedjars249branch has no errors when building our shaded downstream artifacts.
+1findbugs77master passed
+1javadoc28master passed
_ Patch Compile Tests _
+1mvninstall245the patch passed
+1compile30the patch passed
+1javac30the patch passed
-1checkstyle29hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars245patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck495Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs87the patch passed
+1javadoc31the patch passed
_ Other Tests _
+1unit283hbase-thrift in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
2379
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4d3da1020c7b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/testReport/
Max. process+thread count1778 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall242master passed
+1compile33master passed
+1checkstyle33master passed
+1shadedjars273branch has no errors when building our shaded downstream artifacts.
+1findbugs76master passed
+1javadoc29master passed
_ Patch Compile Tests _
+1mvninstall234the patch passed
+1compile31the patch passed
+1javac31the patch passed
-1checkstyle29hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars248patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck520Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs87the patch passed
+1javadoc29the patch passed
_ Other Tests _
+1unit265hbase-thrift in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
2253
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 8739f86a9063 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/testReport/
Max. process+thread count1809 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall260master passed
+1compile31master passed
+1checkstyle34master passed
+1shadedjars272branch has no errors when building our shaded downstream artifacts.
+1findbugs80master passed
+1javadoc30master passed
_ Patch Compile Tests _
+1mvninstall252the patch passed
+1compile31the patch passed
+1javac31the patch passed
-1checkstyle32hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars272patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck523Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs88the patch passed
+1javadoc30the patch passed
_ Other Tests _
+1unit260hbase-thrift in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2324
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux bb0bd2583c78 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/testReport/
Max. process+thread count1925 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@nyl3532016

Copy link
Copy Markdown
ContributorAuthor

this checkstyle -1 is a problem?

@HorizonNet

Copy link
Copy Markdown
Contributor

@nyl3532016 Yes, would be good to get this fixed before committing it. It should be an easy one.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall247master passed
+1compile32master passed
+1checkstyle31master passed
+1shadedjars255branch has no errors when building our shaded downstream artifacts.
+1findbugs78master passed
+1javadoc29master passed
_ Patch Compile Tests _
+1mvninstall237the patch passed
+1compile32the patch passed
+1javac32the patch passed
-1checkstyle32hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars262patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck516Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs86the patch passed
+1javadoc28the patch passed
_ Other Tests _
+1unit268hbase-thrift in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2256
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3ec125d05510 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/testReport/
Max. process+thread count1791 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall260master passed
+1compile30master passed
+1checkstyle32master passed
+1shadedjars272branch has no errors when building our shaded downstream artifacts.
+1findbugs78master passed
+1javadoc30master passed
_ Patch Compile Tests _
+1mvninstall234the patch passed
+1compile31the patch passed
+1javac31the patch passed
+1checkstyle30the patch passed
+1whitespace1The patch has no whitespace issues.
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck476Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs88the patch passed
+1javadoc30the patch passed
_ Other Tests _
+1unit310hbase-thrift in the patch passed.
+1asflicense9The patch does not generate ASF License warnings.
2290
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/7/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 1d019037a1df 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/7/testReport/
Max. process+thread count1784 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/7/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

*
* @return true if table is available, false if not
*
* @deprecated Since 2.0.0. Will be removed in 3.0.0.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 2.2.0? I mean you need to say that the same method in Table interface has been deprecated since 2.0.0, so we will remove it in 3.0.0 release.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ,I have amended

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall239master passed
+1compile32master passed
+1checkstyle31master passed
+1shadedjars252branch has no errors when building our shaded downstream artifacts.
+1findbugs78master passed
+1javadoc29master passed
_ Patch Compile Tests _
+1mvninstall239the patch passed
+1compile32the patch passed
+1javac32the patch passed
+1checkstyle30the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars262patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck510Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs87the patch passed
+1javadoc29the patch passed
_ Other Tests _
+1unit287hbase-thrift in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
2261
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/8/artifact/out/Dockerfile
GITHUB PR#217
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f3901508eb13 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / e884a25
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/8/testReport/
Max. process+thread count1795 (vs. ulimit of 10000)
modulesC: hbase-thrift U: hbase-thrift
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/8/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 6de308c into apache:masterMay 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nyl3532016@Apache-HBase@Apache9@HorizonNet