Uh oh!
There was an error while loading. Please reload this page.
HBASE-21714 Deprecated isTableAvailableWithSplit method in thrift module - #217
Conversation
Apache-HBase
commented
May 5, 2019
💔 -1 overall
This message was automatically generated. |
| * | ||
| * @return true if table is available, false if not | ||
| * | ||
| * @deprecated since version 2.1.4 |
There was a problem hiding this comment.
Should be 2.3.0 or 2.2.0? And please add comment to say when will we remove it, I would like to remove it in 3.0.0, to align with the Table interface. So here we need to tell user that we will remove it in 3.0.0 for aligning with the Table interface, as in general, it should be removed in 4.0.0.
Apache9
commented
May 5, 2019
@nyl3532016 You can reuse the old PR actually. not a big problem anyway. |
Apache-HBase
commented
May 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 5, 2019
💔 -1 overall
This message was automatically generated. |
nyl3532016
commented
May 5, 2019
this checkstyle -1 is a problem? |
HorizonNet
commented
May 5, 2019
@nyl3532016 Yes, would be good to get this fixed before committing it. It should be an easy one. |
Apache-HBase
commented
May 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 6, 2019
🎊 +1 overall
This message was automatically generated. |
| * | ||
| * @return true if table is available, false if not | ||
| * | ||
| * @deprecated Since 2.0.0. Will be removed in 3.0.0. |
There was a problem hiding this comment.
It should be 2.2.0? I mean you need to say that the same method in Table interface has been deprecated since 2.0.0, so we will remove it in 3.0.0 release.
Apache-HBase
commented
May 6, 2019
🎊 +1 overall
This message was automatically generated. |
No description provided.