Skip to content

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat - #2209

Merged
infraio merged 3 commits into
apache:masterfrom
utf7:HBASE-24831
Sep 2, 2020
Merged

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat#2209
infraio merged 3 commits into
apache:masterfrom
utf7:HBASE-24831

Conversation

@utf7

@utf7utf7 commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Avoid invoke Counter using reflection in SnapshotInputFormat

@Apache-HBase

Apache-HBase commented Aug 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 6smaster passed
+1 💚checkstyle0m 19smaster passed
+1 💚spotbugs0m 44smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 39sthe patch passed
+1 💚checkstyle0m 18sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 12sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs0m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
31m 26s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2209
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 8c3e3ef1a060 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b49bd6
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 7, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 44smaster passed
+1 💚compile0m 25smaster passed
+1 💚shadedjars5m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile0m 25sthe patch passed
+1 💚javac0m 25sthe patch passed
+1 💚shadedjars5m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 18sthe patch passed
_ Other Tests _
-1 ❌unit10m 39shbase-mapreduce in the patch failed.
32m 12s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2209
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4ee066159630 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b49bd6
Default Java1.8.0_232
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/testReport/
Max. process+thread count3821 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 7, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 41smaster passed
+1 💚compile0m 28smaster passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 23shbase-mapreduce in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 9sthe patch passed
+1 💚compile0m 32sthe patch passed
+1 💚javac0m 32sthe patch passed
+1 💚shadedjars6m 15spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 22shbase-mapreduce in the patch failed.
_ Other Tests _
-1 ❌unit10m 26shbase-mapreduce in the patch failed.
34m 48s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2209
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 092640b82ec7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b49bd6
Default Java2020-01-14
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/testReport/
Max. process+thread count3591 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@utf7

utf7 commented Aug 7, 2020

Copy link
Copy Markdown
ContributorAuthor

with the pr we get about 7.6%/9.1% performance improve

in my test case with ScanPerformanceEvaluation tools

like that

hbase org.apache.hadoop.hbase.ScanPerformanceEvaluation -t snapshotscanmapreduce -rs /tmp/hbase/rs1 -sn sp_test

with pr

1#

total time to scan: 143943 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 109.1 MB/s
total rows : 10485760
throughput : 71.6 K rows/s
total cells : 104857600
throughput : 716.1 K cells/s

2#

total time to scan: 145948 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 107.6 MB/s
total rows : 10485760
throughput : 70.6 K rows/s
total cells : 104857600
throughput : 706.2 K cells/s

total time to scan: 149962 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 104.7 MB/s
total rows : 10485760
throughput : 68.7 K rows/s
total cells : 104857600
throughput : 687.2 K cells/s

without pr

1th:
total time to scan: 156929 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 100 MB/s
total rows : 10485760
throughput : 65.6 K rows/s
total cells : 104857600
throughput : 656.4 K cells/s

2th
total time to scan: 156078 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 100 MB/s
total rows : 10485760
throughput : 65.6 K rows/s
total cells : 104857600
throughput : 656.4 K cells/s

@utf7

utf7 commented Aug 7, 2020

Copy link
Copy Markdown
ContributorAuthor

The test error seems not related

@utf7

utf7 commented Aug 7, 2020

Copy link
Copy Markdown
ContributorAuthor

@anoopsjohn@pankaj72981@tedyu@Apache9@infraio mind have a looks,thanks

@Apache9

Apache9 commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Mind explaing a bit why we do not need the reflection any more? Because we have dropped the support for some hadoop versions?

@utf7

utf7 commented Aug 7, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Mind explaing a bit why we do not need the reflection any more? Because we have dropped the support for some hadoop versions?

Thanks for reply

I checkout the hadoop code with branch-2.7/branch-2.8/branch-2.9/branch-3/branch-3.0/branch-3.1/branch-3.2/branch-3.3

getCounter method just has two:

getCounter(Enum<?> counterName) or getCounter(String groupName, String counterName)

the code always pass two String params to invoke getCounter(String,String) ,

so I think we can just use getCounter(String,String)

besides that:

hadoop 2 version has been removed from hbase 3.0

in jdk11 case: We need a minimum HDFS version of 3.2.0 for HADOOP-12760

So, I think we can use getCounter(String,String) safely.

If i was wrong ,please correct me ,thanks

@utf7

utf7 commented Aug 11, 2020

Copy link
Copy Markdown
ContributorAuthor

format the log to trigger cicd

@Apache-HBase

Apache-HBase commented Aug 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 47smaster passed
+1 💚checkstyle0m 20smaster passed
+1 💚spotbugs0m 45smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 20sthe patch passed
+1 💚checkstyle0m 18sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 14sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs0m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
28m 11s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2209
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux fe4185d4563d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6fd7dce
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 17smaster passed
+1 💚compile0m 28smaster passed
+1 💚shadedjars5m 49sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 24shbase-mapreduce in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 21shbase-mapreduce in the patch failed.
_ Other Tests _
-1 ❌unit10m 22shbase-mapreduce in the patch failed.
32m 47s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2209
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ad8683cc7117 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6fd7dce
Default Java2020-01-14
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/testReport/
Max. process+thread count3845 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 28smaster passed
+1 💚compile0m 29smaster passed
+1 💚shadedjars6m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 23sthe patch passed
+1 💚compile0m 28sthe patch passed
+1 💚javac0m 28sthe patch passed
+1 💚shadedjars6m 52spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 19sthe patch passed
_ Other Tests _
-1 ❌unit11m 52shbase-mapreduce in the patch failed.
37m 44s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2209
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ad527cf36100 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6fd7dce
Default Java1.8.0_232
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/testReport/
Max. process+thread count4060 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@utf7

utf7 commented Aug 25, 2020

Copy link
Copy Markdown
ContributorAuthor

fix NullPointerException when using TestTableSnapshotInputFormat,something the counter is null

before that, origin code using try-catch and debug log , here we using if (counter != null) { counter.increment(numScannerRestarts); } instead

@utf7

utf7 commented Aug 25, 2020

Copy link
Copy Markdown
ContributorAuthor

mind have a look @anoopsjohn thanks

@Apache-HBase

Apache-HBase commented Aug 25, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 45smaster passed
+1 💚checkstyle0m 20smaster passed
+1 💚spotbugs0m 45smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 21sthe patch passed
-0 ⚠️checkstyle0m 18shbase-mapreduce: The patch generated 18 new + 9 unchanged - 0 fixed = 27 total (was 9)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 15sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs0m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
28m 28s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2209
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux af249efc8399 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebe321a
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 25, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 48sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 17smaster passed
+1 💚compile0m 30smaster passed
+1 💚shadedjars7m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile0m 28sthe patch passed
+1 💚javac0m 28sthe patch passed
+1 💚shadedjars7m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 18sthe patch passed
_ Other Tests _
+1 💚unit11m 10shbase-mapreduce in the patch passed.
38m 33s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2209
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 24a2f2787542 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebe321a
Default Java1.8.0_232
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/testReport/
Max. process+thread count4869 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 25, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 49smaster passed
+1 💚compile0m 29smaster passed
+1 💚shadedjars7m 23sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 23shbase-mapreduce in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 33sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars7m 16spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-mapreduce in the patch failed.
_ Other Tests _
+1 💚unit13m 26shbase-mapreduce in the patch passed.
41m 14s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2209
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e29418836b34 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebe321a
Default Java2020-01-14
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/testReport/
Max. process+thread count2907 (vs. ulimit of 12500)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@utf7

utf7 commented Aug 28, 2020

Copy link
Copy Markdown
ContributorAuthor

done

@infraio
infraio merged commit 04de594 into apache:masterSep 2, 2020
infraio pushed a commit that referenced this pull request Sep 2, 2020
@utf7Guanghao Zhang
HBASE-24831Avoid invoke Counter using reflection in SnapshotInputFor…
e042cab
…mat (#2209)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
infraio pushed a commit that referenced this pull request Sep 2, 2020
@utf7Guanghao Zhang
HBASE-24831Avoid invoke Counter using reflection in SnapshotInputFor…
b7c99fb
…mat (#2209)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@utf7@clarax
HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFor…
1d7cf81
…mat (apache#2209)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@utf7@Apache-HBase@Apache9@infraio