Uh oh!
There was an error while loading. Please reload this page.
HBASE-24830 Some tests involving RS crash fail with NullPointerExcept… - #2211
Closed
saintstack wants to merge 1 commit into
Closed
HBASE-24830 Some tests involving RS crash fail with NullPointerExcept…#2211saintstack wants to merge 1 commit into
saintstack wants to merge 1 commit into
Conversation
Apache-HBase
commented
Aug 7, 2020
🎊 +1 overall
This message was automatically generated. |
| // encountered a bad non-retry-able persistent error. | ||
| try { | ||
| SplitLogWorkerCoordination splitLogWorkerCoordination = | ||
| server.getCoordinatedStateManager().getSplitLogWorkerCoordination(); |
Contributor
There was a problem hiding this comment.
Can splitLogWorkerCoordination be null and the reason? Thanks.
ContributorAuthor
There was a problem hiding this comment.
splitlogworkercoordination is only present when we are doing the old zk based log splitting. Otherwise, it is null.
Contributor
There was a problem hiding this comment.
+1 on this fix, I hit this issue and figure out if we set HBASE_SPLIT_WAL_COORDINATED_BY_ZK in TestClusterRestartFailoverSplitWithoutZk, the test fails.
Apache-HBase
commented
Aug 7, 2020
💔 -1 overall
This message was automatically generated. |
…ion after HBASE-24632 in branch-2
Apache-HBase
commented
Aug 8, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2020
💔 -1 overall
This message was automatically generated. |
saintstack
commented
Aug 8, 2020
ContributorAuthor
One (unrelated) test failed. It passes locally. Rerunning just in case. |
Apache-HBase
commented
Aug 8, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2020
🎊 +1 overall
This message was automatically generated. |
taklwu
approved these changes
Aug 8, 2020
taklwu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, testWALEntryFilter and TestClusterRestartFailoverSplitWithoutZk passed after this change.
| // encountered a bad non-retry-able persistent error. | ||
| try { | ||
| SplitLogWorkerCoordination splitLogWorkerCoordination = | ||
| server.getCoordinatedStateManager().getSplitLogWorkerCoordination(); |
Contributor
There was a problem hiding this comment.
+1 on this fix, I hit this issue and figure out if we set HBASE_SPLIT_WAL_COORDINATED_BY_ZK in TestClusterRestartFailoverSplitWithoutZk, the test fails.
Apache-HBase
commented
Aug 9, 2020
💔 -1 overall
This message was automatically generated. |
saintstack
commented
Aug 9, 2020
ContributorAuthor
Merged manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion after HBASE-24632 in branch-2