HBASE-22373 Defined missing version for maven-eclipse-plugin by HorizonNet · Pull Request #222 · apache/hbase

HorizonNet · 2019-05-06T19:33:06Z

No description provided.

busbey · 2019-05-06T20:07:54Z

if you move those two maven-eclipse-plugin uses into the eclipse profile does everything work? that would be preferable, since we shouldn't need that plugin when we're building outside of eclipse.

HorizonNet · 2019-05-06T20:54:53Z

Updated the PR to move the plugin to the eclipse-specific profile. Not an Eclipse myself, so not able to test if everything works. Without Eclipse everything builds fine.

Apache-HBase · 2019-05-07T00:48:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	17	Maven dependency ordering for branch
+1	mvninstall	330	master passed
+1	compile	93	master passed
+1	shadedjars	371	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	55	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	347	the patch passed
+1	compile	95	the patch passed
+1	javac	95	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedjars	374	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	685	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	javadoc	60	the patch passed
		_ Other Tests _
+1	unit	53	hbase-zookeeper in the patch passed.
-1	unit	16133	hbase-server in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		18841

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/1/artifact/out/Dockerfile
GITHUB PR	#222
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux 7816264ba617 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `67c937f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/1/testReport/
Max. process+thread count	4662 (vs. ulimit of 10000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-05-07T02:09:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	31	Maven dependency ordering for branch
+1	mvninstall	265	master passed
+1	compile	67	master passed
+1	shadedjars	256	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	46	master passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	231	the patch passed
+1	compile	70	the patch passed
+1	javac	70	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	5	The patch has no ill-formed XML file.
+1	shadedjars	268	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	511	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	javadoc	44	the patch passed
		_ Other Tests _
+1	unit	46	hbase-zookeeper in the patch passed.
-1	unit	16871	hbase-server in the patch failed.
+1	asflicense	60	The patch does not generate ASF License warnings.
		18905

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.client.TestSnapshotTemporaryDirectory

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/2/artifact/out/Dockerfile
GITHUB PR	#222
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux b4eed1a275b8 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `67c937f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/2/testReport/
Max. process+thread count	5116 (vs. ulimit of 10000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-05-14T19:57:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	25	Maven dependency ordering for branch
+1	mvninstall	317	master passed
+1	compile	81	master passed
+1	shadedjars	299	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	50	master passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	258	the patch passed
+1	compile	77	the patch passed
+1	javac	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	10	The patch has no ill-formed XML file.
+1	shadedjars	309	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	869	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.0.
+1	javadoc	49	the patch passed
		_ Other Tests _
+1	unit	64	hbase-zookeeper in the patch passed.
-1	unit	8945	hbase-server in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		11543

Reason	Tests
Failed junit tests	hadoop.hbase.master.replication.TestRegisterPeerWorkerWhenRestarting

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/3/artifact/out/Dockerfile
GITHUB PR	#222
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux ac064e59f7a9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `fde0251`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/3/testReport/
Max. process+thread count	5157 (vs. ulimit of 10000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-05-14T20:47:22Z

Mh, I think that the failing test is unrelated.

saintstack · 2019-06-07T05:32:35Z

Re-running check.

Apache-HBase · 2019-06-07T11:27:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	209	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	32	Maven dependency ordering for branch
+1	mvninstall	324	master passed
+1	compile	89	master passed
+1	shadedjars	352	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	58	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	315	the patch passed
+1	compile	89	the patch passed
+1	javac	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedjars	351	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1009	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	59	the patch passed
		_ Other Tests _
+1	unit	54	hbase-zookeeper in the patch passed.
-1	unit	17887	hbase-server in the patch failed.
+1	asflicense	56	The patch does not generate ASF License warnings.
		21302

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestFromClientSideWithCoprocessor

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/4/artifact/out/Dockerfile
GITHUB PR	#222
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux a44f9f4ab8b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `2e9087b`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/4/testReport/
Max. process+thread count	4830 (vs. ulimit of 10000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-222/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-06-09T22:00:01Z

Test failures seem to be unrelated to the actual changes. Should we bring it in?

saintstack · 2019-06-09T22:15:42Z

Should we bring it in? @HorizonNet

+1 from me for bringing it in.

HorizonNet added the enhancement label May 6, 2019

HBASE-22373Moved maven-eclipse-plugin to eclipse profile
95c8e55

busbey approved these changes May 14, 2019
View reviewed changes

HorizonNet merged commit 99ea828 into apache:masterJun 9, 2019

HorizonNet deleted the HBASE-22373 branch June 9, 2019 22:51

Navigation Menu

Uh oh!

HBASE-22373 Defined missing version for maven-eclipse-plugin - #222

HBASE-22373 Defined missing version for maven-eclipse-plugin#222
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22373

HorizonNet commented May 6, 2019

Uh oh!

busbey commented May 6, 2019

Uh oh!

HorizonNet commented May 6, 2019

Uh oh!

Apache-HBase commented May 7, 2019

Uh oh!

Apache-HBase commented May 7, 2019

Uh oh!

Apache-HBase commented May 14, 2019

Uh oh!

HorizonNet commented May 14, 2019

Uh oh!

saintstack commented Jun 7, 2019

Uh oh!

Apache-HBase commented Jun 7, 2019

Uh oh!

HorizonNet commented Jun 9, 2019

Uh oh!

saintstack commented Jun 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

HorizonNet commented May 6, 2019

Uh oh!

busbey commented May 6, 2019

Uh oh!

HorizonNet commented May 6, 2019

Uh oh!

Apache-HBase commented May 7, 2019

Uh oh!

Apache-HBase commented May 7, 2019

Uh oh!

Apache-HBase commented May 14, 2019

Uh oh!

HorizonNet commented May 14, 2019

Uh oh!

saintstack commented Jun 7, 2019

Uh oh!

Apache-HBase commented Jun 7, 2019

Uh oh!

HorizonNet commented Jun 9, 2019

Uh oh!

saintstack commented Jun 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants