Skip to content

HBASE-22368 Use LocalDate instead of Date for MobUtil class - #223

Closed
ArthurSXL8 wants to merge 3 commits into
apache:masterfrom
ArthurSXL8:HBASE-22368
Closed

HBASE-22368 Use LocalDate instead of Date for MobUtil class#223
ArthurSXL8 wants to merge 3 commits into
apache:masterfrom
ArthurSXL8:HBASE-22368

Conversation

@ArthurSXL8

@ArthurSXL8ArthurSXL8 commented May 7, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented May 7, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec20Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall259master passed
+1compile54master passed
+1checkstyle75master passed
+1shadedjars268branch has no errors when building our shaded downstream artifacts.
+1findbugs197master passed
+1javadoc35master passed
_ Patch Compile Tests _
+1mvninstall249the patch passed
+1compile56the patch passed
+1javac56the patch passed
-1checkstyle73hbase-server: The patch generated 93 new + 46 unchanged - 20 fixed = 139 total (was 66)
+1whitespace0The patch has no whitespace issues.
+1shadedjars270patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck513Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs228the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit8128hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
10563
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestMobStoreCompaction
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/artifact/out/Dockerfile
GITHUB PR#223
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 416cd96bafe1 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 67c937f
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/testReport/
Max. process+thread count5049 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 requested changes May 14, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
}

private static LocalDate toLocalDate(long millisecond) {
return Instant.ofEpochMilli(millisecond).atZone(ZoneId.systemDefault()).toLocalDate();

@Apache9Apache9May 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we retain the same behavior with the old code? By default Date will use the system default time zone?

@ArthurSXL8ArthurSXL8May 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Date class just use the JVM timezone

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
@Apache-HBase

Apache-HBase commented May 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec21Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall250master passed
+1compile54master passed
+1checkstyle69master passed
+1shadedjars260branch has no errors when building our shaded downstream artifacts.
+1findbugs195master passed
+1javadoc29master passed
_ Patch Compile Tests _
+1mvninstall227the patch passed
+1compile50the patch passed
+1javac50the patch passed
-1checkstyle66hbase-server: The patch generated 87 new + 41 unchanged - 25 fixed = 128 total (was 66)
-1whitespace0The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck953Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs136the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit1616hbase-server in the patch failed.
+1asflicense14The patch does not generate ASF License warnings.
4313
ReasonTests
Failed junit testshadoop.hbase.coprocessor.TestRegionCoprocessorHost
TEST-null
hadoop.hbase.coprocessor.TestCoprocessorInterface
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/Dockerfile
GITHUB PR#223
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d54f204ee408 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / c80f2ad
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/diff-checkstyle-hbase-server.txt
whitespacehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/whitespace-eol.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/testReport/
Max. process+thread count652 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase
Apache-HBase reviewed May 20, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java Outdated
@@ -1,5 +1,5 @@
/**
*
*

@Apache-HBaseApache-HBaseMay 20, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

@Apache-HBase

Apache-HBase commented May 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec26Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall224master passed
+1compile55master passed
+1checkstyle66master passed
+1shadedjars253branch has no errors when building our shaded downstream artifacts.
+1findbugs204master passed
+1javadoc29master passed
_ Patch Compile Tests _
+1mvninstall231the patch passed
+1compile50the patch passed
+1javac50the patch passed
-1checkstyle65hbase-server: The patch generated 87 new + 41 unchanged - 25 fixed = 128 total (was 66)
-1whitespace0The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1shadedjars250patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck947Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs215the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit8432hbase-server in the patch failed.
+1asflicense31The patch does not generate ASF License warnings.
11150
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestMobStoreCompaction
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/Dockerfile
GITHUB PR#223
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 695f37518881 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / c80f2ad
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/diff-checkstyle-hbase-server.txt
whitespacehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/whitespace-eol.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/testReport/
Max. process+thread count4709 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase
Apache-HBase reviewed May 20, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java Outdated
@@ -1,5 +1,5 @@
/**
*
*

@Apache-HBaseApache-HBaseMay 20, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

@Apache-HBase

Apache-HBase commented May 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec22Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall307master passed
+1compile63master passed
+1checkstyle82master passed
+1shadedjars290branch has no errors when building our shaded downstream artifacts.
+1findbugs216master passed
+1javadoc33master passed
_ Patch Compile Tests _
+1mvninstall253the patch passed
+1compile56the patch passed
+1javac56the patch passed
-1checkstyle77hbase-server: The patch generated 87 new + 41 unchanged - 25 fixed = 128 total (was 66)
-1whitespace0The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1shadedjars282patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1052Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs227the patch passed
+1javadoc34the patch passed
_ Other Tests _
-1unit8580hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
13525
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestMobStoreCompaction
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/Dockerfile
GITHUB PR#223
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 27cac622a15d 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / c80f2ad
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/diff-checkstyle-hbase-server.txt
whitespacehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/whitespace-eol.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/testReport/
Max. process+thread count4897 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 11, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch5#223 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#223
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/8/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack

saintstack commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

Any chance of addressing the conflicts? Thanks.

@Apache9

Apache9 commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

Close since the PR is stale and can not be merged. Feel free to reopen.

@Apache9Apache9 closed this Jul 24, 2019
@ArthurSXL8

ArthurSXL8 commented Jul 24, 2019

Copy link
Copy Markdown
ContributorAuthor

Sorry, I am a little busy during last days, will continue. So reopen it.

@Apache9

Apache9 commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

You can reopen when you have time to prepare a new patch.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 requested changes
+1 more reviewer
@Apache-HBaseApache-HBaseApache-HBase left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArthurSXL8@Apache-HBase@saintstack@Apache9