Skip to content

HBASE-20851 Change rubocop config for max line length of 100 - #224

Merged
HorizonNet merged 1 commit into
apache:masterfrom
murtazahassan123:master
May 7, 2019
Merged

HBASE-20851 Change rubocop config for max line length of 100#224
HorizonNet merged 1 commit into
apache:masterfrom
murtazahassan123:master

Conversation

@murtazahassan123

Copy link
Copy Markdown
Contributor

Changed configuration and analyzed code with rubocop on some files and it works.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec282Docker mode activated.
_ Prechecks _
0yamllint0yamllint was not available.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall314master passed
+1javadoc15master passed
_ Patch Compile Tests _
+1mvninstall301the patch passed
+1whitespace0The patch has no whitespace issues.
+1javadoc14the patch passed
_ Other Tests _
+1unit634hbase-shell in the patch passed.
+1asflicense13The patch does not generate ASF License warnings.
1641
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/1/artifact/out/Dockerfile
GITHUB PR#224
Optional Testsdupname asflicense javac javadoc unit yamllint
unameLinux e1899f3870bb 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 6de308c
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/1/testReport/
Max. process+thread count2574 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for the re-triggered Q&A.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec49Docker mode activated.
_ Prechecks _
0yamllint1yamllint was not available.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall309master passed
+1javadoc15master passed
_ Patch Compile Tests _
+1mvninstall323the patch passed
+1whitespace0The patch has no whitespace issues.
+1javadoc14the patch passed
_ Other Tests _
+1unit674hbase-shell in the patch passed.
+1asflicense12The patch does not generate ASF License warnings.
1467
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/2/artifact/out/Dockerfile
GITHUB PR#224
Optional Testsdupname asflicense javac javadoc unit yamllint
unameLinux 2d38ddcc76ed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 6de308c
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/2/testReport/
Max. process+thread count2519 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mixed the ticket numbers. The change actually looks like HBASE-20851, instead of HBASE-22358.

@murtazahassan123murtazahassan123 changed the title HBASE-22358 Change rubocop configuration for method lengthHBASE-20851 Change rubocop config for max line length of 100May 7, 2019
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
0yamllint0yamllint was not available.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall298master passed
+1javadoc15master passed
_ Patch Compile Tests _
+1mvninstall307the patch passed
+1whitespace0The patch has no whitespace issues.
+1javadoc15the patch passed
_ Other Tests _
+1unit625hbase-shell in the patch passed.
+1asflicense13The patch does not generate ASF License warnings.
1382
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/3/artifact/out/Dockerfile
GITHUB PR#224
Optional Testsdupname asflicense javac javadoc unit yamllint
unameLinux 5c2b174475e5 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 6de308c
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/3/testReport/
Max. process+thread count2574 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 2005122 into apache:masterMay 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@murtazahassan123@Apache-HBase@HorizonNet