Uh oh!
There was an error while loading. Please reload this page.
HBASE-24908 Correct the description of hbase.offpeak.end.hour - #2279
HBASE-24908 Correct the description of hbase.offpeak.end.hour#2279bsglz wants to merge 1 commit into
Conversation
Apache-HBase
commented
Aug 19, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 19, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 19, 2020
🎊 +1 overall
This message was automatically generated. |
virajjasani
commented
Aug 19, 2020
|
bsglz
commented
Aug 20, 2020
Oh, yeah, sorry. |
Apache-HBase
commented
Aug 20, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 20, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 20, 2020
💔 -1 overall
This message was automatically generated. |
virajjasani
left a comment
There was a problem hiding this comment.
We have this condition:
private static boolean isValidHour(int hour) {
return 0 <= hour && hour <= 23;
}
which means 0 and 23 are inclusive only right? Am I missing something?
bsglz
commented
Aug 20, 2020
It only means we can set number which between 0 and 23, but the later number not be treated as offpeak hour. |
The related logic shows below.
this line: return startHour <= targetHour && targetHour < endHour; |
Apache-HBase
commented
Aug 31, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 31, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 31, 2021
💔 -1 overall
This message was automatically generated. |
No description provided.