Skip to content

HBASE-22311 - Update community docs to recommend use of "Co-authored-… - #235

Merged
petersomogyi merged 2 commits into
apache:masterfrom
nkalmar:HBASE-22311
May 27, 2019
Merged

HBASE-22311 - Update community docs to recommend use of "Co-authored-…#235
petersomogyi merged 2 commits into
apache:masterfrom
nkalmar:HBASE-22311

Conversation

@nkalmar

Copy link
Copy Markdown
Contributor

…by" in git commits

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1docker174Docker failed to build yetus/hbase:b002b0b.
SubsystemReport/Notes
GITHUB PR#235
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey

Copy link
Copy Markdown
Contributor

that yetus failure is HBASE-22406

Comment threadsrc/main/asciidoc/_chapters/developer.adoc
@HorizonNet

Copy link
Copy Markdown
Contributor

To see the final result of the book with the changes, I just re-triggered the build.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec22Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
_ master Compile Tests _
+1mvninstall234master passed
0refguide703branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1mvninstall240the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide431patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1asflicense16The patch does not generate ASF License warnings.
1697
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/artifact/out/Dockerfile
GITHUB PR#235
Optional Testsdupname asflicense refguide
unameLinux 74b9fe77fc34 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / fde0251
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/artifact/out/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/artifact/out/patch-site/book.html
Max. process+thread count96 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Comment threadsrc/main/asciidoc/_chapters/developer.adoc Outdated
@HorizonNet

Copy link
Copy Markdown
Contributor

LGTM, pending QA (which should be fine).

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec177Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
_ master Compile Tests _
+1mvninstall273master passed
0refguide450branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1mvninstall269the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide456patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1asflicense16The patch does not generate ASF License warnings.
1687
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/artifact/out/Dockerfile
GITHUB PR#235
Optional Testsdupname asflicense refguide
unameLinux f5c03b2cbece 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / fab2e15
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/artifact/out/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/artifact/out/patch-site/book.html
Max. process+thread count81 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-235/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet

Copy link
Copy Markdown
Contributor

@busbey Does the change also looks good for you?

@petersomogyi
petersomogyi requested a review from busbeyMay 26, 2019 15:03
@petersomogyi
petersomogyi merged commit b4dc778 into apache:masterMay 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nkalmar@Apache-HBase@busbey@HorizonNet@petersomogyi