Uh oh!
There was an error while loading. Please reload this page.
HBASE-22481: Javadoc Warnings reference not found - #254
Merged
Conversation
Apache-HBase
commented
May 27, 2019
💔 -1 overall
This message was automatically generated. |
…checkstyle-suppress.xml file
Apache-HBase
commented
May 27, 2019
💔 -1 overall
This message was automatically generated. |
| <suppress checks="IllegalImport" message="org\.apache\.htrace\.core"/> | ||
| <suppress checks="ImportOrder" message="Extra separation in import group before"/> | ||
| <suppress checks="MethodLength" files="DemoClient.java"/> | ||
| <suppress checks="LineLength" files="MultiTableSnapshotInputFormat.java"/> |
Contributor
There was a problem hiding this comment.
Could you please check if it is possible to add the package name to the file suppression?
ContributorAuthor
There was a problem hiding this comment.
I have checked and it is possible. Please find the latest commit.
Contributor
There was a problem hiding this comment.
Is it possible to suppress LineLenght check only on the offending lines in the javadoc instead of completely ignoring it in the org.apache.hadoop.hbase.mapred package?
ContributorAuthor
There was a problem hiding this comment.
Thanks i will look into it.
ContributorAuthor
There was a problem hiding this comment.
I have suppressed LineLength check only on the offending lines in the javadoc using "@SuppressWarnings" annotation. Kindly check the 4th commit for this change.
Apache-HBase
commented
May 28, 2019
🎊 +1 overall
This message was automatically generated. |
…t check only on the offending lines in the javadoc
Apache-HBase
commented
Jun 7, 2019
💔 -1 overall
This message was automatically generated. |
petersomogyi
approved these changes
Jun 8, 2019
petersomogyi
left a comment
Contributor
There was a problem hiding this comment.
Neat solution! Thanks @SyedMurtazaHassan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the warnings javadoc warnings for MultiTableSnapshotInputFormat.java file.