Skip to content

HBASE-22003 Fix flaky test TestVerifyReplication.testHBase14905 - #259

Merged
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22003
May 28, 2019
Merged

HBASE-22003 Fix flaky test TestVerifyReplication.testHBase14905#259
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22003

Conversation

@infraio

@infraioinfraio commented May 28, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@infraio
infraio requested a review from Apache9May 28, 2019 06:39
@Apache-HBase

Apache-HBase commented May 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec25Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall256master passed
+1compile27master passed
+1checkstyle19master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1findbugs40master passed
+1javadoc18master passed
_ Patch Compile Tests _
+1mvninstall237the patch passed
+1compile25the patch passed
+1javac25the patch passed
+1checkstyle19the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars267patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck975Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs47the patch passed
+1javadoc18the patch passed
_ Other Tests _
-1unit929hbase-mapreduce in the patch failed.
+1asflicense17The patch does not generate ASF License warnings.
3507
ReasonTests
Failed junit testshadoop.hbase.snapshot.TestExportSnapshotNoCluster
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/1/artifact/out/Dockerfile
GITHUB PR#259
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 683b62051628 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 1c1638f
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/1/artifact/out/patch-unit-hbase-mapreduce.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/1/testReport/
Max. process+thread count5535 (vs. ulimit of 10000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio

infraio commented May 28, 2019

Copy link
Copy Markdown
ContributorAuthor

The failed ut not related.

Apache9
Apache9 approved these changes May 28, 2019
View reviewed changes
Comment threadhbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplication.java Outdated
Put put = new Put(Bytes.toBytes("r1"));
put.addColumn(famName, qualifierName, Bytes.toBytes("v1002"));
long ts = System.currentTimeMillis();
put.addColumn(famName, qualifierName, ts+1, Bytes.toBytes("v1002"));

@Apache9Apache9May 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting issue?ts+1 ->ts + 1

@infraio
infraio merged commit 9709056 into apache:masterMay 28, 2019
@Apache-HBase

Apache-HBase commented May 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec106Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall334master passed
+1compile41master passed
+1checkstyle31master passed
+1shadedjars351branch has no errors when building our shaded downstream artifacts.
+1findbugs66master passed
+1javadoc24master passed
_ Patch Compile Tests _
+1mvninstall355the patch passed
+1compile45the patch passed
+1javac45the patch passed
+1checkstyle29the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars418patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1451Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs72the patch passed
+1javadoc23the patch passed
_ Other Tests _
-1unit2849hbase-mapreduce in the patch failed.
+1asflicense20The patch does not generate ASF License warnings.
6612
ReasonTests
Failed junit testshadoop.hbase.snapshot.TestMobSecureExportSnapshot
hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory
hadoop.hbase.snapshot.TestSecureExportSnapshot
hadoop.hbase.snapshot.TestMobExportSnapshot
hadoop.hbase.snapshot.TestExportSnapshot
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/2/artifact/out/Dockerfile
GITHUB PR#259
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 46e43dae132e 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 1c1638f
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/2/artifact/out/patch-unit-hbase-mapreduce.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/2/testReport/
Max. process+thread count4360 (vs. ulimit of 10000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-259/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@Apache9