Uh oh!
There was an error while loading. Please reload this page.
HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline - #2670
HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline#2670apurtell wants to merge 4 commits into
Conversation
Apache-HBase
commented
Nov 17, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 18, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 18, 2020
🎊 +1 overall
This message was automatically generated. |
e2a0926 to
6824b0cCompareApache-HBase
commented
Nov 18, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 19, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 19, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 19, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 19, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 19, 2020
💔 -1 overall
This message was automatically generated. |
f7eec92 to
e2daa5cCompareApache-HBase
commented
Nov 20, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 20, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 20, 2020
💔 -1 overall
This message was automatically generated. |
0221713 to
01e4731CompareApache-HBase
commented
Nov 20, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 21, 2020
💔 -1 overall
This message was automatically generated. |
1 similar comment
Apache-HBase
commented
Nov 21, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 21, 2020
💔 -1 overall
This message was automatically generated. |
Network identities should be bound late. Remote addresses should be resolved at the last possible moment, just before connect(). Network identity mappings can change, so our code should not inappropriately cache them. Otherwise we might miss a change and fail to operate normally. Revert "HBASE-14544 Allow HConnectionImpl to not refresh the dns on errors" Removes hbase.resolve.hostnames.on.failure and related code. We always resolve hostnames, as late as possible. Preserve InetSocketAddress caching per RPC connection. Avoids potential lookups per Call. Replace InetSocketAddress with Address where used as a map key. If we want to key by hostname and/or resolved address we should be explicit about it. Using Address chooses mapping by hostname and port only. Add metrics for potential nameservice resolution attempts, whenever an InetSocketAddress is instantiated for connect; and metrics for failed resolution, whenever InetSocketAddress#isUnresolved on the new instance is true.
We resolve DNS at the latest possible time, at first call, and do not resolve hostnames for creating stubs at all, so this unit test cannot work now.
01e4731 to
165235dCompareApache-HBase
commented
Nov 25, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 26, 2020
🎊 +1 overall
This message was automatically generated. |
apurtell
commented
Dec 4, 2020
#2669 was merged, closing this and picking back the master commit. |
See description on #2669