[HBASE-22520] : Avoid possible NPE while performing seekBefore in Hal…

[virajjasani]

…fStoreFileReader

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	345	master passed
+1	compile	71	master passed
+1	checkstyle	81	master passed
+1	shadedjars	332	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	231	master passed
+1	javadoc	43	master passed
		_ Patch Compile Tests _
+1	mvninstall	308	the patch passed
+1	compile	69	the patch passed
+1	javac	69	the patch passed
-1	checkstyle	84	hbase-server: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	334	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	940	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	285	the patch passed
+1	javadoc	41	the patch passed
		_ Other Tests _
-1	unit	14914	hbase-server in the patch failed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		18554

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/1/artifact/out/Dockerfile
GITHUB PR	#281
JIRA Issue	HBASE-22520
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 51db5ae39cb6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / b2b7811
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/1/testReport/
Max. process+thread count	5587 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	50	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	262	master passed
+1	compile	53	master passed
+1	checkstyle	75	master passed
+1	shadedjars	279	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	181	master passed
+1	javadoc	33	master passed
		_ Patch Compile Tests _
+1	mvninstall	245	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	768	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	210	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
+1	unit	7683	hbase-server in the patch passed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		10605

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/2/artifact/out/Dockerfile
GITHUB PR	#281
JIRA Issue	HBASE-22520
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9ee76bd6cfa6 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / b2b7811
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/2/testReport/
Max. process+thread count	4575 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-281/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.