Uh oh!
There was an error while loading. Please reload this page.
HBASE-25459 WAL can't be cleaned in some scenes - #2848
Merged
Conversation
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
Can we have a UT testing this new behaviour?
| for (Long sid: sequenceids.values()) { | ||
| for (Map.Entry<? , Long> entry : sequenceids.entrySet()){ | ||
| if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){ | ||
| LOG.info("ColumnFamily is METAFAMILY! continue ..."); |
Contributor
There was a problem hiding this comment.
Should we rather do trace here?
ContributorAuthor
There was a problem hiding this comment.
no, I think. delete it at a new commit
| long lowest = HConstants.NO_SEQNUM; | ||
| for (Long sid: sequenceids.values()) { | ||
| for (Map.Entry<? , Long> entry : sequenceids.entrySet()){ | ||
| if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){ |
Contributor
There was a problem hiding this comment.
Do we need this extra entry.getKey() instanceof ImmutableByteArray check? Wouldn't entry.getKey().toString().equals("METAFAMILY") already gives false in the cases entry.getKey() isn't a ImmutableByteArray?
ContributorAuthor
There was a problem hiding this comment.
entry.getKey() instanceof ImmutableByteArray is for future, but it's no need at now , I has deleted it !
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
Can we have a UT testing this new behaviour?
Apache-HBase
commented
Jan 6, 2021
🎊 +1 overall
This message was automatically generated. |
leyangyueshan
commented
Jan 6, 2021
ContributorAuthor
|
Apache-HBase
commented
Jan 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 6, 2021
💔 -1 overall
This message was automatically generated. |
leyangyueshan
commented
Jan 7, 2021
ContributorAuthor
the UT has updated, pelease review again! @wchevreuil |
Apache-HBase
commented
Jan 7, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 7, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 7, 2021
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jan 7, 2021
Apache-HBase
commented
Jan 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 8, 2021
🎊 +1 overall
This message was automatically generated. |
wchevreuil pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6a401d8)
wchevreuil pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6a401d8)
wchevreuil pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6a401d8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.