Uh oh!
There was an error while loading. Please reload this page.
HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool - #288
Merged
Conversation
apurtell
reviewed
Jun 4, 2019
| private static final int statThreadPeriod = 60 * 5; | ||
| private AtomicLong createdChunkCount = new AtomicLong(); | ||
| private AtomicLong reusedChunkCount = new AtomicLong(); | ||
| private AtomicLong gotChunkCount = new AtomicLong(); |
Contributor
There was a problem hiding this comment.
Super minor nit.
"has" instead of "got" is more common, in our code base and elsewhere
ContributorAuthor
There was a problem hiding this comment.
It's a counter for the number of method Chunk#getChunk get called. Agree, "got" is not good. What about requestedChunkCount.
Apache-HBase
commented
Jun 4, 2019
💔 -1 overall
This message was automatically generated. |
ContributorAuthor
2nd commit removed the parent thread info from statistics thread which looks like this And address one nit, "got" > "requested". |
Reidddddd
commented
Jun 5, 2019
ContributorAuthor
Thank you sir, @apurtell |
Apache-HBase
commented
Jun 5, 2019
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new counter
gotChunkCountfor calculating reuse ratio.Correct
createdChunkCountinitial count.Set
logStatsINFO level, every 5 minutes which is not very chatty, and it is useful information.