HBASE-24772 Use GetoptLong or OptionParser in hbase-shell by laxmanlax · Pull Request #2918 · apache/hbase

laxmanlax · 2021-02-01T09:56:13Z

FIXME: Switch args processing to getopt

Apache-HBase · 2021-02-01T10:06:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 59s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 32s	the patch passed
-0 ⚠️	rubocop	0m 4s	The patch generated 20 new + 27 unchanged - 5 fixed = 47 total (was 32)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		9m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	dupname asflicense javac rubocop
uname	Linux fa3a0bf02a57 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-1.8.0_232-b09
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T10:14:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 33s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 49s	hbase-shell in the patch passed.
		17m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	javac javadoc unit
uname	Linux d55c3ecc1906 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/testReport/
Max. process+thread count	2194 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T10:16:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 2s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 59s	hbase-shell in the patch passed.
		19m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	javac javadoc unit
uname	Linux 06073125bbfc 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/testReport/
Max. process+thread count	1542 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T10:27:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
-0 ⚠️	rubocop	0m 4s	The patch generated 20 new + 27 unchanged - 5 fixed = 47 total (was 32)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		9m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	dupname asflicense javac rubocop
uname	Linux c574ebd3d2b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-1.8.0_232-b09
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T10:36:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 33s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 24s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 1s	hbase-shell in the patch passed.
		18m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	javac javadoc unit
uname	Linux 633ed5f5ee9e 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/testReport/
Max. process+thread count	1531 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T10:40:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 34s	master passed
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 29s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 14s	hbase-shell in the patch passed.
		22m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	javac javadoc unit
uname	Linux c6dd12f512f5 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/testReport/
Max. process+thread count	1536 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T10:59:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 25s	the patch passed
-0 ⚠️	rubocop	0m 5s	The patch generated 20 new + 27 unchanged - 5 fixed = 47 total (was 32)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		9m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	dupname asflicense javac rubocop
uname	Linux 4b9101bf9909 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-1.8.0_232-b09
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T11:07:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 7s	hbase-shell in the patch passed.
		16m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	javac javadoc unit
uname	Linux 02733620fada 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/testReport/
Max. process+thread count	2161 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-01T11:12:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 11s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 59s	the patch passed
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 4s	hbase-shell in the patch passed.
		21m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2918
Optional Tests	javac javadoc unit
uname	Linux 2481bdc3d8c0 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a04ea7e`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/testReport/
Max. process+thread count	1519 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-02-08T15:13:26Z

@bitoffdev would you like to take a look?

saintstack

LGTM.

You tried it? Each of the options still works? Thanks.

laxmanlax · 2021-02-09T04:55:52Z

@saintstack I updated the code and tried
> hbase shell on my devbox it works for me

Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>

Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org> (cherry picked from commit 1c64049)

…ase-shell (apache#2918) Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org> (cherry picked from commit 1c64049) Change-Id: If3687205dee882ad3371e54e879cefb239a65272

laxmanlax force-pushed the master branch from e3b1217 to 4e6dc47Compare February 1, 2021 10:07

HBASE-24772 Use GetoptLong or OptionParser in hbase-shell
2e9a8ff

laxmanlax force-pushed the master branch from 4e6dc47 to 2e9a8ffCompare February 1, 2021 10:50

virajjasani requested a review from saintstack February 8, 2021 15:13

saintstack approved these changes Feb 8, 2021
View reviewed changes

saintstack merged commit f09e420 into apache:masterFeb 9, 2021

saintstack pushed a commit that referenced this pull request Feb 9, 2021
HBASE-24772Use GetoptLong or OptionParser in hbase-shell (#2918)
1c64049
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>

ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021
HBASE-24772 Use GetoptLong or OptionParser in hbase-shell (apache#2918)
f4a73f3
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021
HBASE-24772 Use GetoptLong or OptionParser in hbase-shell (apache#2918)
7b7744e
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>

Navigation Menu

Uh oh!

HBASE-24772 Use GetoptLong or OptionParser in hbase-shell - #2918

HBASE-24772 Use GetoptLong or OptionParser in hbase-shell#2918
saintstack merged 1 commit into
apache:masterfrom
laxmanlax:master

laxmanlax commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

virajjasani commented Feb 8, 2021

Uh oh!

saintstack left a comment

Uh oh!

laxmanlax commented Feb 9, 2021•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

laxmanlax commented Feb 1, 2021

FIXME: Switch args processing to getopt

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

Apache-HBase commented Feb 1, 2021

Uh oh!

virajjasani commented Feb 8, 2021

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

laxmanlax commented Feb 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

laxmanlax commented Feb 9, 2021•
edited
Loading