HBASE-19762 Fixed Checkstyle errors in hbase-http by HorizonNet · Pull Request #131 · apache/hbase

HorizonNet · 2019-04-08T16:20:46Z

No description provided.

Apache-HBase · 2019-04-08T17:04:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	273	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 10 new or modified test files.
		_ master Compile Tests _
0	mvndep	24	Maven dependency ordering for branch
+1	mvninstall	254	master passed
+1	compile	32	master passed
+1	checkstyle	136	master passed
+1	shadedjars	264	branch has no errors when building our shaded downstream artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	32	master passed
+1	javadoc	26	master passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	249	the patch passed
+1	compile	31	the patch passed
+1	javac	31	the patch passed
+1	checkstyle	133	root: The patch generated 0 new + 0 unchanged - 143 fixed = 0 total (was 143)
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedjars	269	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	518	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	40	the patch passed
+1	javadoc	26	the patch passed
		_ Other Tests _
+1	unit	12	hbase-checkstyle in the patch passed.
+1	unit	56	hbase-http in the patch passed.
+1	asflicense	22	The patch does not generate ASF License warnings.
		2506

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/1/artifact/out/Dockerfile
GITHUB PR	#131
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml shadedjars hadoopcheck compile findbugs hbaseanti
uname	Linux 055b27d5ba5f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `89ce5d1`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/1/testReport/
Max. process+thread count	281 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-http U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-04-09T01:32:39Z

 <suppress checks="VisibilityModifier" files=".*/src/test/.*\.java"/>
 <suppress checks="InterfaceIsTypeCheck" files=".*/src/main/.*\.java"/>
 <suppress checks="EmptyBlockCheck" files="TBoundedThreadPoolServer.java"/>
+ <suppress checks="EmptyBlockCheck" files=".*/src/test/.*\.java"/>


Maybe too general? We disable this check in our the tests?

Yes, you're right. That's too general. Will change it.

Apache9 · 2019-04-09T01:33:39Z

@@ -1,4 +1,4 @@
-/**
+/*


I think this should be **?

Most of the time (example) I see it with a single *. I know that we use some kind of mixture. In IntelliJ this is also marked as a dangling JavaDoc comment.

But I think in HBase we usually use two stars, and also in hadoop? At least, our code template under the dev-support uses two stars.

Ok, let me change it back to **.

Apache9 · 2019-04-09T01:35:09Z

@@ -1,4 +1,4 @@
-/**
+/*
 *


Remove the empty line?

HorizonNet · 2019-04-09T21:18:52Z

@Apache9 I updated the PR according to your feedback. Thanks for that.

Apache-HBase · 2019-04-09T22:15:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 10 new or modified test files.
		_ master Compile Tests _
0	mvndep	45	Maven dependency ordering for branch
+1	mvninstall	333	master passed
+1	compile	27	master passed
+1	checkstyle	130	master passed
+1	shadedjars	308	branch has no errors when building our shaded downstream artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	70	master passed
+1	javadoc	68	master passed
		_ Patch Compile Tests _
0	mvndep	33	Maven dependency ordering for patch
+1	mvninstall	280	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	131	root: The patch generated 0 new + 0 unchanged - 143 fixed = 0 total (was 143)
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	6	The patch has no ill-formed XML file.
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	507	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	38	the patch passed
+1	javadoc	28	the patch passed
		_ Other Tests _
+1	unit	12	hbase-checkstyle in the patch passed.
+1	unit	53	hbase-http in the patch passed.
+1	asflicense	20	The patch does not generate ASF License warnings.
		2586

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/2/artifact/out/Dockerfile
GITHUB PR	#131
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml shadedjars hadoopcheck compile findbugs hbaseanti
uname	Linux e630cb7b8a9e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `387a5da`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/2/testReport/
Max. process+thread count	291 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-http U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-04-11T10:48:17Z

@Apache9 Currently trying to figure out GitHubs merge capabilities. Normally we use Rebase and merge, but this time we have two commits. Should I use Sqash and merge instead or do we have another approach for handling such cases?

Apache9 · 2019-04-11T10:50:44Z

Please do a force push to your own branch to merge the two commits into one first, and then use 'Rebase and merge'.

There is a discussion thread on the dev list about disabling squash and merge so we'd better not use it for now.

Apache-HBase · 2019-04-11T10:56:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	7	#131 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#131
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet added the enhancement label Apr 8, 2019

Apache9 requested changes Apr 9, 2019
View reviewed changes

HorizonNet requested a review from Apache9 April 9, 2019 21:18

Apache9 approved these changes Apr 10, 2019
View reviewed changes

HBASE-19762Fixed Checkstyle errors in hbase-http
21b9ae8

HorizonNet merged commit fc6e3fc into apache:masterApr 11, 2019

HorizonNet deleted the HBASE-19762 branch April 11, 2019 10:56

This was referenced Jan 21, 2021
HBASE-25522 Remove deprecated methods in ReplicationPeerConfig #2898
Merged
HBASE-25523 Region normalizer chore thread is getting killed #2903
Merged

This was referenced Jan 29, 2021
[HBASE-25536] Remove 0 length wal file from logQueue if it belongs to… #2912
Merged
HBASE-25498 [Documentation] Add a comment when using Secure HTTP (HTTPS) for the Web UI #2913
Merged

Navigation Menu

Uh oh!

HBASE-19762 Fixed Checkstyle errors in hbase-http - #131

HBASE-19762 Fixed Checkstyle errors in hbase-http#131
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-19762

HorizonNet commented Apr 8, 2019

Uh oh!

Apache-HBase commented Apr 8, 2019

Uh oh!

Apache9Apr 9, 2019

Uh oh!

HorizonNetApr 9, 2019

Uh oh!

Apache9Apr 9, 2019

Uh oh!

HorizonNetApr 9, 2019

Uh oh!

Apache9Apr 9, 2019

Uh oh!

HorizonNetApr 9, 2019

Uh oh!

Apache9Apr 9, 2019

Uh oh!

HorizonNet commented Apr 9, 2019

Uh oh!

Apache-HBase commented Apr 9, 2019

Uh oh!

HorizonNet commented Apr 11, 2019

Uh oh!

Apache9 commented Apr 11, 2019

Uh oh!

Apache-HBase commented Apr 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@@ @@ -1,4 +1,4 @@ @@
-/**
+/*
  *

Uh oh!

Conversation

HorizonNet commented Apr 8, 2019

Uh oh!

Apache-HBase commented Apr 8, 2019

Uh oh!

Apache9Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

HorizonNetApr 9, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

HorizonNetApr 9, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

HorizonNetApr 9, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

HorizonNet commented Apr 9, 2019

Uh oh!

Apache-HBase commented Apr 9, 2019

Uh oh!

HorizonNet commented Apr 11, 2019

Uh oh!

Apache9 commented Apr 11, 2019

Uh oh!

Apache-HBase commented Apr 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants