Skip to content

HBASE-22565 Javadoc Warnings: @see cannot be used in inline documentation - #300

Merged
HorizonNet merged 1 commit into
apache:masterfrom
murtazahassan123:HBASE-22565
Jun 13, 2019
Merged

HBASE-22565 Javadoc Warnings: @see cannot be used in inline documentation#300
HorizonNet merged 1 commit into
apache:masterfrom
murtazahassan123:HBASE-22565

Conversation

@murtazahassan123

@murtazahassan123murtazahassan123 commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

HBASE-22565: Fixed Javadoc Warnings: @see cannot be used in inline documentation

@Apache-HBase

Apache-HBase commented Jun 12, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0mvndep24Maven dependency ordering for branch
+1mvninstall267master passed
+1compile79master passed
+1checkstyle102master passed
+1shadedjars278branch has no errors when building our shaded downstream artifacts.
+1findbugs263master passed
+1javadoc53master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall263the patch passed
+1compile73the patch passed
+1javac73the patch passed
+1checkstyle23The patch passed checkstyle in hbase-common
+1checkstyle75hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1whitespace0The patch has no whitespace issues.
+1shadedjars278patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck791Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs255the patch passed
+1javadoc51the patch passed
_ Other Tests _
+1unit154hbase-common in the patch passed.
-1unit14762hbase-server in the patch failed.
+1asflicense62The patch does not generate ASF License warnings.
18245
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestFromClientSide3
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/artifact/out/Dockerfile
GITHUB PR#300
JIRA IssueHBASE-22565
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 423737def0ee 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 934d469
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/testReport/
Max. process+thread count4556 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet requested changes Jun 12, 2019
View reviewed changes

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. Otherwise it LGTM. It seems like you're missing a real commit message (it's only the ticket number currently). Would be good if you could change that too.

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
@murtazahassan123murtazahassan123 changed the title HBASE-22565HBASE-22565: Javadoc Warnings: @see cannot be used in inline documentationJun 12, 2019
@Apache-HBase

Apache-HBase commented Jun 12, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec27Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall233master passed
+1compile72master passed
+1checkstyle88master passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
+1findbugs231master passed
+1javadoc50master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall234the patch passed
+1compile70the patch passed
+1javac70the patch passed
+1checkstyle22The patch passed checkstyle in hbase-common
+1checkstyle66hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1whitespace0The patch has no whitespace issues.
+1shadedjars251patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck693Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs220the patch passed
+1javadoc49the patch passed
_ Other Tests _
+1unit161hbase-common in the patch passed.
+1unit8431hbase-server in the patch passed.
+1asflicense61The patch does not generate ASF License warnings.
11565
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/artifact/out/Dockerfile
GITHUB PR#300
JIRA IssueHBASE-22565
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 60f5fcfdc2d1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / ef44f30
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/testReport/
Max. process+thread count4972 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet

HorizonNet commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

@SyedMurtazaHassan You changed the title of the PR, but not the commit message. Could you please do that?

@murtazahassan123murtazahassan123 changed the title HBASE-22565: Javadoc Warnings: @see cannot be used in inline documentationHBASE-22565 Javadoc Warnings: @see cannot be used in inline documentationJun 13, 2019
@murtazahassan123

murtazahassan123 commented Jun 13, 2019

Copy link
Copy Markdown
ContributorAuthor

message

@HorizonNet Thanks for the feedback. I have changed the commit message.

@HorizonNet

HorizonNet commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

@SyedMurtazaHassan Thanks. Will merge it later today.

@Apache-HBase

Apache-HBase commented Jun 13, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec167Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author1The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0mvndep31Maven dependency ordering for branch
+1mvninstall296master passed
+1compile96master passed
+1checkstyle119master passed
+1shadedjars329branch has no errors when building our shaded downstream artifacts.
+1findbugs318master passed
+1javadoc65master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall298the patch passed
+1compile92the patch passed
+1javac92the patch passed
+1checkstyle28The patch passed checkstyle in hbase-common
+1checkstyle82hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1whitespace0The patch has no whitespace issues.
+1shadedjars322patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck939Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs331the patch passed
+1javadoc63the patch passed
_ Other Tests _
+1unit189hbase-common in the patch passed.
-1unit16562hbase-server in the patch failed.
+1asflicense61The patch does not generate ASF License warnings.
20804
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/artifact/out/Dockerfile
GITHUB PR#300
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a5d243f18046 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 863b7b9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/testReport/
Max. process+thread count4752 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 9ba7651 into apache:masterJun 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HorizonNetHorizonNetHorizonNet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@murtazahassan123@Apache-HBase@HorizonNet