Skip to content

HBASE-22547 Align the config keys and add document for offheap read in HBase Book. - #301

Merged
openinx merged 1 commit into
apache:HBASE-21879from
openinx:HBASE-22547
Jun 21, 2019
Merged

HBASE-22547 Align the config keys and add document for offheap read in HBase Book.#301
openinx merged 1 commit into
apache:HBASE-21879from
openinx:HBASE-22547

Conversation

@openinx

Copy link
Copy Markdown
Member

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec42Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
_ HBASE-21879 Compile Tests _
+1mvninstall266HBASE-21879 passed
+1mvnsite1379HBASE-21879 passed
0refguide481branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1mvninstall262the patch passed
+1mvnsite1109the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide482patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1asflicense12The patch does not generate ASF License warnings.
4100
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/1/artifact/out/Dockerfile
GITHUB PR#301
Optional Testsdupname asflicense refguide mvnsite
unameLinux 2b7af57aeb17 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21879 / a6e3d5b
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/1/artifact/out/branch-site/book.html
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/1/artifact/out/patch-site/book.html
Max. process+thread count86 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated
Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc Outdated

@anoopsjohnanoopsjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments added

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec27Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HBASE-21879 Compile Tests _
0mvndep24Maven dependency ordering for branch
+1mvninstall238HBASE-21879 passed
+1compile160HBASE-21879 passed
+1checkstyle128HBASE-21879 passed
+1mvnsite1115HBASE-21879 passed
0refguide431branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars262branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs38HBASE-21879 passed
+1javadoc178HBASE-21879 passed
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
+1mvninstall234the patch passed
+1compile160the patch passed
+1javac160the patch passed
+1checkstyle129the patch passed
+1mvnsite1024the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide446patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars254patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck709Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs44the patch passed
+1javadoc176the patch passed
_ Other Tests _
+1unit12786root in the patch passed.
+1asflicense76The patch does not generate ASF License warnings.
18961
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/2/artifact/out/Dockerfile
GITHUB PR#301
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide mvnsite
unameLinux ae23840a33ac 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21879 / 7840613
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/2/artifact/out/branch-site/book.html
findbugsv3.1.11
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/2/artifact/out/patch-site/book.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/2/testReport/
Max. process+thread count5704 (vs. ulimit of 10000)
modulesC: hbase-common . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec28Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HBASE-21879 Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall232HBASE-21879 passed
+1compile171HBASE-21879 passed
+1checkstyle142HBASE-21879 passed
+1mvnsite1116HBASE-21879 passed
0refguide452branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars281branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs41HBASE-21879 passed
+1javadoc183HBASE-21879 passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall238the patch passed
+1compile176the patch passed
+1javac176the patch passed
+1checkstyle130the patch passed
+1mvnsite1107the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide458patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars266patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck759Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs53the patch passed
+1javadoc189the patch passed
_ Other Tests _
+1unit12484root in the patch passed.
+1asflicense78The patch does not generate ASF License warnings.
18957
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/3/artifact/out/Dockerfile
GITHUB PR#301
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide mvnsite
unameLinux e2d21f77dc81 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21879 / 0d12281
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/3/artifact/out/branch-site/book.html
findbugsv3.1.11
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/3/artifact/out/patch-site/book.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/3/testReport/
Max. process+thread count5487 (vs. ulimit of 10000)
modulesC: hbase-common . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


public static final String MIN_ALLOCATE_SIZE_KEY =
"hbase.ipc.server.reservoir.minimal.allocating.size";
"hbase.server.reservoir.minimal.allocating.size";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of this patch any more right?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I forget remove the ipc of this config in https://issues.apache.org/jira/browse/HBASE-22598 before. So remove here.


Next thing to tune is the ByteBuffer pool on the RPC server side.
The buffers from this pool will be used to accumulate the cell bytes and create a result cell block to send back to the client side.
`hbase.ipc.server.reservoir.enabled` can be used to turn this pool ON or OFF. By default this pool is ON and available. HBase will create off heap ByteBuffers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we had this config also using ipc. .. We could have deprecated this too the same way. Sorry missed in last comment.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em..seems we can refactor this config as hbase.server.allocator.enabled... the hbase.ipc.server.reservoir.enabled is some confusing ...

and pool them. Please make sure not to turn this OFF if you want end-to-end off-heaping in read path.
If this pool is turned off, the server will create temp buffers on heap to accumulate the cell bytes and make a result cell block. This can impact the GC on a highly read loaded server.
The user can tune this pool with respect to how many buffers are in the pool and what should be the size of each ByteBuffer.
Use the config `hbase.ipc.server.reservoir.initial.buffer.size` to tune each of the buffer sizes. Default is 64 KB for HBase2.x, while it will be changed to 65KB by default for HBase3.x

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all these new document, can we refer to new config at 1st place. Also say the old one and is deprecated in 3.0

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK.

@anoopsjohnanoopsjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openinx
openinxforce-pushed the HBASE-22547 branch 2 times, most recently from f6ae122 to 5e93acbCompareJune 18, 2019 13:30

Next thing to tune is the ByteBuffer pool on the RPC server side:

NOTE: the config keys which starts with prefix hbase.ipc.server.reservoir are deprecated in HBase3.x. If you are still

@openinxopeninxJun 18, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all these new document, can we refer to new config at 1st place. Also say the old one and is deprecated in 3.0

@anoopsjohn, I've addressed your comment here.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec31Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ HBASE-21879 Compile Tests _
0mvndep21Maven dependency ordering for branch
+1mvninstall252HBASE-21879 passed
+1compile173HBASE-21879 passed
+1checkstyle129HBASE-21879 passed
+1mvnsite1127HBASE-21879 passed
0refguide465branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars270branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs37HBASE-21879 passed
+1javadoc175HBASE-21879 passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall234the patch passed
+1compile161the patch passed
+1javac161the patch passed
+1checkstyle135the patch passed
+1mvnsite1034the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide448patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars265patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck732Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs47the patch passed
+1javadoc181the patch passed
_ Other Tests _
-1unit12273root in the patch failed.
+1asflicense79The patch does not generate ASF License warnings.
18610
ReasonTests
Failed junit testshadoop.hbase.client.TestAdminShell
hadoop.hbase.client.TestTableShell
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/5/artifact/out/Dockerfile
GITHUB PR#301
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide mvnsite
unameLinux e055d9ffdc2e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21879 / afaf7a9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/5/artifact/out/branch-site/book.html
findbugsv3.1.11
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/5/artifact/out/patch-site/book.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/5/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/5/testReport/
Max. process+thread count5572 (vs. ulimit of 10000)
modulesC: hbase-common . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-21879 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall256HBASE-21879 passed
+1compile171HBASE-21879 passed
+1checkstyle144HBASE-21879 passed
+1mvnsite1152HBASE-21879 passed
0refguide483branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars273branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs245HBASE-21879 passed
+1javadoc206HBASE-21879 passed
_ Patch Compile Tests _
0mvndep11Maven dependency ordering for patch
+1mvninstall249the patch passed
+1compile172the patch passed
+1javac172the patch passed
-1checkstyle151root: The patch generated 2 new + 77 unchanged - 0 fixed = 79 total (was 77)
+1mvnsite1160the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide487patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars278patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck778Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs263the patch passed
+1javadoc208the patch passed
_ Other Tests _
-1unit17356root in the patch failed.
+1asflicense101The patch does not generate ASF License warnings.
24519
ReasonTests
Failed junit testshadoop.hbase.client.TestTableShell
hadoop.hbase.client.TestAdminShell
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/artifact/out/Dockerfile
GITHUB PR#301
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide mvnsite
unameLinux ab68cbc68874 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21879 / afaf7a9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/artifact/out/branch-site/book.html
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/artifact/out/diff-checkstyle-root.txt
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/artifact/out/patch-site/book.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/testReport/
Max. process+thread count5040 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/6/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@openinx

Copy link
Copy Markdown
MemberAuthor

Ping @anoopsjohn , any other concerns ? I think it's the last subtask of HBASE-21879 until now. Thanks.

// default heap allocator, it will just allocate ByteBuffers from heap but wrapped by an ByteBuff.
public static final ByteBuffAllocator HEAP = ByteBuffAllocator.createOnHeap();

public static final String ALLOCATOR_ENABLED_KEY = "hbase.server.allocator.enabled";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should call it some way which can clear say if this is enabled, it is pooled stuff what we use. Anyways allocator will always be there in RS. It might be HEAP one.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusing, my fault. let's define the 4 new config keys as:

1. hbase.server.allocator.enabled -> hbase.server.allocator.pool.enabled
2. hbase.server.reservoir.minimal.allocating.size -> hbase.server.allocator.minimal.allocate.size
3. hbase.server.allocator.max.buffer.count
4. hbase.server.allocator.buffer.size

Will change all plances.

@anoopsjohnanoopsjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openinxopeninx changed the title HBASE-22547 Document for offheap read in HBase BookHBASE-22547 Align the config keys and add document for offheap read in HBase Book.Jun 20, 2019
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch10#301 does not apply to HBASE-21879. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/7/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@openinx

Copy link
Copy Markdown
MemberAuthor

Updated the patch:

  1. Rename the comment message as: Align the config keys and add document for offheap read in HBase Book;
  2. Reconsider the 4 new config keys. Say, defined as:
1. hbase.server.allocator.pool.enabled
2. hbase.server.allocator.minimal.allocate.size
3. hbase.server.allocator.max.buffer.count
4. hbase.server.allocator.buffer.size

Also checked all the places.
3. Fixed the checkstyle issues.

@anoopsjohn , PTAL.

@openinx

Copy link
Copy Markdown
MemberAuthor

Update the patch:

  1. refactor the name ALLOCATOR_ENABLED_KEY as ALLOCATOR_POOL_ENABLED_KEY ;
  2. also add a separate log message for HBase3.x, like the following:
Pool already reached its max capacity : XXX and no free buffers now. Consider increasing the value for 'hbase.ipc.server.reservoir.initial.max' ?

@anoopsjohn FYI.

@openinx
openinx merged commit ff7e40d into apache:HBASE-21879Jun 21, 2019
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-21879 Compile Tests _
0mvndep28Maven dependency ordering for branch
+1mvninstall275HBASE-21879 passed
+1compile178HBASE-21879 passed
+1checkstyle146HBASE-21879 passed
+1mvnsite1178HBASE-21879 passed
0refguide477branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars275branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs250HBASE-21879 passed
+1javadoc207HBASE-21879 passed
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
+1mvninstall250the patch passed
+1compile171the patch passed
+1javac171the patch passed
+1checkstyle154the patch passed
+1mvnsite1166the patch passed
+1whitespace0The patch has no whitespace issues.
0refguide490patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1shadedjars277patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck793Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: .
+1findbugs269the patch passed
+1javadoc212the patch passed
_ Other Tests _
-1unit13069root in the patch failed.
+1asflicense86The patch does not generate ASF License warnings.
20355
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/9/artifact/out/Dockerfile
GITHUB PR#301
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide mvnsite
unameLinux 8d7c075235f1 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21879 / afaf7a9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/9/artifact/out/branch-site/book.html
findbugsv3.1.11
refguidehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/9/artifact/out/patch-site/book.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/9/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/9/testReport/
Max. process+thread count4622 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-301/9/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

asfgit pushed a commit that referenced this pull request Jun 24, 2019
openinx added a commit to openinx/hbase that referenced this pull request Jun 25, 2019
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@openinx@Apache-HBase@anoopsjohn