Skip to content

HBASE-25630 Set switch compaction after bulkload default as false - #3022

Merged
nyl3532016 merged 1 commit into
apache:masterfrom
nyl3532016:HBASE-25630
Mar 9, 2021
Merged

HBASE-25630 Set switch compaction after bulkload default as false#3022
nyl3532016 merged 1 commit into
apache:masterfrom
nyl3532016:HBASE-25630

Conversation

@nyl3532016

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 42smaster passed
+1 💚compile8m 11smaster passed
+1 💚checkstyle2m 0smaster passed
+0 🆗refguide3m 29sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
-1 ❌spotbugs9m 3sroot in master has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 26sthe patch passed
+1 💚compile8m 7sthe patch passed
-0 ⚠️javac8m 7sroot generated 1 new + 1561 unchanged - 1 fixed = 1562 total (was 1562)
+1 💚checkstyle2m 1sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide3m 22spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck17m 26sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs0m 52shbase-common in the patch passed.
+1 💚spotbugs2m 9shbase-server in the patch passed.
+1 💚spotbugs9m 2sroot generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚asflicense0m 41sThe patch does not generate ASF License warnings.
85m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3022
Optional Testsdupname asflicense javac refguide xml spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 62cebc167057 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 830d289
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/artifact/yetus-general-check/output/branch-site/book.html
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count141 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 20smaster passed
+1 💚compile2m 50smaster passed
+1 💚shadedjars6m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 58sthe patch passed
+1 💚compile2m 51sthe patch passed
+1 💚javac2m 51sthe patch passed
+1 💚shadedjars6m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 42sthe patch passed
_ Other Tests _
+1 💚unit171m 34sroot in the patch passed.
210m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3022
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b3f3774714c1 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 830d289
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/testReport/
Max. process+thread count6294 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Request Compaction after bulkload immediately.
If bulkload is continuous, the triggered compactions may increase load,
bring about performance side effect.
(During HBase-2.0, "hbase.compaction.after.bulkload.enable" default value is true)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'For HBase-2.x, the default value for "hbase.compaction.after.bulkload.enable" is true'.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I amend it

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 3smaster passed
+1 💚compile8m 37smaster passed
+1 💚checkstyle2m 16smaster passed
+0 🆗refguide3m 43sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
-1 ❌spotbugs10m 3sroot in master has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile8m 29sthe patch passed
+1 💚javac8m 29sthe patch passed
+1 💚checkstyle2m 19sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide3m 36spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck19m 6sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs0m 52shbase-common in the patch passed.
+1 💚spotbugs2m 19shbase-server in the patch passed.
+1 💚spotbugs10m 18sroot generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
93m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3022
Optional Testsdupname asflicense javac refguide xml spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 4a091d5f5308 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 190c253
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-general-check/output/branch-site/book.html
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall4m 2smaster passed
+1 💚compile2m 47smaster passed
+1 💚shadedjars6m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile2m 50sthe patch passed
+1 💚javac2m 50sthe patch passed
+1 💚shadedjars6m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 35sthe patch passed
_ Other Tests _
+1 💚unit168m 57sroot in the patch passed.
207m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3022
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d29c1fb8dd08 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 190c253
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/testReport/
Max. process+thread count6408 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 41smaster passed
+1 💚compile2m 20smaster passed
+1 💚shadedjars6m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 25sthe patch passed
+1 💚compile2m 23sthe patch passed
+1 💚javac2m 23sthe patch passed
+1 💚shadedjars6m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 57sthe patch passed
_ Other Tests _
-1 ❌unit336m 32sroot in the patch failed.
371m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3022
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f0ad48b7ef0c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 190c253
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/testReport/
Max. process+thread count6018 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3022/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@nyl3532016
nyl3532016 requested a review from Apache9March 9, 2021 03:02
@nyl3532016
nyl3532016 merged commit 109bd24 into apache:masterMar 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nyl3532016@Apache-HBase@Apache9