Skip to content

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator - #140

Merged
Apache9 merged 1 commit into
apache:HBASE-21512from
Apache9:HBASE-21725
Apr 16, 2019
Merged

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator#140
Apache9 merged 1 commit into
apache:HBASE-21512from
Apache9:HBASE-21725

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec24Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-21512 Compile Tests _
0mvndep33Maven dependency ordering for branch
+1mvninstall246HBASE-21512 passed
+1compile76HBASE-21512 passed
+1checkstyle98HBASE-21512 passed
+1shadedjars260branch has no errors when building our shaded downstream artifacts.
+1findbugs213HBASE-21512 passed
+1javadoc54HBASE-21512 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall236the patch passed
+1compile72the patch passed
+1javac72the patch passed
-1checkstyle29hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1whitespace0The patch has no whitespace issues.
+1shadedjars252patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck489Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs254the patch passed
+1javadoc53the patch passed
_ Other Tests _
+1unit193hbase-client in the patch passed.
-1unit8677hbase-server in the patch failed.
+1asflicense55The patch does not generate ASF License warnings.
11492
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
hadoop.hbase.client.TestBufferedMutator
hadoop.hbase.client.TestHbck
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/artifact/out/Dockerfile
GITHUB PR#140
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 746e25029f57 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21512 / f47f6df
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/artifact/out/diff-checkstyle-hbase-client.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/testReport/
Max. process+thread count4785 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec18Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-21512 Compile Tests _
0mvndep13Maven dependency ordering for branch
+1mvninstall261HBASE-21512 passed
+1compile79HBASE-21512 passed
+1checkstyle104HBASE-21512 passed
+1shadedjars272branch has no errors when building our shaded downstream artifacts.
+1findbugs246HBASE-21512 passed
+1javadoc55HBASE-21512 passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall254the patch passed
+1compile78the patch passed
+1javac78the patch passed
+1checkstyle105the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars275patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck533Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs298the patch passed
+1javadoc62the patch passed
_ Other Tests _
+1unit202hbase-client in the patch passed.
-1unit9160hbase-server in the patch failed.
+1asflicense54The patch does not generate ASF License warnings.
12186
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
hadoop.hbase.replication.TestReplicationDroppedTables
hadoop.hbase.client.TestHbck
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/artifact/out/Dockerfile
GITHUB PR#140
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9badbcb24f6d 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21512 / f47f6df
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/testReport/
Max. process+thread count4893 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you deprecated some stuff, could you please add since which version it is deprecated and in which version it will be removed. An example:

@deprecated Since 2.0.0. Will be removed in 3.0.0. Use {@link CompareOperator} instead.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-21512 Compile Tests _
0mvndep27Maven dependency ordering for branch
+1mvninstall268HBASE-21512 passed
+1compile81HBASE-21512 passed
+1checkstyle108HBASE-21512 passed
+1shadedjars280branch has no errors when building our shaded downstream artifacts.
+1findbugs289HBASE-21512 passed
+1javadoc61HBASE-21512 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall270the patch passed
+1compile86the patch passed
+1javac86the patch passed
+1checkstyle108the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars285patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck546Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs267the patch passed
+1javadoc56the patch passed
_ Other Tests _
+1unit194hbase-client in the patch passed.
-1unit14635hbase-server in the patch failed.
+1asflicense51The patch does not generate ASF License warnings.
17766
ReasonTests
Failed junit testshadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.master.procedure.TestSCPWithReplicas
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/artifact/out/Dockerfile
GITHUB PR#140
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 7cf768ed521d 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionHBASE-21512 / f47f6df
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/testReport/
Max. process+thread count4640 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 requested a review from HorizonNetApril 15, 2019 07:51
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Ping @HorizonNet . Any other concerns? Thanks.

@HorizonNet

Copy link
Copy Markdown
Contributor

@Apache9 No, my points are addressed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@HorizonNet@infraio