Skip to content

HBASE-22590 Remove the deprecated methods in Table interface - #309

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22590
Jun 17, 2019
Merged

HBASE-22590 Remove the deprecated methods in Table interface#309
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22590

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@infraioinfraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I like the additional cleanup. Left a small question.

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending Q&A.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec70Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 20 new or modified test files.
_ master Compile Tests _
0mvndep31Maven dependency ordering for branch
+1mvninstall258master passed
+1compile215master passed
+1checkstyle203master passed
+1shadedjars277branch has no errors when building our shaded downstream artifacts.
+1findbugs475master passed
+1javadoc148master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall250the patch passed
+1compile212the patch passed
+1javac212the patch passed
-1checkstyle31hbase-client: The patch generated 13 new + 56 unchanged - 13 fixed = 69 total (was 69)
+1checkstyle75hbase-server: The patch generated 0 new + 107 unchanged - 25 fixed = 107 total (was 132)
+1checkstyle18The patch passed checkstyle in hbase-mapreduce
-1checkstyle34hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1checkstyle13The patch passed checkstyle in hbase-backup
+1checkstyle15The patch passed checkstyle in hbase-it
+1checkstyle14hbase-rest: The patch generated 0 new + 10 unchanged - 122 fixed = 10 total (was 132)
+1whitespace0The patch has no whitespace issues.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck781Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs496the patch passed
+1javadoc149the patch passed
_ Other Tests _
+1unit190hbase-client in the patch passed.
+1unit7692hbase-server in the patch passed.
+1unit965hbase-mapreduce in the patch passed.
+1unit195hbase-thrift in the patch passed.
+1unit899hbase-backup in the patch passed.
+1unit66hbase-it in the patch passed.
-1unit291hbase-rest in the patch failed.
+1asflicense211The patch does not generate ASF License warnings.
14984
ReasonTests
Failed junit testshadoop.hbase.rest.client.TestRemoteTable
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/1/artifact/out/Dockerfile
GITHUB PR#309
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 968857414c0f 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 1712d2b
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/1/artifact/out/diff-checkstyle-hbase-thrift.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/1/artifact/out/patch-unit-hbase-rest.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/1/testReport/
Max. process+thread count5430 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9force-pushed the HBASE-22590 branch 2 times, most recently from 252d50f to 70497e2CompareJune 16, 2019 14:31
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec96Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 21 new or modified test files.
_ master Compile Tests _
0mvndep39Maven dependency ordering for branch
+1mvninstall249master passed
+1compile210master passed
+1checkstyle196master passed
+1shadedjars259branch has no errors when building our shaded downstream artifacts.
+1findbugs460master passed
+1javadoc142master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall240the patch passed
+1compile214the patch passed
+1javac214the patch passed
+1checkstyle32hbase-client: The patch generated 0 new + 56 unchanged - 13 fixed = 56 total (was 69)
+1checkstyle71hbase-server: The patch generated 0 new + 108 unchanged - 26 fixed = 108 total (was 134)
+1checkstyle18The patch passed checkstyle in hbase-mapreduce
+1checkstyle31The patch passed checkstyle in hbase-thrift
+1checkstyle16The patch passed checkstyle in hbase-backup
+1checkstyle14The patch passed checkstyle in hbase-it
+1checkstyle16hbase-rest: The patch generated 0 new + 9 unchanged - 123 fixed = 9 total (was 132)
-1whitespace0The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1shadedjars262patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck792Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs457the patch passed
+1javadoc139the patch passed
_ Other Tests _
+1unit204hbase-client in the patch passed.
+1unit7877hbase-server in the patch passed.
+1unit919hbase-mapreduce in the patch passed.
+1unit177hbase-thrift in the patch passed.
+1unit807hbase-backup in the patch passed.
+1unit66hbase-it in the patch passed.
+1unit287hbase-rest in the patch passed.
+1asflicense255The patch does not generate ASF License warnings.
14951
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/3/artifact/out/Dockerfile
GITHUB PR#309
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 1b23bc68630a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 1712d2b
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
whitespacehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/3/artifact/out/whitespace-eol.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/3/testReport/
Max. process+thread count5793 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

Ah, whitespace...

Let me check...

@Apache9
Apache9 merged commit 9b413cf into apache:masterJun 17, 2019
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec27Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 21 new or modified test files.
_ master Compile Tests _
0mvndep23Maven dependency ordering for branch
+1mvninstall237master passed
+1compile212master passed
+1checkstyle185master passed
+1shadedjars271branch has no errors when building our shaded downstream artifacts.
+1findbugs465master passed
+1javadoc156master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall238the patch passed
+1compile213the patch passed
+1javac213the patch passed
+1checkstyle31hbase-client: The patch generated 0 new + 56 unchanged - 13 fixed = 56 total (was 69)
+1checkstyle69hbase-server: The patch generated 0 new + 108 unchanged - 26 fixed = 108 total (was 134)
+1checkstyle18The patch passed checkstyle in hbase-mapreduce
+1checkstyle33The patch passed checkstyle in hbase-thrift
+1checkstyle15The patch passed checkstyle in hbase-backup
+1checkstyle13The patch passed checkstyle in hbase-it
+1checkstyle15hbase-rest: The patch generated 0 new + 9 unchanged - 123 fixed = 9 total (was 132)
+1whitespace0The patch has no whitespace issues.
+1shadedjars252patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck719Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs503the patch passed
+1javadoc144the patch passed
_ Other Tests _
+1unit134hbase-client in the patch passed.
+1unit8854hbase-server in the patch passed.
+1unit1017hbase-mapreduce in the patch passed.
+1unit178hbase-thrift in the patch passed.
+1unit809hbase-backup in the patch passed.
+1unit66hbase-it in the patch passed.
+1unit297hbase-rest in the patch passed.
+1asflicense203The patch does not generate ASF License warnings.
15818
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/5/artifact/out/Dockerfile
GITHUB PR#309
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 774e366d2318 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / ed30909
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/5/testReport/
Max. process+thread count5768 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-309/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@HorizonNet@infraio