Skip to content

HBASE-25640 Support hbase rpc compression for remote rpc only#3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huaxiangsun wants to merge 1 commit into
base:master
Choose a base branch
from
Open

HBASE-25640 Support hbase rpc compression for remote rpc only #3113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@
import org.apache.hadoop.hbase.security.User;
import org.apache.hadoop.hbase.security.provider.SaslClientAuthenticationProvider;
import org.apache.hadoop.hbase.security.provider.SaslClientAuthenticationProviders;
import org.apache.hadoop.hbase.util.Addressing;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.hadoop.hbase.util.Pair;
import org.apache.hadoop.io.compress.CompressionCodec;
Expand DownExpand Up@@ -89,7 +90,18 @@ protected RpcConnection(Configuration conf, HashedWheelTimer timeoutTimer, Conne
MetricsConnection metrics) throws IOException {
this.timeoutTimer = timeoutTimer;
this.codec = codec;
this.compressor = compressor;
if (compressor != null) {

@ndimidukndimidukApr 5, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need to check if compressor is null because you never read it, and subsequent code is apparently fine with a null value.

@huaxiangsunhuaxiangsunApr 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking if compressor is null is that it can avoid a dns resolution if compressor is null (no compression is configured), which is the common use case.

@ndimidukndimidukApr 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. A comment to this effect would help the casual reader.

// Only enable compression for remote rpcs.
InetSocketAddress remoteAddr = Address.toSocketAddress(remoteId.getAddress());

@ndimidukndimidukApr 5, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this would be easier to read if you extract the isLocal(ConnectionId) logic into an external method. Then you can have a simpler conditional clause. Something like,

 this.compressor = isLocal(remoteId) ? null : compressor;

@huaxiangsunhuaxiangsunApr 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do.

if (!remoteAddr.isUnresolved() && Addressing.isLocalAddress(remoteAddr.getAddress())) {
this.compressor = null;
} else {
this.compressor = compressor;
}
} else {
this.compressor = null;
}

this.conf = conf;
this.metrics = metrics;
User ticket = remoteId.getTicket();
Expand Down