Uh oh!
There was an error while loading. Please reload this page.
HBASE-25640 Support hbase rpc compression for remote rpc only - #3113
Open
huaxiangsun wants to merge 1 commit into
Open
HBASE-25640 Support hbase rpc compression for remote rpc only#3113huaxiangsun wants to merge 1 commit into
huaxiangsun wants to merge 1 commit into
Conversation
Apache-HBase
commented
Mar 31, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2021
🎊 +1 overall
This message was automatically generated. |
ndimiduk
reviewed
Apr 5, 2021
ndimiduk
left a comment
Member
There was a problem hiding this comment.
I have some code style suggestions. I agree that a test would be helpful. Looking into our RpcConnection code, I don't have any strong suggestions
| this.timeoutTimer = timeoutTimer; | ||
| this.codec = codec; | ||
| this.compressor = compressor; | ||
| if (compressor != null) { |
Member
There was a problem hiding this comment.
nit: no need to check if compressor is null because you never read it, and subsequent code is apparently fine with a null value.
ContributorAuthor
There was a problem hiding this comment.
Checking if compressor is null is that it can avoid a dns resolution if compressor is null (no compression is configured), which is the common use case.
Member
There was a problem hiding this comment.
Ah, okay. A comment to this effect would help the casual reader.
| this.compressor = compressor; | ||
| if (compressor != null) { | ||
| // Only enable compression for remote rpcs. | ||
| InetSocketAddress remoteAddr = Address.toSocketAddress(remoteId.getAddress()); |
Member
There was a problem hiding this comment.
nit: this would be easier to read if you extract the isLocal(ConnectionId) logic into an external method. Then you can have a simpler conditional clause. Something like,
this.compressor = isLocal(remoteId) ? null : compressor;
Apache-HBase
commented
Oct 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 1, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 1, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 1, 2022
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did manual test to make sure this change works, it is hard to put up a unittest for this change.