Uh oh!
There was an error while loading. Please reload this page.
HBASE-25836 RegionStates#getAssignmentsForBalancer should only care about OPEN or OPENING regions - #3219
Merged
Merged
Conversation
apurtell
commented
May 2, 2021
ContributorAuthor
Tested in an integration cluster test scenario (see #3208) but let's see what the unit test results in the CR report looks like. |
Apache-HBase
commented
May 2, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
bharathv
approved these changes
May 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
| // to be online at that server until possibly the next balancer iteration or unless | ||
| // we decide to move it. Other states are not interesting as the region will either | ||
| // be closing, or splitting/merging, or will not be deployed. | ||
| if (!(node.isInState(State.OPEN)||node.isInState(State.OPENING))) { |
Contributor
There was a problem hiding this comment.
nit: spaces missing on either side of ||
or can be simplified to !node.isInState(State.OPEN, State.OPENING)
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Except for existing comments, changes look good
Uh oh!
There was an error while loading. Please reload this page.
Apache9
requested changes
May 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
apurtell
commented
May 3, 2021
ContributorAuthor
Updated after feedback |
apurtell
commented
May 3, 2021
ContributorAuthor
Update the new comment in RegionStates to be more clear. |
apurtell
commented
May 3, 2021
ContributorAuthor
Whitespace fix. |
virajjasani
approved these changes
May 3, 2021
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Left one nit reg log placeholder, else good to go
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…bout OPEN or OPENING regions RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all regions of interest to the balancer for the next chore iteration. We check if a table is in disabled state to exclude regions that will not be of interest (because disabled regions are or will be offline) or are in a state where they shouldn't be mutated (like SPLITTING). The current checks are not actually comprehensive. Filter out regions not in OPEN or OPENING state when building the set of interesting regions for the balancer to consider. Only regions open (or opening) on the cluster are of interest to balancing calculations for the current iteration. Regions in all other states can be expected to not be of interest – either offline (OFFLINE, or FAILED_*), not subject to balancer decisions now (SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be offline shortly (CLOSING) – until at least the next chore iteration. Add TRACE level logging.
apurtell
commented
May 3, 2021
ContributorAuthor
Address @virajjasani 's comment |
bharathv
reviewed
May 3, 2021
| // decides to move it. Regions in other states are not eligible for balancing, because | ||
| // they are closing, splitting, merging, or otherwise already in transition. | ||
| if (!node.isInState(State.OPEN, State.OPENING)) { | ||
| if (LOG.isTraceEnabled()) { |
Contributor
There was a problem hiding this comment.
Doing both isTraceEnabled() check and parameterized logging seems wasteful, its usually either one or the other.. I think the recommendation from log4j is to do the latter for concise code and avoid unnecessary temporary string objects...
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
May 4, 2021
asfgit pushed a commit
that referenced
this pull request
May 4, 2021
…bout OPEN or OPENING regions (#3219) RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all regions of interest to the balancer for the next chore iteration. We check if a table is in disabled state to exclude regions that will not be of interest (because disabled regions are or will be offline) or are in a state where they shouldn't be mutated (like SPLITTING). The current checks are not actually comprehensive. Filter out regions not in OPEN or OPENING state when building the set of interesting regions for the balancer to consider. Only regions open (or opening) on the cluster are of interest to balancing calculations for the current iteration. Regions in all other states can be expected to not be of interest – either offline (OFFLINE, or FAILED_*), not subject to balancer decisions now (SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be offline shortly (CLOSING) – until at least the next chore iteration. Add TRACE level logging. Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
asfgit pushed a commit
that referenced
this pull request
May 4, 2021
…bout OPEN or OPENING regions (#3219) RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all regions of interest to the balancer for the next chore iteration. We check if a table is in disabled state to exclude regions that will not be of interest (because disabled regions are or will be offline) or are in a state where they shouldn't be mutated (like SPLITTING). The current checks are not actually comprehensive. Filter out regions not in OPEN or OPENING state when building the set of interesting regions for the balancer to consider. Only regions open (or opening) on the cluster are of interest to balancing calculations for the current iteration. Regions in all other states can be expected to not be of interest – either offline (OFFLINE, or FAILED_*), not subject to balancer decisions now (SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be offline shortly (CLOSING) – until at least the next chore iteration. Add TRACE level logging. Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all regions of interest to the balancer for the next chore iteration. We check if a table is in disabled state to exclude regions that will not be of interest (because disabled regions are or will be offline) or are in a state where they shouldn't be mutated (like SPLITTING).
The current checks are not actually comprehensive. For example, splitting states are considered, but not merging.
Filter out regions not in OPEN or OPENING state when building the set of interesting regions for the balancer to consider. Only regions open (or opening) on the cluster are of interest to balancing calculations for the current iteration. Regions in all other states can be expected to not be of interest – either offline (OFFLINE, or FAILED_*), not subject to balancer decisions now (SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be offline shortly (CLOSING) – until at least the next chore iteration.