Skip to content

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma… - #3251

Merged
saintstack merged 1 commit into
apache:branch-2from
saintstack:HBASE-25876
May 12, 2021
Merged

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…#3251
saintstack merged 1 commit into
apache:branch-2from
saintstack:HBASE-25876

Conversation

@saintstack

@saintstacksaintstack commented May 10, 2021

Copy link
Copy Markdown
Contributor

…gic marker

@Apache-HBase

Apache-HBase commented May 10, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 36sbranch-2 passed
+1 💚compile4m 17sbranch-2 passed
+1 💚checkstyle1m 54sbranch-2 passed
+1 💚spotbugs4m 19sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 24sthe patch passed
+1 💚compile5m 18sthe patch passed
+1 💚javac5m 18sthe patch passed
+1 💚checkstyle0m 39shbase-client: The patch generated 0 new + 57 unchanged - 1 fixed = 57 total (was 58)
+1 💚checkstyle1m 23sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs4m 16sthe patch passed
_ Other Tests _
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
56m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3251
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux fe68fdf12963 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4e507cc
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 11, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 39sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall5m 24sbranch-2 passed
+1 💚compile1m 48sbranch-2 passed
+1 💚shadedjars7m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 29sthe patch passed
+1 💚compile1m 47sthe patch passed
+1 💚javac1m 47sthe patch passed
+1 💚shadedjars7m 58spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sthe patch passed
_ Other Tests _
+1 💚unit3m 2shbase-client in the patch passed.
+1 💚unit217m 11shbase-server in the patch passed.
258m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3251
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 86bde040dcae 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4e507cc
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/testReport/
Max. process+thread count2966 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 11, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 50sbranch-2 passed
+1 💚compile1m 42sbranch-2 passed
+1 💚shadedjars7m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 11sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 35sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars7m 30spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sthe patch passed
_ Other Tests _
+1 💚unit2m 40shbase-client in the patch passed.
-1 ❌unit244m 22shbase-server in the patch failed.
282m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3251
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cf35dfab3c53 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4e507cc
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/testReport/
Max. process+thread count2333 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed May 12, 2021
View reviewed changes
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java Outdated
//assumption: if Writable serialization, it should be longer than pblen.
int read = in.read(pbuf);
if (read != pblen) throw new IOException("read=" + read + ", wanted=" + pblen);
IOUtils.readFully(in, pbuf, 0, pblen);

@Apache9Apache9May 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataInputStream has a readFully method, so I think here we could just use that one?

@saintstacksaintstackMay 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me do your suggestion instead. Thanks.

@Apache-HBase

Apache-HBase commented May 12, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall3m 17sbranch-2 passed
+1 💚compile4m 6sbranch-2 passed
+1 💚checkstyle1m 39sbranch-2 passed
+1 💚spotbugs3m 7sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile4m 8sthe patch passed
+1 💚javac4m 8sthe patch passed
+1 💚checkstyle0m 33shbase-client: The patch generated 0 new + 57 unchanged - 1 fixed = 57 total (was 58)
+1 💚checkstyle1m 6sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 43sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
46m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3251
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux a154375e6593 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 61d9b46
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 12, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 30sbranch-2 passed
+1 💚compile1m 45sbranch-2 passed
+1 💚shadedjars7m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 11sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 29sthe patch passed
+1 💚compile1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
+1 💚shadedjars7m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7sthe patch passed
_ Other Tests _
+1 💚unit2m 46shbase-client in the patch passed.
+1 💚unit206m 33shbase-server in the patch passed.
243m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3251
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 960bb1b3db1b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 61d9b46
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/testReport/
Max. process+thread count2793 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 0755457 into apache:branch-2May 12, 2021
saintstack added a commit that referenced this pull request May 12, 2021
@saintstack
HBASE-25876Add retry if we fail to read all bytes of the protobuf ma…
1c829af
…gic marker (#3251)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
Apache9 pushed a commit that referenced this pull request Oct 26, 2024
@saintstack@Apache9
HBASE-25876Add retry if we fail to read all bytes of the protobuf ma…
a8ba838
…gic marker (#3251)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
(cherry picked from commit 0755457)
Apache9 pushed a commit that referenced this pull request Oct 26, 2024
@saintstack@Apache9
HBASE-25876Add retry if we fail to read all bytes of the protobuf ma…
5d8ec4d
…gic marker (#3251)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
(cherry picked from commit 0755457)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopsjohnanoopsjohnanoopsjohn approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saintstack@Apache-HBase@anoopsjohn@Apache9