Uh oh!
There was an error while loading. Please reload this page.
HBASE-25914 Provide slow/large logs on RegionServer UI - #3319
Merged
Conversation
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
May 27, 2021
| if(rs.isOnline()) { | ||
| try (Admin rsAdmin = rs.getConnection().getAdmin()) { | ||
| slowLogs = (List<OnlineLogRecord>)(List<?>)rsAdmin.getLogEntries(new HashSet<ServerName>(Arrays.asList(rs.getServerName())), "SLOW_LOG", ServerType.REGION_SERVER, HConstants.DEFAULT_SLOW_LOG_RING_BUFFER_SIZE, null); |
Contributor
There was a problem hiding this comment.
So, in general, we need to get this information from master? Then why not provide it on master status site...
Contributor
There was a problem hiding this comment.
@Apache9 Basically the ring buffers that store this slow/large RPC log info operate at RegionServer side, hence individual RegionServer will have it's own ring buffer to provide this logs. As opposed to say BalancerDecision or BalancerRejection logs (which are also built on the same framework - NamedQueue) have ring buffers running at master side, so they are displayed only at master page.
Contributor
There was a problem hiding this comment.
If they are on region server, then why we need to use Admin to get these slow logs...
Contributor
There was a problem hiding this comment.
I see your point. We have generic Admin API to retrieve all kind of log records, regardless of whether ring buffers operate on Master or RegionServer.
Admin#getLogEntries here
/**
* Retrieve recent online records from HMaster / RegionServers.
* Examples include slow/large RPC logs, balancer decisions by master.
*
* @param serverNames servers to retrieve records from, useful in case of records maintained
* by RegionServer as we can select specific server. In case of servertype=MASTER, logs will
* only come from the currently active master.
* @param logType string representing type of log records
* @param serverType enum for server type: HMaster or RegionServer
* @param limit put a limit to list of records that server should send in response
* @param filterParams additional filter params
* @return Log entries representing online records from servers
* @throws IOException if a remote or network exception occurs
*/
List<LogEntry> getLogEntries(Set<ServerName> serverNames, String logType,
ServerType serverType, int limit, Map<String, Object> filterParams) throws IOException;
Contributor
There was a problem hiding this comment.
Based on logType client connect master or RegionServer,
Here we are going to show slow/large logs of RegionSevrver, so instead of making Admin RPC we should directly fetch from HRegionServer.
ContributorAuthor
There was a problem hiding this comment.
@Apache9@pankaj72981 As @virajjasani says, there is a generic admin API to retrieve all kinds of log entries. If getting logs from RS by admin API is not a good way. Let me think about any good way to retrieve it directly from RS
Contributor
There was a problem hiding this comment.
@GeorryHuang Thanks, yes you can try to explore if you are able to directly fetch records from RegionServer.
virajjasani
self-requested a review
May 28, 2021 08:52
Apache-HBase
commented
May 28, 2021
🎊 +1 overall
This message was automatically generated. |
| import="org.apache.hadoop.hbase.client.Admin" | ||
| import="org.apache.hadoop.hbase.client.SnapshotDescription" | ||
| import="org.apache.hadoop.hbase.http.InfoServer" | ||
| import="org.apache.hadoop.hbase.master.HMaster" |
ContributorAuthor
There was a problem hiding this comment.
These imports should not appear here, I will remove them
Apache-HBase
commented
May 28, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 28, 2021
🎊 +1 overall
This message was automatically generated. |
| List<OnlineLogRecord> largeLogs = null; | ||
| if(rs.isOnline()) { | ||
| try (Admin rsAdmin = rs.getConnection().getAdmin()) { |
Contributor
There was a problem hiding this comment.
We should avoid Admin RPC here, can get SLOW_LOG directly from HRegionServer.
Apache-HBase
commented
Jun 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Jun 7, 2021
Uh oh!
There was an error while loading. Please reload this page.
pankaj72981
approved these changes
Jun 8, 2021
Apache-HBase
commented
Jun 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 8, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 8, 2021
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.