[HBASE-22606] : BucketCache additional tests by virajjasani · Pull Request #333 · apache/hbase

virajjasani · 2019-06-24T15:53:08Z

No description provided.

virajjasani · 2019-06-24T15:57:10Z

@wchevreuil Please review. Due to build issue, had to close #324 and create a new PR. Apologies for the same as I could not get why the build was giving -1 for patch even though the branch was already rebased with master.

saintstack

A few comments. Thank you for adding some nice new tests.

saintstack · 2019-06-24T17:39:20Z

 @Before
 public void setup() throws IOException {
 cache = new MockedBucketCache(ioEngineName, capacitySize, constructedBlockSize,
- constructedBlockSizes, writeThreads, writerQLen, persistencePath);


Why make persistencePath null?

Since persistencePath was defined as null and was not getting updated in the file ever after, I thought of removing the declaration and directly putting null

saintstack · 2019-06-24T17:41:31Z


+ @Test
+ public void testRetrieveFromMMap() throws Exception {
+ HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();


Do we get a new HBaseTestingUtility per test? If so, why not in the test setup rather than at head of each test?
Also CAPITALIZATION of variables is for statics, not locals as here.
Make a data member named testUtil and create the HTU instance in the @before ?

virajjasani · 2019-06-24T18:11:49Z

@saintstack Thanks for the review. Updated the PR. Please review

Apache-HBase · 2019-06-24T21:17:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	238	master passed
+1	compile	54	master passed
+1	checkstyle	64	master passed
+1	shadedjars	258	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	207	master passed
+1	javadoc	29	master passed
		_ Patch Compile Tests _
+1	mvninstall	234	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	67	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	268	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	727	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	202	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
+1	unit	8393	hbase-server in the patch passed.
+1	asflicense	23	The patch does not generate ASF License warnings.
		11182

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/2/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7eaa99425f02 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `531d290`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/2/testReport/
Max. process+thread count	4784 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

the-sakthi

Apart from what stack mentioned, I have left few minor nits. Also what do you think of :

Testing unsupported IOEngines as well (i.e. other then file/files, offheap, mmap, pmem)?
Testing more than one backing file? (using files:name1,name2 )?

Apache-HBase · 2019-06-24T21:38:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	56	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	250	master passed
+1	compile	56	master passed
+1	checkstyle	68	master passed
+1	shadedjars	278	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	204	master passed
+1	javadoc	32	master passed
		_ Patch Compile Tests _
+1	mvninstall	246	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
+1	checkstyle	70	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	291	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	779	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	212	the patch passed
+1	javadoc	35	the patch passed
		_ Other Tests _
-1	unit	17670	hbase-server in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		20654

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/1/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8a3ee482ac45 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `531d290`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/1/testReport/
Max. process+thread count	4966 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-06-25T16:19:22Z

Apart from what stack mentioned, I have left few minor nits. Also what do you think of :
Testing unsupported IOEngines as well (i.e. other then file/files, offheap, mmap, pmem)?
Testing more than one backing file? (using files:name1,name2 )?

@jatsakthi Thanks for your review. Updated the PR addressing all comments. Please take a look.
Review comments for changes suggested by @saintstack are also updated.

Also, additional test for above mentioned scenarios are added:

the-sakthi

One more suggestion.

Apache-HBase · 2019-06-25T22:18:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	235	master passed
+1	compile	53	master passed
+1	checkstyle	67	master passed
+1	shadedjars	262	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	211	master passed
+1	javadoc	31	master passed
		_ Patch Compile Tests _
+1	mvninstall	228	the patch passed
+1	compile	49	the patch passed
+1	javac	49	the patch passed
-1	checkstyle	63	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	255	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	698	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	205	the patch passed
+1	javadoc	31	the patch passed
		_ Other Tests _
-1	unit	19009	hbase-server in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		21780

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicas
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
	hadoop.hbase.quotas.TestSpaceQuotas
	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.replication.TestReplicationSmallTestsSync
	hadoop.hbase.tool.TestBulkLoadHFiles
	hadoop.hbase.master.TestSplitWALManager
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestHbck
	hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/3/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux dfd68492f8af 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `b426142`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/3/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/3/testReport/
Max. process+thread count	4825 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-26T13:48:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	166	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	286	master passed
+1	compile	57	master passed
+1	checkstyle	70	master passed
+1	shadedjars	273	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	218	master passed
+1	javadoc	32	master passed
		_ Patch Compile Tests _
+1	mvninstall	237	the patch passed
+1	compile	51	the patch passed
+1	javac	51	the patch passed
-1	checkstyle	65	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	260	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	744	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	217	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
-1	unit	16254	hbase-server in the patch failed.
+1	asflicense	22	The patch does not generate ASF License warnings.
		19309

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestMobSnapshotCloneIndependence
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/4/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 83df68984050 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0198868`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/4/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/4/testReport/
Max. process+thread count	4553 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-26T17:55:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	24	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	247	master passed
+1	compile	52	master passed
+1	checkstyle	67	master passed
+1	shadedjars	268	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	203	master passed
+1	javadoc	31	master passed
		_ Patch Compile Tests _
+1	mvninstall	244	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
-1	checkstyle	64	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	260	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	738	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	224	the patch passed
+1	javadoc	33	the patch passed
		_ Other Tests _
-1	unit	8096	hbase-server in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		10943

Reason	Tests
Failed junit tests	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/5/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4367abd7f3a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0198868`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/5/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/5/testReport/
Max. process+thread count	4363 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-06-26T18:00:37Z

@jatsakthi @busbey build is failing every time with some InterruptedIOException. Every time different test cases fail with IOE. How should we usually deal with it?

the-sakthi · 2019-06-26T21:15:34Z

@virajjasani usually the best way is to check if the tests are present in the upstream flakey list. If yes, then we can usually bypass this. Else, you can run the failing tests locally to check if they ought to pass. Thirdly, if it's almost guaranteed that the test failure is unrelated to the changes proposed, in that case, we can ignore the tests failures.

Apache-HBase · 2019-06-26T21:35:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	233	master passed
+1	compile	50	master passed
+1	checkstyle	65	master passed
+1	shadedjars	251	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	204	master passed
+1	javadoc	31	master passed
		_ Patch Compile Tests _
+1	mvninstall	236	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	65	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	268	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	729	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	213	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
+1	unit	7877	hbase-server in the patch passed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		10673

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/7/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7e3d961e8ee9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0198868`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/7/testReport/
Max. process+thread count	4298 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/7/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-26T23:43:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	49	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	277	master passed
+1	compile	50	master passed
+1	checkstyle	68	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	213	master passed
+1	javadoc	33	master passed
		_ Patch Compile Tests _
+1	mvninstall	258	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
-1	checkstyle	67	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	272	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	771	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	205	the patch passed
+1	javadoc	31	the patch passed
		_ Other Tests _
-1	unit	16135	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		19100

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/6/artifact/out/Dockerfile
GITHUB PR	#333
JIRA Issue	HBASE-22606
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d357ba9bac9e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0198868`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/6/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/6/testReport/
Max. process+thread count	4767 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-333/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-06-27T03:48:15Z

@virajjasani usually the best way is to check if the tests are present in the upstream flakey list. If yes, then we can usually bypass this. Else, you can run the failing tests locally to check if they ought to pass. Thirdly, if it's almost guaranteed that the test failure is unrelated to the changes proposed, in that case, we can ignore the tests failures.

Thanks @jatsakthi
Yes test failures were irrelevant in this case. Anyways, the latest build is successful finally.
Could you please help me approve/merge this patch as per your latest review?
Thanks

virajjasani · 2019-06-27T06:51:03Z

@wchevreuil @saintstack Please let me know if this looks good to you

virajjasani · 2019-06-30T18:41:59Z

Please review @saintstack @wchevreuil

wchevreuil · 2019-07-01T10:17:25Z

lgtm +1 on the latest commits. @jatsakthi @saintstack let me know if you guys have any other remarks, if not, I can squash the commits and merge the PR into master with your "signedoffs".

virajjasani · 2019-07-03T15:15:50Z

Please review @saintstack

the-sakthi · 2019-07-03T18:06:55Z

The changes look good to me @wchevreuil

virajjasani · 2019-07-06T06:33:56Z

Could you please take a look on this once @saintstack
I would try to quickly update the PR in case of any concerns

[HBASE-22606] : BucketCache additional tests
c1e2a82

saintstack reviewed Jun 24, 2019
View reviewed changes

minor changes
62962e3

the-sakthi reviewed Jun 24, 2019
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java Outdated

the-sakthi suggested changes Jun 24, 2019
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java

the-sakthi reviewed Jun 24, 2019
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java Outdated

additional tests with more changes
e3b6aa8

the-sakthi reviewed Jun 25, 2019
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java

the-sakthi reviewed Jun 25, 2019
View reviewed changes

Merge branch 'master' of github.com:apache/hbase into HBASE-22606-master
391272b

trigger the build
e6f88d6

virajjasani added 2 commits June 26, 2019 23:54

build trigger
e1684d0

checkstyle fix
5551f1e

the-sakthi approved these changes Jun 27, 2019
View reviewed changes

wchevreuil approved these changes Jul 1, 2019
View reviewed changes

wchevreuil closed this Jul 9, 2019

Uh oh!

Conversation

virajjasani commented Jun 24, 2019

Uh oh!

virajjasani commented Jun 24, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

saintstackJun 24, 2019

Choose a reason for hiding this comment

Uh oh!

virajjasaniJun 24, 2019

Choose a reason for hiding this comment

Uh oh!

saintstackJun 24, 2019

Choose a reason for hiding this comment

Uh oh!

virajjasaniJul 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

virajjasani commented Jun 24, 2019

Uh oh!

Apache-HBase commented Jun 24, 2019

Uh oh!

Uh oh!

the-sakthi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 24, 2019

Uh oh!

virajjasani commented Jun 25, 2019

Uh oh!

Uh oh!

the-sakthi left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 25, 2019

Uh oh!

Apache-HBase commented Jun 26, 2019

Uh oh!

Apache-HBase commented Jun 26, 2019

Uh oh!

virajjasani commented Jun 26, 2019

Uh oh!

the-sakthi commented Jun 26, 2019

Uh oh!

Apache-HBase commented Jun 26, 2019

Uh oh!

Apache-HBase commented Jun 26, 2019

Uh oh!

virajjasani commented Jun 27, 2019

Uh oh!

virajjasani commented Jun 27, 2019

Uh oh!

virajjasani commented Jun 30, 2019

Uh oh!

wchevreuil commented Jul 1, 2019

Uh oh!

virajjasani commented Jul 3, 2019

Uh oh!

the-sakthi commented Jul 3, 2019

Uh oh!

virajjasani commented Jul 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants