HBASE-22624 Should sanity check table configuration when clone snapsh… by infraio · Pull Request #335 · apache/hbase

infraio · 2019-06-25T03:24:13Z

…ot to a new table

Apache-HBase · 2019-06-25T09:24:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	155	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 15 new or modified test files.
		_ master Compile Tests _
0	mvndep	35	Maven dependency ordering for branch
+1	mvninstall	359	master passed
+1	compile	154	master passed
+1	checkstyle	147	master passed
+1	shadedjars	331	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	345	master passed
+1	javadoc	103	master passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	338	the patch passed
+1	compile	144	the patch passed
+1	javac	144	the patch passed
-1	checkstyle	85	hbase-server: The patch generated 17 new + 200 unchanged - 10 fixed = 217 total (was 210)
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	261	patch has 10 errors when building our shaded downstream artifacts.
+1	hadoopcheck	1016	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	386	the patch passed
+1	javadoc	96	the patch passed
		_ Other Tests _
-1	unit	16628	hbase-server in the patch failed.
+1	unit	310	hbase-thrift in the patch passed.
+1	unit	78	hbase-it in the patch passed.
-1	asflicense	92	The patch generated 1 ASF License warnings.
		21579

Reason	Tests
Failed junit tests	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.client.TestIllegalTableDescriptor
	hadoop.hbase.quotas.TestSpaceQuotas
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.replication.TestReplicationKillSlaveRS
	hadoop.hbase.client.TestFromClientSideWithCoprocessor

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/artifact/out/Dockerfile
GITHUB PR	#335
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f2035faa23cb 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `15ac781`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/artifact/out/patch-shadedjars.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/testReport/
asflicense	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	4783 (vs. ulimit of 10000)
modules	C: hbase-server hbase-thrift hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

the-sakthi · 2019-06-27T02:07:01Z

 StringUtils.join(",", DEFAULT_COLUMN_FAMILIES));

- conf.setBoolean("hbase.table.sanity.checks", true);
+ conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true);


Is this different from other conf.setBoolean("hbase.table.sanity.checks", true) which is removed from other tests like TestAvoidCellReferencesIntoShippedBlocks based on the default value of TableDescriptorChecker.TABLE_SANITY_CHECKS?

This is in moudle hbase-it. And this may be runed by user directly and with user's hbase-site.xml? So i didn't remove this.

the-sakthi · 2019-06-27T02:14:06Z

+ */
+ public static void sanityCheck(final Configuration conf, final TableDescriptor td,
+ boolean checkCompression, boolean checkEncryption) throws IOException {
+ boolean logWarn = false;


Can we add a comment here along the lines of: "Setting this to true logs the warning instead of throwing"?

Apache-HBase · 2019-06-27T04:00:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 15 new or modified test files.
		_ master Compile Tests _
0	mvndep	25	Maven dependency ordering for branch
+1	mvninstall	241	master passed
+1	compile	108	master passed
+1	checkstyle	120	master passed
+1	shadedjars	272	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	274	master passed
+1	javadoc	77	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	243	the patch passed
+1	compile	109	the patch passed
+1	javac	109	the patch passed
-1	checkstyle	71	hbase-server: The patch generated 2 new + 200 unchanged - 10 fixed = 202 total (was 210)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	266	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	728	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	297	the patch passed
+1	javadoc	77	the patch passed
		_ Other Tests _
-1	unit	7871	hbase-server in the patch failed.
+1	unit	178	hbase-thrift in the patch passed.
+1	unit	63	hbase-it in the patch passed.
+1	asflicense	84	The patch does not generate ASF License warnings.
		11549

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestIllegalTableDescriptor

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/2/artifact/out/Dockerfile
GITHUB PR	#335
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 910eddeca851 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0198868`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/2/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/2/testReport/
Max. process+thread count	4612 (vs. ulimit of 10000)
modules	C: hbase-server hbase-thrift hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T15:20:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	52	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 15 new or modified test files.
		_ master Compile Tests _
0	mvndep	26	Maven dependency ordering for branch
+1	mvninstall	265	master passed
+1	compile	109	master passed
+1	checkstyle	118	master passed
+1	shadedjars	282	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	325	master passed
+1	javadoc	80	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	259	the patch passed
+1	compile	114	the patch passed
+1	javac	114	the patch passed
+1	checkstyle	74	hbase-server: The patch generated 0 new + 200 unchanged - 10 fixed = 200 total (was 210)
+1	checkstyle	32	The patch passed checkstyle in hbase-thrift
+1	checkstyle	14	The patch passed checkstyle in hbase-it
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	288	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	830	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	336	the patch passed
+1	javadoc	79	the patch passed
		_ Other Tests _
-1	unit	15133	hbase-server in the patch failed.
+1	unit	264	hbase-thrift in the patch passed.
+1	unit	62	hbase-it in the patch passed.
+1	asflicense	70	The patch does not generate ASF License warnings.
		19186

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
	hadoop.hbase.client.TestIllegalTableDescriptor
	hadoop.hbase.client.TestFromClientSide

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/3/artifact/out/Dockerfile
GITHUB PR	#335
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a388dcdfaa15 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `b20044c`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/3/testReport/
Max. process+thread count	4813 (vs. ulimit of 10000)
modules	C: hbase-server hbase-thrift hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-01T11:09:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	177	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 15 new or modified test files.
		_ master Compile Tests _
0	mvndep	24	Maven dependency ordering for branch
+1	mvninstall	253	master passed
+1	compile	117	master passed
+1	checkstyle	120	master passed
+1	shadedjars	283	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	259	master passed
+1	javadoc	70	master passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	245	the patch passed
+1	compile	115	the patch passed
+1	javac	115	the patch passed
+1	checkstyle	77	hbase-server: The patch generated 0 new + 200 unchanged - 10 fixed = 200 total (was 210)
+1	checkstyle	32	The patch passed checkstyle in hbase-thrift
+1	checkstyle	13	The patch passed checkstyle in hbase-it
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	278	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	771	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	301	the patch passed
+1	javadoc	74	the patch passed
		_ Other Tests _
+1	unit	14651	hbase-server in the patch passed.
+1	unit	274	hbase-thrift in the patch passed.
+1	unit	68	hbase-it in the patch passed.
+1	asflicense	63	The patch does not generate ASF License warnings.
		18625

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/4/artifact/out/Dockerfile
GITHUB PR	#335
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux de1c18f6bf9d 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0c8dc5d`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/4/testReport/
Max. process+thread count	4674 (vs. ulimit of 10000)
modules	C: hbase-server hbase-thrift hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…ot to a new table

openinx

LGTM, +1 if HBASE QA is OK.

Apache-HBase · 2019-07-02T12:35:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	172	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 15 new or modified test files.
		_ master Compile Tests _
0	mvndep	29	Maven dependency ordering for branch
+1	mvninstall	325	master passed
+1	compile	145	master passed
+1	checkstyle	145	master passed
+1	shadedjars	347	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	388	master passed
+1	javadoc	91	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	318	the patch passed
+1	compile	141	the patch passed
+1	javac	141	the patch passed
+1	checkstyle	90	hbase-server: The patch generated 0 new + 200 unchanged - 10 fixed = 200 total (was 210)
+1	checkstyle	41	The patch passed checkstyle in hbase-thrift
+1	checkstyle	17	The patch passed checkstyle in hbase-it
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	347	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1022	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	401	the patch passed
+1	javadoc	92	the patch passed
		_ Other Tests _
-1	unit	17155	hbase-server in the patch failed.
+1	unit	317	hbase-thrift in the patch passed.
+1	unit	78	hbase-it in the patch passed.
+1	asflicense	75	The patch does not generate ASF License warnings.
		22193

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.quotas.TestSpaceQuotas
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestFromClientSideWithCoprocessor

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/5/artifact/out/Dockerfile
GITHUB PR	#335
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 93fdd0522a55 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `fabf2b8`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/5/testReport/
Max. process+thread count	5189 (vs. ulimit of 10000)
modules	C: hbase-server hbase-thrift hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-335/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

infraio · 2019-07-03T01:03:48Z

The failed ut should not related. Let me take a try on my local PC.

the-sakthi

lgtm

infraio force-pushed the HBASE-22624 branch from 580938d to 23c8262Compare June 27, 2019 00:47

the-sakthi reviewed Jun 27, 2019
View reviewed changes

infraio force-pushed the HBASE-22624 branch from 23c8262 to 74594bbCompare June 28, 2019 09:59

infraio force-pushed the HBASE-22624 branch from 74594bb to 44c78f2Compare July 1, 2019 05:58

openinx reviewed Jul 2, 2019
View reviewed changes

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Outdated

HBASE-22624 Should sanity check table configuration when clone snapsh…
b58ba27
…ot to a new table

infraio force-pushed the HBASE-22624 branch from 44c78f2 to b58ba27Compare July 2, 2019 06:17

openinx approved these changes Jul 2, 2019
View reviewed changes

the-sakthi approved these changes Jul 3, 2019
View reviewed changes

infraio merged commit 64e732d into apache:masterJul 3, 2019

infraio deleted the HBASE-22624 branch July 3, 2019 03:54

Navigation Menu

Uh oh!

HBASE-22624 Should sanity check table configuration when clone snapsh… - #335

HBASE-22624 Should sanity check table configuration when clone snapsh…#335
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22624

infraio commented Jun 25, 2019

Uh oh!

Apache-HBase commented Jun 25, 2019

Uh oh!

the-sakthiJun 27, 2019

Uh oh!

infraioJun 28, 2019

Uh oh!

the-sakthiJun 27, 2019

Uh oh!

infraioJun 28, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jul 1, 2019

Uh oh!

Uh oh!

Uh oh!

openinx left a comment

Uh oh!

Apache-HBase commented Jul 2, 2019

Uh oh!

infraio commented Jul 3, 2019

Uh oh!

the-sakthi left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

infraio commented Jun 25, 2019

Uh oh!

Apache-HBase commented Jun 25, 2019

Uh oh!

the-sakthiJun 27, 2019

Choose a reason for hiding this comment

Uh oh!

infraioJun 28, 2019

Choose a reason for hiding this comment

Uh oh!

the-sakthiJun 27, 2019

Choose a reason for hiding this comment

Uh oh!

infraioJun 28, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jul 1, 2019

Uh oh!

Uh oh!

Uh oh!

openinx left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jul 2, 2019

Uh oh!

infraio commented Jul 3, 2019

Uh oh!

the-sakthi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants