HBASE-22634 : Improve performance of BufferedMutator by sbarnoud · Pull Request #343 · apache/hbase

sbarnoud · 2019-06-26T17:47:24Z

As requested in the Jira HBASE-22634

busbey · 2019-06-26T17:59:55Z

Is there something specific to branch-2.1 for this that makes it irrelevant or substantively different for the master branch?

sbarnoud · 2019-06-26T18:14:02Z

If i didn’t mistake BufferedMutatorImpl doesn’t exist anymore on master. I build this on my cluster on a 2.1.4 ...

…

Le 26 juin 2019 à 20:00, Sean Busbey ***@***.***> a écrit : Is there something specific to branch-2.1 for this that makes it irrelevant or substantively different for the master branch? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Apache-HBase · 2019-06-26T18:21:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	376	branch-2.1 passed
+1	compile	31	branch-2.1 passed
+1	checkstyle	42	branch-2.1 passed
+1	shadedjars	330	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	84	branch-2.1 passed
+1	javadoc	28	branch-2.1 passed
		_ Patch Compile Tests _
-1	mvninstall	113	root in the patch failed.
+1	compile	30	the patch passed
+1	javac	30	the patch passed
-1	checkstyle	42	hbase-client: The patch generated 158 new + 51 unchanged - 1 fixed = 209 total (was 52)
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	171	patch has 11 errors when building our shaded downstream artifacts.
-1	hadoopcheck	105	The patch causes 11 errors with Hadoop v2.7.7.
-1	hadoopcheck	207	The patch causes 11 errors with Hadoop v2.8.5.
-1	hadoopcheck	310	The patch causes 11 errors with Hadoop v3.0.3.
-1	hadoopcheck	416	The patch causes 11 errors with Hadoop v3.1.2.
-1	findbugs	94	hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1	javadoc	27	the patch passed
		_ Other Tests _
-1	unit	32	hbase-client in the patch failed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		1973

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 50% of time Unsynchronized access at BufferedMutatorImpl.java:50% of time Unsynchronized access at BufferedMutatorImpl.java:[line 298]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.close() calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 251]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 368]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 299]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 86]

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 962ad3d2c112 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `a172b48`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-mvninstall-root.txt
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/diff-checkstyle-hbase-client.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-shadedjars.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-2.7.7.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-3.0.3.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-javac-3.1.2.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/new-findbugs-hbase-client.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/testReport/
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-06-27T02:00:28Z

If i didn’t mistake BufferedMutatorImpl doesn’t exist anymore on master. I build this on my cluster on a 2.1.4 ...
…
Le 26 juin 2019 à 20:00, Sean Busbey @.***> a écrit : Is there something specific to branch-2.1 for this that makes it irrelevant or substantively different for the master branch? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Yes, it is gone on master. We reimplement the sync client based on async client on master so the BufferedMutator and AsyncProcess are both removed.

Apache-HBase · 2019-06-27T10:00:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	161	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	306	branch-2.1 passed
+1	compile	31	branch-2.1 passed
+1	checkstyle	42	branch-2.1 passed
+1	shadedjars	304	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	78	branch-2.1 passed
+1	javadoc	27	branch-2.1 passed
		_ Patch Compile Tests _
-1	mvninstall	106	root in the patch failed.
+1	compile	30	the patch passed
+1	javac	30	the patch passed
-1	checkstyle	44	hbase-client: The patch generated 158 new + 51 unchanged - 1 fixed = 209 total (was 52)
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	160	patch has 11 errors when building our shaded downstream artifacts.
-1	hadoopcheck	96	The patch causes 11 errors with Hadoop v2.7.7.
-1	hadoopcheck	198	The patch causes 11 errors with Hadoop v2.8.5.
-1	hadoopcheck	299	The patch causes 11 errors with Hadoop v3.0.3.
-1	hadoopcheck	401	The patch causes 11 errors with Hadoop v3.1.2.
-1	findbugs	92	hbase-client generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1	javadoc	27	the patch passed
		_ Other Tests _
-1	unit	33	hbase-client in the patch failed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		1928

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 50% of time Unsynchronized access at BufferedMutatorImpl.java:50% of time Unsynchronized access at BufferedMutatorImpl.java:[line 298]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.close() calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 251]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 368]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 299]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 86]

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 734c932d4aec 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `a172b48`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-mvninstall-root.txt
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/diff-checkstyle-hbase-client.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-shadedjars.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-javac-2.7.7.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-javac-3.0.3.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-javac-3.1.2.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/new-findbugs-hbase-client.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/testReport/
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-27T10:41:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	54	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	295	branch-2.1 passed
+1	compile	30	branch-2.1 passed
+1	checkstyle	41	branch-2.1 passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	74	branch-2.1 passed
+1	javadoc	26	branch-2.1 passed
		_ Patch Compile Tests _
-1	mvninstall	106	root in the patch failed.
+1	compile	30	the patch passed
+1	javac	30	the patch passed
-1	checkstyle	44	hbase-client: The patch generated 158 new + 51 unchanged - 1 fixed = 209 total (was 52)
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	161	patch has 11 errors when building our shaded downstream artifacts.
-1	hadoopcheck	95	The patch causes 11 errors with Hadoop v2.7.7.
-1	hadoopcheck	189	The patch causes 11 errors with Hadoop v2.8.5.
-1	hadoopcheck	290	The patch causes 11 errors with Hadoop v3.0.3.
-1	hadoopcheck	390	The patch causes 11 errors with Hadoop v3.1.2.
-1	findbugs	92	hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1	javadoc	26	the patch passed
		_ Other Tests _
-1	unit	32	hbase-client in the patch failed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		1784

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 46% of time Unsynchronized access at BufferedMutatorImpl.java:46% of time Unsynchronized access at BufferedMutatorImpl.java:[line 236]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 371]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 302]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 94]

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e3789c53aae6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `a172b48`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-mvninstall-root.txt
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/diff-checkstyle-hbase-client.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-shadedjars.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-javac-2.7.7.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-javac-3.0.3.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-javac-3.1.2.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/new-findbugs-hbase-client.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/testReport/
Max. process+thread count	96 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-27T14:15:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	237	branch-2.1 passed
+1	compile	23	branch-2.1 passed
+1	checkstyle	29	branch-2.1 passed
+1	shadedjars	223	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	61	branch-2.1 passed
+1	javadoc	22	branch-2.1 passed
		_ Patch Compile Tests _
-1	mvninstall	76	root in the patch failed.
-1	compile	22	hbase-client in the patch failed.
-1	javac	22	hbase-client in the patch failed.
-1	checkstyle	34	hbase-client: The patch generated 161 new + 61 unchanged - 1 fixed = 222 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	118	patch has 14 errors when building our shaded downstream artifacts.
-1	hadoopcheck	70	The patch causes 14 errors with Hadoop v2.7.7.
-1	hadoopcheck	140	The patch causes 14 errors with Hadoop v2.8.5.
-1	hadoopcheck	214	The patch causes 14 errors with Hadoop v3.0.3.
-1	hadoopcheck	285	The patch causes 14 errors with Hadoop v3.1.2.
-1	findbugs	18	hbase-client in the patch failed.
+1	javadoc	20	the patch passed
		_ Other Tests _
-1	unit	22	hbase-client in the patch failed.
+1	asflicense	9	The patch does not generate ASF License warnings.
		1288

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7223070aa198 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `a172b48`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-mvninstall-root.txt
compile	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-compile-hbase-client.txt
javac	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-compile-hbase-client.txt
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/diff-checkstyle-hbase-client.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-shadedjars.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-javac-2.7.7.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-javac-3.0.3.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-javac-3.1.2.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-findbugs-hbase-client.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/testReport/
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-27T15:21:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	103	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	245	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	33	branch-2.1 passed
+1	shadedjars	239	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	62	branch-2.1 passed
+1	javadoc	22	branch-2.1 passed
		_ Patch Compile Tests _
-1	mvninstall	84	root in the patch failed.
+1	compile	25	the patch passed
+1	javac	25	the patch passed
-1	checkstyle	33	hbase-client: The patch generated 18 new + 60 unchanged - 2 fixed = 78 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	120	patch has 11 errors when building our shaded downstream artifacts.
-1	hadoopcheck	76	The patch causes 11 errors with Hadoop v2.7.7.
-1	hadoopcheck	156	The patch causes 11 errors with Hadoop v2.8.5.
-1	hadoopcheck	244	The patch causes 11 errors with Hadoop v3.0.3.
-1	hadoopcheck	327	The patch causes 11 errors with Hadoop v3.1.2.
-1	findbugs	70	hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1	javadoc	24	the patch passed
		_ Other Tests _
-1	unit	27	hbase-client in the patch failed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		1515

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 46% of time Unsynchronized access at BufferedMutatorImpl.java:46% of time Unsynchronized access at BufferedMutatorImpl.java:[line 236]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 371]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 302]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 94]

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4a148600d077 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `a172b48`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-mvninstall-root.txt
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/diff-checkstyle-hbase-client.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-shadedjars.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-javac-2.7.7.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-javac-3.0.3.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-javac-3.1.2.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/new-findbugs-hbase-client.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/testReport/
Max. process+thread count	83 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-27T16:16:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	91	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	228	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	33	branch-2.1 passed
+1	shadedjars	238	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	75	branch-2.1 passed
+1	javadoc	23	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	245	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
-1	checkstyle	48	hbase-client: The patch generated 18 new + 60 unchanged - 2 fixed = 78 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	318	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	997	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
-1	findbugs	74	hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1	javadoc	23	the patch passed
		_ Other Tests _
-1	unit	113	hbase-client in the patch failed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2898

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 46% of time Unsynchronized access at BufferedMutatorImpl.java:46% of time Unsynchronized access at BufferedMutatorImpl.java:[line 236]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 371]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 302]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 97]
Failed junit tests	hadoop.hbase.client.TestClientNoCluster
	hadoop.hbase.client.TestBufferedMutator
	hadoop.hbase.ipc.TestRpcClientDeprecatedNameMapping

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/6/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux fdb87df5a7a2 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `a172b48`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/6/artifact/out/diff-checkstyle-hbase-client.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/6/artifact/out/new-findbugs-hbase-client.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/6/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/6/testReport/
Max. process+thread count	94 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-27T17:26:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	218	branch-2.1 passed
+1	compile	23	branch-2.1 passed
+1	checkstyle	29	branch-2.1 passed
+1	shadedjars	222	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	60	branch-2.1 passed
+1	javadoc	21	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	222	the patch passed
+1	compile	22	the patch passed
+1	javac	22	the patch passed
-1	checkstyle	30	hbase-client: The patch generated 18 new + 60 unchanged - 2 fixed = 78 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	219	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	928	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
-1	findbugs	73	hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1	javadoc	23	the patch passed
		_ Other Tests _
-1	unit	116	hbase-client in the patch failed.
+1	asflicense	9	The patch does not generate ASF License warnings.
		2565

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 46% of time Unsynchronized access at BufferedMutatorImpl.java:46% of time Unsynchronized access at BufferedMutatorImpl.java:[line 236]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 371]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 302]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 97]
Failed junit tests	hadoop.hbase.client.TestBufferedMutator

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7071126567ec 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `60097a6`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/diff-checkstyle-hbase-client.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/new-findbugs-hbase-client.html
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/testReport/
Max. process+thread count	104 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/7/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-27T19:36:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	57	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	291	branch-2.1 passed
+1	compile	30	branch-2.1 passed
+1	checkstyle	40	branch-2.1 passed
+1	shadedjars	299	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	76	branch-2.1 passed
+1	javadoc	28	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	282	the patch passed
+1	compile	30	the patch passed
+1	javac	30	the patch passed
-1	checkstyle	40	hbase-client: The patch generated 18 new + 60 unchanged - 2 fixed = 78 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	289	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1181	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
-1	findbugs	89	hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1	javadoc	27	the patch passed
		_ Other Tests _
+1	unit	152	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3281

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int, List, boolean) calls Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At AsyncRequestFutureImpl.java:[line 592]
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 46% of time Unsynchronized access at BufferedMutatorImpl.java:46% of time Unsynchronized access at BufferedMutatorImpl.java:[line 239]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At BufferedMutatorImpl.java:[line 374]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 305]
	Dead store to f in org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread, Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 97]

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/8/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f948f8437b7a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `60097a6`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/8/artifact/out/diff-checkstyle-hbase-client.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/8/artifact/out/new-findbugs-hbase-client.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/8/testReport/
Max. process+thread count	273 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/8/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T09:16:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	225	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	31	branch-2.1 passed
+1	shadedjars	233	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	57	branch-2.1 passed
+1	javadoc	23	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	225	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
-1	checkstyle	34	hbase-client: The patch generated 22 new + 60 unchanged - 2 fixed = 82 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	232	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	902	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
-1	findbugs	69	hbase-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	javadoc	21	the patch passed
		_ Other Tests _
+1	unit	124	hbase-client in the patch passed.
+1	asflicense	9	The patch does not generate ASF License warnings.
		2550

Reason	Tests
FindBugs	module:hbase-client
	Inconsistent synchronization of org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer; locked 66% of time Unsynchronized access at BufferedMutatorImpl.java:66% of time Unsynchronized access at BufferedMutatorImpl.java:[line 239]
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 306]

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/9/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6151dcaa9ff2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `60097a6`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/9/artifact/out/diff-checkstyle-hbase-client.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/9/artifact/out/new-findbugs-hbase-client.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/9/testReport/
Max. process+thread count	291 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/9/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T10:08:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	89	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	247	branch-2.1 passed
+1	compile	25	branch-2.1 passed
+1	checkstyle	37	branch-2.1 passed
+1	shadedjars	243	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	61	branch-2.1 passed
+1	javadoc	22	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	238	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
-1	checkstyle	34	hbase-client: The patch generated 23 new + 60 unchanged - 2 fixed = 83 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	236	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	984	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
-1	findbugs	75	hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	javadoc	21	the patch passed
		_ Other Tests _
+1	unit	122	hbase-client in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		2778

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 308]

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/10/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8856ded457b8 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `60097a6`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/10/artifact/out/diff-checkstyle-hbase-client.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/10/artifact/out/new-findbugs-hbase-client.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/10/testReport/
Max. process+thread count	259 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/10/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T10:41:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	346	branch-2.1 passed
+1	compile	41	branch-2.1 passed
+1	checkstyle	46	branch-2.1 passed
+1	shadedjars	349	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	97	branch-2.1 passed
+1	javadoc	32	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	337	the patch passed
+1	compile	36	the patch passed
+1	javac	36	the patch passed
-1	checkstyle	42	hbase-client: The patch generated 23 new + 60 unchanged - 2 fixed = 83 total (was 62)
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	339	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1393	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
-1	findbugs	121	hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	javadoc	31	the patch passed
		_ Other Tests _
+1	unit	199	hbase-client in the patch passed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		3877

Reason	Tests
FindBugs	module:hbase-client
	org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not release lock on all paths At BufferedMutatorImpl.java:on all paths At BufferedMutatorImpl.java:[line 308]

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/11/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 450412f14146 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `60097a6`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/11/artifact/out/diff-checkstyle-hbase-client.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/11/artifact/out/new-findbugs-hbase-client.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/11/testReport/
Max. process+thread count	157 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/11/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T10:59:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	161	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	225	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	32	branch-2.1 passed
+1	shadedjars	226	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	58	branch-2.1 passed
+1	javadoc	22	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	217	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
-1	checkstyle	31	hbase-client: The patch generated 23 new + 60 unchanged - 2 fixed = 83 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	242	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	957	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	63	the patch passed
+1	javadoc	21	the patch passed
		_ Other Tests _
+1	unit	124	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		2724

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/12/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f942801736f6 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `60097a6`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/12/artifact/out/diff-checkstyle-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/12/testReport/
Max. process+thread count	289 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/12/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T12:44:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	321	branch-2.1 passed
+1	compile	37	branch-2.1 passed
+1	checkstyle	42	branch-2.1 passed
+1	shadedjars	302	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	90	branch-2.1 passed
+1	javadoc	31	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	318	the patch passed
+1	compile	42	the patch passed
+1	javac	42	the patch passed
-1	checkstyle	48	hbase-client: The patch generated 11 new + 57 unchanged - 5 fixed = 68 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	348	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1294	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	116	the patch passed
+1	javadoc	33	the patch passed
		_ Other Tests _
+1	unit	207	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3680

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/13/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 40d1b804ea2c 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `4bb063f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/13/artifact/out/diff-checkstyle-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/13/testReport/
Max. process+thread count	155 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/13/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T14:39:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	233	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	33	branch-2.1 passed
+1	shadedjars	234	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	60	branch-2.1 passed
+1	javadoc	22	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	224	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
-1	checkstyle	31	hbase-client: The patch generated 1 new + 56 unchanged - 6 fixed = 57 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	229	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1149	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	83	the patch passed
+1	javadoc	25	the patch passed
		_ Other Tests _
+1	unit	141	hbase-client in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2906

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/14/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8cb271eabcaf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `085ea6f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/14/artifact/out/diff-checkstyle-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/14/testReport/
Max. process+thread count	282 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/14/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T15:35:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	253	branch-2.1 passed
+1	compile	26	branch-2.1 passed
+1	checkstyle	32	branch-2.1 passed
+1	shadedjars	246	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	65	branch-2.1 passed
+1	javadoc	21	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	243	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	31	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	242	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	974	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	72	the patch passed
+1	javadoc	23	the patch passed
		_ Other Tests _
+1	unit	126	hbase-client in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2727

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/15/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ef9e902a1c02 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `085ea6f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/15/testReport/
Max. process+thread count	289 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/15/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-28T16:34:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	170	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	232	branch-2.1 passed
+1	compile	23	branch-2.1 passed
+1	checkstyle	32	branch-2.1 passed
+1	shadedjars	233	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	60	branch-2.1 passed
+1	javadoc	22	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	223	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	32	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	233	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	932	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	68	the patch passed
+1	javadoc	22	the patch passed
		_ Other Tests _
+1	unit	120	hbase-client in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2746

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/16/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 746581a4363a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `085ea6f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/16/testReport/
Max. process+thread count	287 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/16/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

sbarnoud · 2019-07-01T10:17:26Z

A spark job with 7 executors, 4 cores each, has an average throughput of more than 500000 insert/s with optimal tuning of:

hbase.client.write.buffer
hbase.htable.threads.max
hbase.client.max.total.tasks
hbase.client.max.perserver.tasks
hbase.client.ipc.pool.size
hbase.client.rpc.compressor (GzipCodec.class.getCanonicalName() seems to be always the best)

Where the input dataset is well balanced on the rowkey,on a table presplitted on 26 region servers, with a tiny average record size (500 bytes average).

The source of the Spark job is as simple as:

 df.toJavaRDD().foreachPartition(rows -> {
BufferedMutator.ExceptionListener listener = (e, mutator) -> {
for (int i = 0; i < e.getNumExceptions(); i++) {
log.warn("Failed to send put: " + e.getRow(i));
}
};
Configuration hadoopConf = HBaseConfiguration.create();
hadoopConf.set("hbase.client.write.buffer", options.getWriteBufferSize());
hadoopConf.set("hbase.client.max.perrequest.heapsize", options.getWriteBufferSize());
hadoopConf.set("hbase.htable.threads.keepalivetime", "60");
hadoopConf.set("hbase.client.max.total.tasks", options.getMaxTotalTasks());
hadoopConf.set("hbase.client.max.perserver.tasks", options.getMaxServerTasks());
hadoopConf.set("hbase.client.max.perregion.tasks", options.getMaxRegionTasks());
hadoopConf.set("hbase.htable.threads.max", options.getPoolSize());
hadoopConf.set("hbase.hconnection.threads.max", "1");
hadoopConf.set("hbase.hconnection.threads.core", "1");
hadoopConf.set("hbase.hconnection.meta.lookup.threads.max", "5");
hadoopConf.set("hbase.hconnection.meta.lookup.threads.core", "1");
hadoopConf.set("hbase.client.rpc.compressor", GzipCodec.class.getCanonicalName());
hadoopConf.set("hbase.client.ipc.pool.size",options.getIpcPoolSize());
// Use the same connection in each executor core
Connection connection = HBaseConnectionCache.getConnection(hadoopConf).connection();
TableName tableName = TableName.valueOf(options.getTable());
// If streaming, please modify that to reuse the pool.
BufferedMutatorThreadPoolExecutor pool = BufferedMutatorThreadPoolExecutor.getPoolExecutor(hadoopConf);
BufferedMutatorParams mutatorParms = new BufferedMutatorParams(tableName)
.listener(listener)
.pool(pool);
if (options.getPeriodicFlushTimeout() > 0) {
mutatorParms = mutatorParms.setWriteBufferPeriodicFlushTimeoutMs(options.getPeriodicFlushTimeout());
}
try (
BufferedMutatorImpl mutator = (BufferedMutatorImpl) connection.getBufferedMutator(mutatorParms);
) {
Iterable<Row> documents = () -> rows;
for (Row doc : documents) {
String rowKey = doc.getString(0);
Put put = new Put(Bytes.toBytes(rowKey));
String value = doc.getString(2);
put.addColumn(Bytes.toBytes("valeur"), Bytes.toBytes(doc.getInt(1)), Bytes.toBytes(value == null ? "" : value));
value = doc.getString(3);
put.addColumn(Bytes.toBytes("valeur"), Bytes.toBytes("filler"), Bytes.toBytes(value == null ? "" : value));
mutator.mutate(put);
}
// If streaming: Final flush to make sure every thing is stored at the end of a microbatch //in batch, the close() will flush()
mutator.flush();
} catch (Exception e) {
log.info("Got exception ", e);
}
});

Apache-HBase · 2019-07-12T20:22:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	216	branch-2.1 passed
+1	compile	23	branch-2.1 passed
+1	checkstyle	29	branch-2.1 passed
+1	shadedjars	219	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	56	branch-2.1 passed
+1	javadoc	19	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	216	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
+1	checkstyle	28	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	224	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	898	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	65	the patch passed
+1	javadoc	20	the patch passed
		_ Other Tests _
-1	unit	260	hbase-client in the patch failed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2626

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncProcess

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/17/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3d45055c93ba 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `3c017c5`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/17/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/17/testReport/
Max. process+thread count	301 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/17/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-15T14:11:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	210	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	350	branch-2.1 passed
+1	compile	30	branch-2.1 passed
+1	checkstyle	44	branch-2.1 passed
+1	shadedjars	307	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	81	branch-2.1 passed
+1	javadoc	27	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	310	the patch passed
+1	compile	31	the patch passed
+1	javac	31	the patch passed
+1	checkstyle	41	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	303	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1234	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	91	the patch passed
+1	javadoc	27	the patch passed
		_ Other Tests _
-1	unit	311	hbase-client in the patch failed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		3790

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncProcess

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/18/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6b9d71257330 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `88ab7ac`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/18/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/18/testReport/
Max. process+thread count	303 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/18/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-16T11:08:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	298	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	32	branch-2.1 passed
+1	shadedjars	236	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	59	branch-2.1 passed
+1	javadoc	21	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	234	the patch passed
+1	compile	23	the patch passed
+1	javac	23	the patch passed
+1	checkstyle	30	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	232	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	931	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	65	the patch passed
+1	javadoc	21	the patch passed
		_ Other Tests _
-1	unit	234	hbase-client in the patch failed.
+1	asflicense	9	The patch does not generate ASF License warnings.
		2810

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncProcess

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 45f6f0afd18a 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `f017e7b`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/testReport/
Max. process+thread count	301 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-07T11:31:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	101	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	376	branch-2.1 passed
+1	compile	27	branch-2.1 passed
+1	checkstyle	41	branch-2.1 passed
+1	shadedjars	276	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	29	branch-2.1 passed
0	spotbugs	92	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	90	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	368	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	43	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	274	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1300	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	79	the patch passed
		_ Other Tests _
+1	unit	203	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3657

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/46/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5d943c830d25 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `46d0e5a`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/46/testReport/
Max. process+thread count	261 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/46/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-08-07T12:43:21Z

 disableWriteBufferPeriodicFlush();
+ ap.waitAllSlot();
+ try {
+ // Let time to the periodic flush thread to exit (task are finished, but not the code after)


What is the problem if the code after is not finished? I'm a bit nervous that we just set a magic 5ms sleep time here...

Apache9 · 2019-08-07T12:47:48Z

 private final boolean cleanupPoolOnClose;
 private volatile boolean closed = false;
 private final AsyncProcess ap;
+ private List<AsyncRequestFuture> asfList;


Does this field need to be a class member? It seems that we only use it in the doFlush method.

Apache9 · 2019-08-07T12:51:01Z

+ if (flushAll || writeBufferSize == 0) {
+ // if we have setWriteBufferPeriodicFlushTimeoutMs we may have concurrent update
+ List<AsyncRequestFuture> waitList;
+ synchronized(asfList) {


Oh, I see, BufferedMutator is thread safe, so multiple threads can enter this method at the same time and we want them to share the safe asfList, so it should be class member.

Apache9 · 2019-08-07T12:53:36Z

+ }
+ if (nbRemoved == 0) {
+ try {
+ Thread.sleep(1);


So this means we will do a busy waiting here? This is not always the best choice, maybe we should provide a configurable way to wait here, the default one should be the typical wait/notify, and if do not care wasting the CPU cycles but only want the maximum throughput, you can use busy waiting.

Apache9 · 2019-08-07T12:54:05Z

+ } else {
+ // Do some cleanup in asfList to decrease memory
+ int nbRemoved = 0;
+ while (asfList.size() >= maxThreads*4) {


Here we get size out of synchornized?

Apache-HBase · 2019-08-07T14:28:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	79	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	332	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	38	branch-2.1 passed
+1	shadedjars	256	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	24	branch-2.1 passed
0	spotbugs	76	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	73	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	307	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	38	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	254	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1300	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	94	the patch passed
		_ Other Tests _
+1	unit	201	hbase-client in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		3475

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/47/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7beb14a1e07e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `78c4e49`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/47/testReport/
Max. process+thread count	270 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/47/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-07T15:17:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	81	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	354	branch-2.1 passed
+1	compile	25	branch-2.1 passed
+1	checkstyle	39	branch-2.1 passed
+1	shadedjars	257	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	branch-2.1 passed
0	spotbugs	74	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	73	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	306	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	37	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	252	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1286	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	22	the patch passed
+1	findbugs	79	the patch passed
		_ Other Tests _
+1	unit	194	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3452

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/48/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3237fbf51b3a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343@2/out/precommit/personality/provided.sh
git revision	branch-2.1 / `0d50ce1`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/48/testReport/
Max. process+thread count	259 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/48/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-07T18:52:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	307	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	38	branch-2.1 passed
+1	shadedjars	235	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	branch-2.1 passed
0	spotbugs	72	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	70	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	278	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
+1	checkstyle	34	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	228	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1151	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	21	the patch passed
+1	findbugs	77	the patch passed
		_ Other Tests _
+1	unit	200	hbase-client in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		3109

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/49/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3d070eb302dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `d4d58f3`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/49/testReport/
Max. process+thread count	300 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/49/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-08T02:05:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	118	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	371	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	39	branch-2.1 passed
+1	shadedjars	276	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	branch-2.1 passed
0	spotbugs	79	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	77	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	320	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	39	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	264	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1388	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	26	the patch passed
+1	findbugs	85	the patch passed
		_ Other Tests _
+1	unit	206	hbase-client in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		3715

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/50/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ad1443169a5a 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `5cec62f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/50/testReport/
Max. process+thread count	257 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/50/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-08T12:05:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	161	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	356	branch-2.1 passed
+1	compile	26	branch-2.1 passed
+1	checkstyle	43	branch-2.1 passed
+1	shadedjars	272	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	branch-2.1 passed
0	spotbugs	76	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	74	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	65	the patch passed
+1	javac	65	the patch passed
+1	checkstyle	85	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	286	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1434	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	81	the patch passed
		_ Other Tests _
+1	unit	201	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3889

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/51/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 37c39a7d70ca 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `a5d981c`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/51/testReport/
Max. process+thread count	261 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/51/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-08T22:57:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	137	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	477	branch-2.1 passed
+1	compile	34	branch-2.1 passed
+1	checkstyle	47	branch-2.1 passed
+1	shadedjars	328	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	30	branch-2.1 passed
0	spotbugs	96	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	94	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	445	the patch passed
+1	compile	38	the patch passed
+1	javac	38	the patch passed
+1	checkstyle	47	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	315	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1765	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	29	the patch passed
+1	findbugs	101	the patch passed
		_ Other Tests _
+1	unit	220	hbase-client in the patch passed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		4644

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/52/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 42062b262c86 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `ea08907`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/52/testReport/
Max. process+thread count	268 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/52/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-09T08:01:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	87	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	330	branch-2.1 passed
+1	compile	26	branch-2.1 passed
+1	checkstyle	40	branch-2.1 passed
+1	shadedjars	272	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	27	branch-2.1 passed
0	spotbugs	84	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	80	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	40	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	275	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1406	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	88	the patch passed
		_ Other Tests _
+1	unit	207	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3668

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/53/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux c8862fa4ca00 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `2a707ad`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/53/testReport/
Max. process+thread count	275 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/53/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-09T08:42:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	157	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	411	branch-2.1 passed
+1	compile	28	branch-2.1 passed
+1	checkstyle	42	branch-2.1 passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	branch-2.1 passed
0	spotbugs	91	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	87	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	354	the patch passed
+1	compile	29	the patch passed
+1	javac	29	the patch passed
+1	checkstyle	43	hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	304	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1471	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	26	the patch passed
+1	findbugs	92	the patch passed
		_ Other Tests _
+1	unit	222	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		4042

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/54/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ed60dd2fb467 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `aaa9d93`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/54/testReport/
Max. process+thread count	289 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/54/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-11T21:30:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	333	branch-2.1 passed
+1	compile	24	branch-2.1 passed
+1	checkstyle	40	branch-2.1 passed
+1	shadedjars	264	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	30	branch-2.1 passed
0	spotbugs	89	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	87	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	365	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	37	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1343	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	83	the patch passed
		_ Other Tests _
+1	unit	199	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3637

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/55/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3eee6571095d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `c9d02f9`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/55/testReport/
Max. process+thread count	267 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/55/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-12T09:21:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	85	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	368	branch-2.1 passed
+1	compile	27	branch-2.1 passed
+1	checkstyle	41	branch-2.1 passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	branch-2.1 passed
0	spotbugs	82	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	79	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	309	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	40	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	294	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1359	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	89	the patch passed
		_ Other Tests _
-1	unit	210	hbase-client in the patch failed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		3650

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncProcess

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a619cf8d4c1c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `a0d5627`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/artifact/out/patch-unit-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/testReport/
Max. process+thread count	262 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/56/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-12T19:19:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	78	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	330	branch-2.1 passed
+1	compile	27	branch-2.1 passed
+1	checkstyle	45	branch-2.1 passed
+1	shadedjars	270	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	branch-2.1 passed
0	spotbugs	80	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	78	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	324	the patch passed
+1	compile	30	the patch passed
+1	javac	30	the patch passed
+1	checkstyle	41	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1338	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	22	the patch passed
+1	findbugs	82	the patch passed
		_ Other Tests _
+1	unit	203	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3567

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/57/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d98bc922f646 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `bfe09e9`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/57/testReport/
Max. process+thread count	268 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/57/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T05:14:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	115	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	430	branch-2.1 passed
+1	compile	33	branch-2.1 passed
+1	checkstyle	45	branch-2.1 passed
+1	shadedjars	304	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	28	branch-2.1 passed
0	spotbugs	101	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	98	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	400	the patch passed
+1	compile	36	the patch passed
+1	javac	36	the patch passed
+1	checkstyle	53	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	300	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1302	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	78	the patch passed
		_ Other Tests _
+1	unit	197	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3861

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/58/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 09072897a11c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `9ee32d8`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/58/testReport/
Max. process+thread count	270 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/58/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T08:00:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	111	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	345	branch-2.1 passed
+1	compile	27	branch-2.1 passed
+1	checkstyle	40	branch-2.1 passed
+1	shadedjars	269	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	branch-2.1 passed
0	spotbugs	78	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	77	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	30	the patch passed
+1	javac	30	the patch passed
+1	checkstyle	39	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	267	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1337	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	90	the patch passed
		_ Other Tests _
+1	unit	199	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3623

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/59/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 32abfb00c23e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `69946d1`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/59/testReport/
Max. process+thread count	252 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/59/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T19:34:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	364	branch-2.1 passed
+1	compile	23	branch-2.1 passed
+1	checkstyle	34	branch-2.1 passed
+1	shadedjars	235	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	22	branch-2.1 passed
0	spotbugs	70	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	68	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	264	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
+1	checkstyle	30	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	232	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1244	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	21	the patch passed
+1	findbugs	79	the patch passed
		_ Other Tests _
+1	unit	200	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3244

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/60/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e1243f99370a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `6444158`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/60/testReport/
Max. process+thread count	295 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/60/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T00:02:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	311	branch-2.1 passed
+1	compile	26	branch-2.1 passed
+1	checkstyle	35	branch-2.1 passed
+1	shadedjars	234	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	branch-2.1 passed
0	spotbugs	73	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	72	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	290	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	37	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	241	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1160	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	78	the patch passed
		_ Other Tests _
+1	unit	202	hbase-client in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		3165

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/61/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 20cd70060397 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `e27ef92`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/61/testReport/
Max. process+thread count	292 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/61/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T04:42:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	136	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	474	branch-2.1 passed
+1	compile	29	branch-2.1 passed
+1	checkstyle	47	branch-2.1 passed
+1	shadedjars	319	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	28	branch-2.1 passed
0	spotbugs	99	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	94	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	366	the patch passed
+1	compile	50	the patch passed
+1	javac	50	the patch passed
+1	checkstyle	54	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1627	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	28	the patch passed
+1	findbugs	100	the patch passed
		_ Other Tests _
+1	unit	223	hbase-client in the patch passed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		4294

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/62/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux aca5f00e913f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `fb7e7d8`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/62/testReport/
Max. process+thread count	298 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/62/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T05:47:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	172	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.1 Compile Tests _
+1	mvninstall	415	branch-2.1 passed
+1	compile	59	branch-2.1 passed
+1	checkstyle	40	branch-2.1 passed
+1	shadedjars	274	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	52	branch-2.1 passed
0	spotbugs	92	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	83	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	337	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	42	hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	265	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1343	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	javadoc	27	the patch passed
+1	findbugs	83	the patch passed
		_ Other Tests _
+1	unit	206	hbase-client in the patch passed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		3846

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/63/artifact/out/Dockerfile
GITHUB PR	#343
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ee62889b94ba 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh
git revision	branch-2.1 / `0c906f0`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/63/testReport/
Max. process+thread count	291 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/63/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-08-14T06:24:20Z

Close since no big progress here. Can open a new PR which targets to branch-2 if you have time @sbarnoud . Or I will try to port the patch if I have time.

sbarnoud · 2019-08-14T08:40:00Z

I’m on holiday. Anyway, i’m just surprised you close a performance patch without doing any performance test. So, i will keep the improvement for me ;-)

…

Le 14 août 2019 à 08:24, Duo Zhang ***@***.***> a écrit : Close since no big progress here. Can open a new PR which targets to branch-2 if you have time @sbarnoud . Or I will try to port the patch if I have time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Apache9 · 2019-08-14T08:59:24Z

Performance is not everything. To be honest, the patch is still not qualified enough to be merged. Please see my last comments, doing busy wait( sleep(1) ) on a critical path is usually a no no, especially that you are waiting for external I/O to complete rather than an in memory operation...

Anyway, I got your point that the current implementation of BufferMutator could be optimized to increase the concurrency. Will take a look if I have time.

Thanks.

sbarnoud · 2019-08-14T09:20:39Z

The sleep is on a « backpressure » path. Of course, we can replace it with a notify. But, when a system is overloaded it is often better to let it some time to unbuffer and not to overload it as soon as possible. This kind of decision can only be taken after a benchmark and not just after a code review

…

Le 14 août 2019 à 10:59, Duo Zhang ***@***.***> a écrit : Performance is not everything. To be honest, the patch is still not qualified enough to be merged. Please see my last comments, doing busy wait( sleep(1) ) on a critical path is usually a no no, especially that you are waiting for external I/O to complete rather than an in memory operation... Anyway, I got your point that the current implementation of BufferMutator could be optimized to increase the concurrency. Will take a look if I have time. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Apache9 · 2019-08-14T09:41:46Z

Not sure why you keep saying 'benchmark' since I never challenge the performance improvement of your patch?

sbarnoud · 2019-08-14T10:20:38Z

What i’m saying is that the sleep may provide better performance than a notify because it is called when the server latency increases (probably because it is overloaded). In that case, it may be better to give some time to the server to dequeue queries instead of submitting as soon as possible new one. Only a benchmark could differentiate the 2 approach, not a code review

…

Le 14 août 2019 à 11:42, Duo Zhang ***@***.***> a écrit : Not sure why you keep saying 'benchmark' since I never challenge the performance improvement of your patch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Apache9 · 2019-08-14T10:33:23Z

Please read my comment carefully

So this means we will do a busy waiting here? This is not always the best choice, maybe we should provide a configurable way to wait here, the default one should be the typical wait/notify, and if do not care wasting the CPU cycles but only want the maximum throughput, you can use busy waiting.

I'm not telling that sleep will have a worse performance right? Just make it configurable. Maximum throughput is not always the best choice. User may have a mixed workload and do not want to waste too many CPU cycles here.

In that case, it may be better to give some time to the server to dequeue queries instead of submitting as soon as possible new one.

I can not get the point here, we must wait until the server dequeue queries right? Otherwise we do not need to introduce the complicated slot logic...
The difference here is whether to use a 'while sleep' or a 'wait/notify'. My suggestion is to provide both.

Thanks.

sbarnoud · 2019-08-29T13:02:32Z

No 'while/sleep' nor 'wait/notify' needed anymore.

sbarnoud changed the title ~~HBASE-22634.001.branch-2.1~~HBASE-22634 : Improve performance of BufferedMutator Jun 26, 2019

Apache9 requested changes Jun 27, 2019
View reviewed changes

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java Outdated
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java

Apache9 requested changes Jun 27, 2019
View reviewed changes

sbarnoud force-pushed the branch-2.1 branch from 56607db to 650c8c9Compare June 28, 2019 09:36

HBASE-22634 Improve performance of BufferedMutator
12211f5

sbarnoud force-pushed the branch-2.1 branch from 8d7a7d4 to 12211f5Compare June 28, 2019 15:48

FIx add errors only when we get some.
ad270b8

Apache9 requested changes Aug 7, 2019
View reviewed changes

Apache9 closed this Aug 14, 2019

wchevreuil mentioned this pull request Oct 8, 2020
HBASE-22976 [HBCK2] Add RecoveredEditsPlayer #2504
Merged

wchevreuil mentioned this pull request Oct 29, 2025
HBASE-29644: Refresh_meta triggering compaction on user table #7385
Merged

Uh oh!

Conversation

sbarnoud commented Jun 26, 2019

Uh oh!

busbey commented Jun 26, 2019

Uh oh!

sbarnoud commented Jun 26, 2019 via email

Uh oh!

Apache-HBase commented Jun 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache9 commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 27, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

Apache-HBase commented Jun 28, 2019

Uh oh!

sbarnoud commented Jul 1, 2019

Uh oh!

Apache-HBase commented Jul 12, 2019

Uh oh!

Apache-HBase commented Jul 15, 2019

Uh oh!

Apache-HBase commented Jul 16, 2019

Uh oh!

Apache-HBase commented Aug 7, 2019

Uh oh!

Apache9Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 7, 2019

Uh oh!

Apache-HBase commented Aug 7, 2019

Uh oh!

Apache-HBase commented Aug 7, 2019