Skip to content

HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure … - #344

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22632
Jun 27, 2019
Merged

HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure …#344
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22632

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…should skip store files for unknown column families

@Apache9
Apache9 requested a review from infraioJune 27, 2019 03:47
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec27Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall247master passed
+1compile52master passed
+1checkstyle65master passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
+1findbugs215master passed
+1javadoc32master passed
_ Patch Compile Tests _
+1mvninstall237the patch passed
+1compile53the patch passed
+1javac53the patch passed
+1checkstyle68hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1whitespace0The patch has no whitespace issues.
+1shadedjars268patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck728Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs209the patch passed
+1javadoc30the patch passed
_ Other Tests _
-1unit8367hbase-server in the patch failed.
+1asflicense24The patch does not generate ASF License warnings.
11194
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestIgnoreUnknownFamily
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/artifact/out/Dockerfile
GITHUB PR#344
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 77178c255710 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 0198868
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/testReport/
Max. process+thread count4559 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…should skip store files for unknown column families
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec72Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall248master passed
+1compile53master passed
+1checkstyle74master passed
+1shadedjars269branch has no errors when building our shaded downstream artifacts.
+1findbugs213master passed
+1javadoc33master passed
_ Patch Compile Tests _
+1mvninstall236the patch passed
+1compile52the patch passed
+1javac52the patch passed
+1checkstyle77hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1whitespace0The patch has no whitespace issues.
+1shadedjars271patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck731Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs228the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit13020hbase-server in the patch failed.
+1asflicense25The patch does not generate ASF License warnings.
15955
SubsystemReport/Notes
DockerClient=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/artifact/out/Dockerfile
GITHUB PR#344
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux baff8c16fd33 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 0198868
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/testReport/
Max. process+thread count4790 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 94d5419 into apache:masterJun 27, 2019
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test. Fails w/o this patch?

@saintstack

Copy link
Copy Markdown
Contributor

Oh. Ignore. Missed that its merged.

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Jul 3, 2019
…should skip store files for unknown column families (apache#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…should skip store files for unknown column families (apache#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…should skip store files for unknown column families (apache#344)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit 98aa24a)
Change-Id: Ia6b3440e600140edf202963b10dbc09650900492
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@saintstack@infraio